May 2014 - Pollen-commits - mailman.cloud.codelutin.com

r3953 - in trunk/pollen-ui-angular/src/main/webapp: . js/controllers partials
by garandel＠users.chorem.org May 15, 2014

May 15, 2014

Author: garandel Date: 2014-05-15 18:12:07 +0200 (Thu, 15 May 2014) New Revision: 3953 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3953 Log: - delete debug code - catch error when delete the last choice - reverse downgrade angular version (it was an error) Modified: trunk/pollen-ui-angular/src/main/webapp/index.html trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html Modified: trunk/pollen-ui-angular/src/main/webapp/index.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/index.html 2014-05-15 15:37:52 UTC (rev 3952) +++ trunk/pollen-ui-angular/src/main/webapp/index.html 2014-05-15 16:12:07 UTC (rev 3953) @@ -28,10 +28,10 @@ <script src="js/conf.js"></script> <script src="http://cdnjs.cloudflare.com/ajax/libs/lodash.js/2.4.1/lodash.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-route.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-resource.min.…"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-cookies.min.js"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular.min.js"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-route.min.js"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-resource.min…"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-cookies.min.…"></script> <script src="http://cdnjs.cloudflare.com/ajax/libs/angular-ui-bootstrap/0.11.0/ui-bootst…"></script> <script src="js/libs/ckeditor/ckeditor.js"></script> Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:37:52 UTC (rev 3952) +++ trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 16:12:07 UTC (rev 3953) @@ -126,8 +126,6 @@ }, function () { $scope.globalVariables.lastType = choice.choiceType; $scope.globalVariables.lastDate = choice.date; - console.log(oldChoice); - console.log(choice); if (!angular.equals(oldChoice, choice)) { callBack(choice); } @@ -215,7 +213,6 @@ PollChoice.add({pollId:$routeParams.pollId, permission:$routeParams.token}, choice, function (data) { delete choice.restError; choice.topiaId = data.topiaId; - console.log(data); $scope.globalVariables.saved = true; }, function (error) { choice.restError = error.data; @@ -232,16 +229,15 @@ } $scope.deleteChoice = function (choice) { - var index = $scope.data.choices.indexOf(choice); - if (index > -1) { - $scope.data.choices.splice(index,1); - } PollChoice.delete({pollId:$routeParams.pollId, permission:$routeParams.token, choiceId: choice.topiaId}, function () { $scope.globalVariables.saved = true; + var index = $scope.data.choices.indexOf(choice); + if (index > -1) { + $scope.data.choices.splice(index,1); + } + }, function (error) { + angular.extend($scope.restError, error.data); }); - $timeout(function () { - $timeout.cancel(timeout); - },500); } var initPoll = function () { @@ -328,7 +324,6 @@ }); PollVote.add({pollId:$routeParams.pollId}, sendVote, function (returnRequest) { - console.log(returnRequest); $scope.data.votants.push(angular.copy($scope.data.vote)); $scope.globalVariables.saved = true; initVote(); Modified: trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 15:37:52 UTC (rev 3952) +++ trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 16:12:07 UTC (rev 3953) @@ -52,7 +52,6 @@ <tr ng-show="!globalVariables.editMode"> <td class="pollChoice"> <input type="text" class="form-control" placeholder="votre nom" ng-model="data.vote.voter.name" /> </td> <td ng-repeat="choice in data.vote.choice" class="pollChoice"> - {{choice.voteValue}} <input type="checkbox" name="{{choice.choice.topiaId}}" ng-model="choice.voteValue" /> </td> <td>

1 0

r3952 - trunk/pollen-ui-angular/src/main/webapp/js/controllers
by garandel＠users.chorem.org May 15, 2014

May 15, 2014

Author: garandel Date: 2014-05-15 17:37:52 +0200 (Thu, 15 May 2014) New Revision: 3952 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3952 Log: autoprint new vote Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:22:51 UTC (rev 3951) +++ trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:37:52 UTC (rev 3952) @@ -329,6 +329,7 @@ PollVote.add({pollId:$routeParams.pollId}, sendVote, function (returnRequest) { console.log(returnRequest); + $scope.data.votants.push(angular.copy($scope.data.vote)); $scope.globalVariables.saved = true; initVote(); });

1 0

r3951 - in trunk/pollen-ui-angular/src/main/webapp: js js/controllers partials
by garandel＠users.chorem.org May 15, 2014

May 15, 2014

Author: garandel Date: 2014-05-15 17:22:51 +0200 (Thu, 15 May 2014) New Revision: 3951 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3951 Log: fix vote persitence Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js trunk/pollen-ui-angular/src/main/webapp/js/services.js trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:06:28 UTC (rev 3950) +++ trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:22:51 UTC (rev 3951) @@ -317,23 +317,21 @@ $scope.data.vote.anonymous = false; $scope.data.vote.choice = []; for (var i = 0; i < $scope.data.choices.length; ++i) { - $scope.data.vote.choice.push({choiceId:$scope.data.choices[i].topiaId, voteValue:1}); + $scope.data.vote.choice.push({choiceId:$scope.data.choices[i].topiaId, voteValue:false}); } } $scope.voter = function () { - if ($scope.data.vote.name != '') { - PollVote.add({pollId:$routeParams.pollId}, $scope.data.vote, function (returnRequest) { - console.log(returnRequest); - }); + var sendVote = angular.copy($scope.data.vote); + angular.forEach(sendVote.choice, function (choice) { + choice.voteValue = (choice.voteValue) ? 1 : 0; + }); + PollVote.add({pollId:$routeParams.pollId}, sendVote, function (returnRequest) { + console.log(returnRequest); $scope.globalVariables.saved = true; - $scope.globalVariables.errorForm = false; initVote(); - } - else { - $scope.globalVariables.errorForm = true; - } + }); } }]) Modified: trunk/pollen-ui-angular/src/main/webapp/js/services.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/services.js 2014-05-15 15:06:28 UTC (rev 3950) +++ trunk/pollen-ui-angular/src/main/webapp/js/services.js 2014-05-15 15:22:51 UTC (rev 3951) @@ -67,15 +67,6 @@ .factory('PollVote', ['$resource', function ($resource) { var transformParam = function (data) { - angular.forEach(data.choice, function (choice) { - delete choice.$$hashKey; - if (choice.voteValue != null && !choice.voteValue) { - choice.voteValue = 1; - } - else { - choice.voteValue = 0; - } - }); return 'vote='+encodeURIComponent(JSON.stringify(data)); }; Modified: trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 15:06:28 UTC (rev 3950) +++ trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 15:22:51 UTC (rev 3951) @@ -52,6 +52,7 @@ <tr ng-show="!globalVariables.editMode"> <td class="pollChoice"> <input type="text" class="form-control" placeholder="votre nom" ng-model="data.vote.voter.name" /> </td> <td ng-repeat="choice in data.vote.choice" class="pollChoice"> + {{choice.voteValue}} <input type="checkbox" name="{{choice.choice.topiaId}}" ng-model="choice.voteValue" /> </td> <td>

1 0

r3950 - in trunk/pollen-ui-angular/src/main/webapp: . js js/controllers partials
by garandel＠users.chorem.org May 15, 2014

May 15, 2014

Author: garandel Date: 2014-05-15 17:06:28 +0200 (Thu, 15 May 2014) New Revision: 3950 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3950 Log: vote persistant Modified: trunk/pollen-ui-angular/src/main/webapp/index.html trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js trunk/pollen-ui-angular/src/main/webapp/js/services.js trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html trunk/pollen-ui-angular/src/main/webapp/partials/poll.html Modified: trunk/pollen-ui-angular/src/main/webapp/index.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/index.html 2014-05-15 14:06:25 UTC (rev 3949) +++ trunk/pollen-ui-angular/src/main/webapp/index.html 2014-05-15 15:06:28 UTC (rev 3950) @@ -28,10 +28,10 @@ <script src="js/conf.js"></script> <script src="http://cdnjs.cloudflare.com/ajax/libs/lodash.js/2.4.1/lodash.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-route.min.js"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-resource.min…"></script> - <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.15/angular-cookies.min.…"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular.min.js"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-route.min.js"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-resource.min.…"></script> + <script src="https://ajax.googleapis.com/ajax/libs/angularjs/1.2.6/angular-cookies.min.js"></script> <script src="http://cdnjs.cloudflare.com/ajax/libs/angular-ui-bootstrap/0.11.0/ui-bootst…"></script> <script src="js/libs/ckeditor/ckeditor.js"></script> Modified: trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 14:06:25 UTC (rev 3949) +++ trunk/pollen-ui-angular/src/main/webapp/js/controllers/pollCtrl.js 2014-05-15 15:06:28 UTC (rev 3950) @@ -111,6 +111,7 @@ } var popupChoice = function (choice, title, callBack) { + var oldChoice = angular.copy(choice); var modalInstance = $modal.open({ templateUrl : 'partials/poll-popupChoice.html', controller : PollPopChoiceCtrl, @@ -125,7 +126,11 @@ }, function () { $scope.globalVariables.lastType = choice.choiceType; $scope.globalVariables.lastDate = choice.date; - callBack(choice); + console.log(oldChoice); + console.log(choice); + if (!angular.equals(oldChoice, choice)) { + callBack(choice); + } }); } @@ -288,30 +293,34 @@ $scope.data.choices = choices; initVote(); }); + PollVote.query({pollId:$routeParams.pollId}, function (votes) { + $scope.data.votants = votes; + angular.forEach($scope.data.votants, function (vote) { + angular.forEach(vote.choice, function (choice) { + if (choice.voteValue != null && choice.voteValue != 0) { + choice.voteValue = true; + } + else { + choice.voteValue = false; + } + }) + }) + }) } initPoll(); $scope.globalVariables.editMode = false; - $scope.$watch('data.vote.name', function (newVal) { - if (newVal != '') { - $scope.globalVariables.errorForm = false; - } - }); var initVote = function () { $scope.data.vote = {}; $scope.data.vote.voter = {name : ""}; $scope.data.vote.anonymous = false; - $scope.data.vote.voteToChoices = []; + $scope.data.vote.choice = []; for (var i = 0; i < $scope.data.choices.length; ++i) { - $scope.data.vote.voteToChoices.push({choiceId:$scope.data.choices[i].topiaId, voteValue:false}); + $scope.data.vote.choice.push({choiceId:$scope.data.choices[i].topiaId, voteValue:1}); } } - PollVote.query({pollId:$routeParams.pollId}, function (data) { - $scope.data.votants = data; - }) - $scope.voter = function () { if ($scope.data.vote.name != '') { PollVote.add({pollId:$routeParams.pollId}, $scope.data.vote, function (returnRequest) { Modified: trunk/pollen-ui-angular/src/main/webapp/js/services.js =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/services.js 2014-05-15 14:06:25 UTC (rev 3949) +++ trunk/pollen-ui-angular/src/main/webapp/js/services.js 2014-05-15 15:06:28 UTC (rev 3950) @@ -67,6 +67,15 @@ .factory('PollVote', ['$resource', function ($resource) { var transformParam = function (data) { + angular.forEach(data.choice, function (choice) { + delete choice.$$hashKey; + if (choice.voteValue != null && !choice.voteValue) { + choice.voteValue = 1; + } + else { + choice.voteValue = 0; + } + }); return 'vote='+encodeURIComponent(JSON.stringify(data)); }; Modified: trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 14:06:25 UTC (rev 3949) +++ trunk/pollen-ui-angular/src/main/webapp/partials/inline-poll.html 2014-05-15 15:06:28 UTC (rev 3950) @@ -51,8 +51,8 @@  <tr ng-show="!globalVariables.editMode"> <td class="pollChoice"> <input type="text" class="form-control" placeholder="votre nom" ng-model="data.vote.voter.name" /> </td> - <td ng-repeat="choice in data.vote.voteToChoices" class="pollChoice"> - <input type="checkbox" name="{{choice.choice.topiaId}}" ng-model="choice.voteValue"/> + <td ng-repeat="choice in data.vote.choice" class="pollChoice"> + <input type="checkbox" name="{{choice.choice.topiaId}}" ng-model="choice.voteValue" /> </td> <td> <input class="btn btn-primary btn-large" type="button" value="Vote" ng-click="voter()" /> @@ -62,11 +62,10 @@  <tr ng-repeat="vote in data.votants track by $index" class="pollAnim" ng-show="!globalVariables.editMode"> - <td class="pollChoice"> {{vote.name}}</td> - <td ng-repeat="choice in vote.choices" class="pollChoice"> - <input type="checkbox" ng-model="choice.value" disabled/> + <td class="pollChoice"> {{vote.voter.name}}</td> + <td ng-repeat="choice in vote.choice" class="pollChoice"> + <input type="checkbox" ng-model="choice.voteValue" disabled /> </td> </tr>  </table> - Modified: trunk/pollen-ui-angular/src/main/webapp/partials/poll.html =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/partials/poll.html 2014-05-15 14:06:25 UTC (rev 3949) +++ trunk/pollen-ui-angular/src/main/webapp/partials/poll.html 2014-05-15 15:06:28 UTC (rev 3950) @@ -19,7 +19,7 @@ #L% --> -<form class="form-horizontal"> +<form class="form-horizontal" novalidate> <alert type="danger" ng-if="globalVariables.errorForm"> Champ non remplie </alert> <alert type="danger" ng-if="restError.choice"> Vous devez avoir au moins 1 choix </alert>

1 0

r3949 - trunk/pollen-services/src/main/java/org/chorem/pollen/services/service
by tchemit＠users.chorem.org May 15, 2014

May 15, 2014

Author: tchemit Date: 2014-05-15 16:06:25 +0200 (Thu, 15 May 2014) New Revision: 3949 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3949 Log: copy votes Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java =================================================================== --- trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java 2014-05-15 13:50:25 UTC (rev 3948) +++ trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java 2014-05-15 14:06:25 UTC (rev 3949) @@ -23,7 +23,6 @@ * #L% */ -import com.google.common.collect.ImmutableList; import org.apache.commons.lang3.StringUtils; import org.chorem.pollen.persistence.entity.Choice; import org.chorem.pollen.persistence.entity.Poll; @@ -53,7 +52,7 @@ Poll poll = getPollService().getPoll0(pollId); List<Vote> votes = getVoteDao().forPollEquals(poll).findAll(); - return ImmutableList.copyOf(votes); + return copyAsList(votes); } @@ -65,7 +64,7 @@ Poll poll = getPollService().getPoll0(pollId); Vote result = getVote(poll, voteId); - return result; + return copy(result); } @@ -87,7 +86,7 @@ getNotificationService().onVoteAdded(poll, result); - return result; + return copy(result); } @@ -107,7 +106,7 @@ getNotificationService().onVoteEdited(poll, result); - return result; + return copy(result); }

1 0

r3948 - trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1
by tchemit＠users.chorem.org May 15, 2014

May 15, 2014

Author: tchemit Date: 2014-05-15 15:50:25 +0200 (Thu, 15 May 2014) New Revision: 3948 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3948 Log: copy voter to VoteBean Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java 2014-05-15 12:44:39 UTC (rev 3947) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java 2014-05-15 13:50:25 UTC (rev 3948) @@ -1,7 +1,6 @@ package org.chorem.pollen.rest.api.v1; import org.chorem.pollen.persistence.entity.PollenPrincipal; -import org.chorem.pollen.persistence.entity.PollenPrincipalImpl; import org.chorem.pollen.persistence.entity.Vote; import org.chorem.pollen.persistence.entity.VoteImpl; import org.chorem.pollen.persistence.entity.VoteToChoice; @@ -51,6 +50,7 @@ VoteBean voteBean = new VoteBean(); voteBean.setAnonymous(vote.isAnonymous()); + voteBean.setVoter(vote.getVoter()); for (VoteToChoice voteToChoice : vote.getVoteToChoice()) {

1 0

r3947 - trunk/pollen-ui-angular/src/main/webapp/js
by athimel＠users.chorem.org May 15, 2014

May 15, 2014

Author: athimel Date: 2014-05-15 14:44:39 +0200 (Thu, 15 May 2014) New Revision: 3947 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3947 Log: Fix sample REST base URL Modified: trunk/pollen-ui-angular/src/main/webapp/js/conf.js.exemple Modified: trunk/pollen-ui-angular/src/main/webapp/js/conf.js.exemple =================================================================== --- trunk/pollen-ui-angular/src/main/webapp/js/conf.js.exemple 2014-05-15 11:04:07 UTC (rev 3946) +++ trunk/pollen-ui-angular/src/main/webapp/js/conf.js.exemple 2014-05-15 12:44:39 UTC (rev 3947) @@ -1,4 +1,4 @@ var conf = { // Rest-API Base Url - restURL : "http://exemple.com/api" + restURL : "http://exemple.com/pollen-rest-api/v1" } \ No newline at end of file

1 0

r3946 - in trunk: pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1 pollen-services/src/main/java/org/chorem/pollen/services/service pollen-services/src/main/java/org/chorem/pollen/services/service/security
by tchemit＠users.chorem.org May 15, 2014

May 15, 2014

Author: tchemit Date: 2014-05-15 13:04:07 +0200 (Thu, 15 May 2014) New Revision: 3946 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3946 Log: can now vote Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/security/SecurityService.java Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java 2014-05-15 10:35:46 UTC (rev 3945) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java 2014-05-15 11:04:07 UTC (rev 3946) @@ -1,6 +1,7 @@ package org.chorem.pollen.rest.api.v1; import org.chorem.pollen.persistence.entity.PollenPrincipal; +import org.chorem.pollen.persistence.entity.PollenPrincipalImpl; import org.chorem.pollen.persistence.entity.Vote; import org.chorem.pollen.persistence.entity.VoteImpl; import org.chorem.pollen.persistence.entity.VoteToChoice; @@ -68,6 +69,7 @@ Vote vote = new VoteImpl(); vote.setAnonymous(getAnonymous() != null && getAnonymous()); + vote.setVoter(getVoter()); for (VoteToChoiceBean choiceBean : choice) { VoteToChoice voteToChoice = choiceBean.toEntity(); Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java =================================================================== --- trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java 2014-05-15 10:35:46 UTC (rev 3945) +++ trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/VoteService.java 2014-05-15 11:04:07 UTC (rev 3946) @@ -24,13 +24,20 @@ */ import com.google.common.collect.ImmutableList; +import org.apache.commons.lang3.StringUtils; +import org.chorem.pollen.persistence.entity.Choice; import org.chorem.pollen.persistence.entity.Poll; +import org.chorem.pollen.persistence.entity.PollenPrincipal; import org.chorem.pollen.persistence.entity.Polls; import org.chorem.pollen.persistence.entity.Vote; +import org.chorem.pollen.persistence.entity.VoteToChoice; +import org.chorem.pollen.persistence.entity.VoteToChoiceTopiaDao; import org.chorem.pollen.services.service.security.PermissionVerb; import java.util.Date; +import java.util.HashSet; import java.util.List; +import java.util.Set; /** * TODO @@ -159,20 +166,37 @@ // -- author -- // -// PollenPrincipal author = getSecurityService().generatePollenPrincipal(); -// toSave.setAuthor(author); + PollenPrincipal author = getSecurityService().generatePollenPrincipal(); + toSave.setVoter(author); toSave.setPoll(poll); } + toSave.setAnonymous(vote.isAnonymous()); + // toSave.setText(vote.getText()); // -// // -- author -- // -// -// toSave.getAuthor().setName(vote.getAuthor().getName()); -// if (StringUtils.isNotBlank(vote.getAuthor().getEmail())) { -// toSave.getAuthor().setEmail(StringUtils.lowerCase(vote.getAuthor().getEmail())); -// } + // -- author -- // + toSave.getVoter().setName(vote.getVoter().getName()); + if (StringUtils.isNotBlank(vote.getVoter().getEmail())) { + toSave.getVoter().setEmail(getCleanMail(vote.getVoter().getEmail())); + } + + // -- List of VoteToChoice -- // + + Set<VoteToChoice> choicesToSave = new HashSet<>(); + for (VoteToChoice input : vote.getVoteToChoice()) { + + Double value = input.getVoteValue(); + if (value != null) { + VoteToChoice voteToChoice = createVoteToChoice(toSave, input); + choicesToSave.add(voteToChoice); + } + + } + + toSave.setVoteToChoice(choicesToSave); + return toSave; } @@ -191,4 +215,47 @@ } + protected VoteToChoice getVoteToChoice(Vote vote, String voteToChoiceId) { + + VoteToChoice result = getVoteToChoiceDao().findByTopiaId(voteToChoiceId); + + if (!vote.containsVoteToChoice(result)) { + + throw new InvalidEntityLinkException(Vote.PROPERTY_VOTE_TO_CHOICE, result, vote); + + } + + return result; + + } + + + protected VoteToChoice createVoteToChoice(Vote vote, VoteToChoice source) { + + VoteToChoiceTopiaDao voteToChoiceDao = getVoteToChoiceDao(); + + VoteToChoice result; + + if (source.isPersisted()) { + + result = getVoteToChoice(vote, source.getTopiaId()); + + } else { + + result = voteToChoiceDao.create(); + + String choiceId = source.getChoice().getTopiaId(); + + Choice choiceLoaded = getChoiceDao().findByTopiaId(choiceId); + + result.setChoice(choiceLoaded); + + vote.addVoteToChoice(result); + + } + + result.setVoteValue(source.getVoteValue()); + + return result; + } } Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/security/SecurityService.java =================================================================== --- trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/security/SecurityService.java 2014-05-15 10:35:46 UTC (rev 3945) +++ trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/security/SecurityService.java 2014-05-15 11:04:07 UTC (rev 3946) @@ -281,7 +281,7 @@ for (Poll poll : polls) { permissions.add(createSubjectPermission(PermissionVerb.readPoll, poll)); - permissions.add(createSubjectPermission(PermissionVerb.readPoll, poll)); + permissions.add(createSubjectPermission(PermissionVerb.addVote, poll)); // add choices permissions

1 0

r3945 - in trunk: pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1 pollen-services/src/main/java/org/chorem/pollen/services/service
by tchemit＠users.chorem.org May 15, 2014

May 15, 2014

Author: tchemit Date: 2014-05-15 12:35:46 +0200 (Thu, 15 May 2014) New Revision: 3945 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3945 Log: can not delete last choice of a poll Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/ChoiceApi.java trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/ChoiceApi.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/ChoiceApi.java 2014-05-15 10:32:05 UTC (rev 3944) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/ChoiceApi.java 2014-05-15 10:35:46 UTC (rev 3945) @@ -69,7 +69,7 @@ } - public void deleteChoice(ChoiceService choiceService, String pollId, String choiceId) { + public void deleteChoice(ChoiceService choiceService, String pollId, String choiceId) throws InvalidFormException { choiceService.deleteChoice(pollId, choiceId); Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java =================================================================== --- trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java 2014-05-15 10:32:05 UTC (rev 3944) +++ trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java 2014-05-15 10:35:46 UTC (rev 3945) @@ -138,7 +138,7 @@ } - public void deleteChoice(String pollId, String choiceId) { + public void deleteChoice(String pollId, String choiceId) throws InvalidFormException { checkNotNull(pollId); checkNotNull(choiceId); @@ -147,6 +147,16 @@ Poll poll = getPollService().getPoll0(pollId); Choice choice = getChoice(poll, choiceId); + List<Choice> existingChoices = getChoiceDao().findAll(poll); + if (existingChoices.size() == 1) { + + // can't delete this choice + // will be the last one + ErrorMap errors = new ErrorMap(); + errors.addError("choice", "need at least one choice"); + errors.failIfNotEmpty(); + } + //TODO Check if this is not the last choice, if so can not delete getChoiceDao().delete(choice); commit();

1 0

r3944 - in trunk: pollen-rest-api/src/main/java/org/chorem/pollen/rest/api pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1 pollen-rest-api/src/main/resources pollen-rest-api/src/test/java/org/chorem/pollen/rest/api pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter pollen-services/src/main/java/org/chorem/pollen/services/service
by tchemit＠users.chorem.org May 15, 2014

May 15, 2014

Author: tchemit Date: 2014-05-15 12:32:05 +0200 (Thu, 15 May 2014) New Revision: 3944 Url: http://forge.chorem.org/projects/pollen/repository/revisions/3944 Log: introduce converter package + a JsonConverter to replace the EntityConverter + add some bean for vote Added: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/JsonConverter.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverter.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverter.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteToChoiceBean.java trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/JsonConverterTest.java trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverterTest.java trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverterTest.java Removed: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverter.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverterTest.java trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityConverterTest.java Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/PollenRestApiApplicationListener.java trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteApi.java trunk/pollen-rest-api/src/main/resources/mapping trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/PollenRestApiApplicationListener.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/PollenRestApiApplicationListener.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/PollenRestApiApplicationListener.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -24,6 +24,10 @@ */ import org.chorem.pollen.persistence.PollenEntityEnum; +import org.chorem.pollen.rest.api.converter.JsonConverter; +import org.chorem.pollen.rest.api.converter.TopiaEntityArrayConverter; +import org.chorem.pollen.rest.api.v1.VoteBean; +import org.chorem.pollen.rest.api.v1.VoteToChoiceBean; import org.chorem.pollen.services.PollenService; import org.debux.webmotion.server.WebMotionServerListener; import org.debux.webmotion.server.call.Call; @@ -50,7 +54,7 @@ for (Class<? extends TopiaEntity> entityClass : PollenEntityEnum.getContractClasses()) { - TopiaEntityConverter<? extends TopiaEntity> converter = TopiaEntityConverter.newconverter(entityClass); + JsonConverter converter = JsonConverter.newEntityconverter(entityClass); serverContext.addConverter(converter, entityClass); TopiaEntityArrayConverter<? extends TopiaEntity> arrayConverter = TopiaEntityArrayConverter.newconverter(entityClass); @@ -58,6 +62,9 @@ } + serverContext.addConverter(JsonConverter.newConverter(VoteBean.class), VoteBean.class); + serverContext.addConverter(JsonConverter.newConverter(VoteToChoiceBean.class), VoteToChoiceBean.class); + // --- init injectors --- // serverContext.addInjector(new ExecutorParametersInjectorHandler.Injector() { Deleted: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverter.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverter.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverter.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -1,88 +0,0 @@ -package org.chorem.pollen.rest.api; - -/* - * #%L - * Pollen :: Rest Api - * %% - * Copyright (C) 2009 - 2014 CodeLutin - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * #L% - */ - -import com.fasterxml.jackson.databind.ObjectMapper; -import org.apache.commons.beanutils.converters.AbstractConverter; -import org.chorem.pollen.services.PollenTechnicalException; -import org.nuiton.topia.persistence.TopiaEntity; - -import java.io.IOException; -import java.lang.reflect.Array; - -/** - * Created on 5/7/14. - * - * @author Tony Chemit <chemit(a)codelutin.com> - * @since 2.0 - */ -public class TopiaEntityArrayConverter<E extends TopiaEntity> extends AbstractConverter { - - protected final Class<E[]> type; - - protected final ObjectMapper mapper; - - - public static <E extends TopiaEntity> TopiaEntityArrayConverter<E> newconverter(Class<E> entityType) { - return new TopiaEntityArrayConverter<>(entityType); - } - - public TopiaEntityArrayConverter(Class<E> entityType) { - this.type = getArrayClass(entityType); - this.mapper = Jsons.newEntityMapper(); - } - - <T> Class<T[]> getArrayClass(Class<T> clazz) { - return (Class<T[]>) Array.newInstance(clazz, 0).getClass(); - } - - @Override - protected <T> T convertToType(Class<T> type, Object value) throws Throwable { - - String stringValue; - - if (value instanceof String) { - - stringValue = (String) value; - - } else { - - stringValue = ((String[]) value)[0]; - - } - - try { - - E[] values = mapper.readValue(stringValue, this.type); - return (T) values; - - } catch (IOException e) { - throw new PollenTechnicalException("Could not convert " + stringValue + " to " + type.getName(), e); - } - - } - - @Override - protected Class<?> getDefaultType() { - return type; - } -} Deleted: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -1,119 +0,0 @@ -package org.chorem.pollen.rest.api; - -/* - * #%L - * Pollen :: Rest Api - * %% - * Copyright (C) 2009 - 2014 CodeLutin - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * #L% - */ - -import com.fasterxml.jackson.databind.ObjectMapper; -import com.fasterxml.jackson.databind.module.SimpleModule; -import org.apache.commons.beanutils.converters.AbstractConverter; -import org.chorem.pollen.persistence.PollenEntityEnum; -import org.chorem.pollen.services.PollenTechnicalException; -import org.nuiton.topia.persistence.TopiaEntity; - -import java.io.IOException; - -/** - * Created on 5/6/14. - * - * @author Tony Chemit <chemit(a)codelutin.com> - * @since 2.0 - */ -public class TopiaEntityConverter<E extends TopiaEntity> extends AbstractConverter { - - protected Class<E> entityType; - - protected Class<E> implementationClass; - - protected ObjectMapper mapper; - - public static <E extends TopiaEntity> TopiaEntityConverter<E> newconverter(Class<E> entityType) { - return new TopiaEntityConverter<>(entityType); - } - - public TopiaEntityConverter(Class<E> entityType) { - - this.entityType = entityType; - - this.implementationClass = PollenEntityEnum.getImplementationClass(entityType); - - SimpleModule module = new SimpleModule(); - - for (Class<? extends TopiaEntity> entityClass : PollenEntityEnum.getContractClasses()) { - - Class concreteClass = PollenEntityEnum.getImplementationClass(entityClass); - module.addAbstractTypeMapping(entityClass, concreteClass); - - } - - mapper = Jsons.newEntityMapper(); - - } - - public ObjectMapper getMapper() { - - return mapper; - - } - - @Override - protected String convertToString(Object value) throws Throwable { - - String result = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(value); - return result; - - } - - @Override - protected <T> T convertToType(Class<T> type, Object value) throws Throwable { - - String stringValue; - - if (value instanceof String) { - - stringValue = (String) value; - - } else { - - stringValue = ((String[]) value)[0]; - - } - - try { - - T result = (T) mapper.readValue(stringValue, implementationClass); - - return result; - - } catch (IOException e) { - throw new PollenTechnicalException("Could not convert " + stringValue + " to " + type.getName(), e); - } - - } - - @Override - protected Class<E> getDefaultType() { - - return entityType; - - } - - -} Copied: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/JsonConverter.java (from rev 3938, trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java) =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/JsonConverter.java (rev 0) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/JsonConverter.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,135 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.module.SimpleModule; +import org.apache.commons.beanutils.converters.AbstractConverter; +import org.chorem.pollen.persistence.PollenEntityEnum; +import org.chorem.pollen.rest.api.Jsons; +import org.chorem.pollen.services.PollenTechnicalException; +import org.nuiton.topia.persistence.TopiaEntity; + +import java.io.IOException; + +/** + * Created on 5/6/14. + * + * @author Tony Chemit <chemit(a)codelutin.com> + * @since 2.0 + */ +public class JsonConverter<O> extends AbstractConverter { + + protected Class<O> entityType; + + protected Class<O> implementationClass; + + protected ObjectMapper mapper; + + public static <O> JsonConverter<O> newConverter(Class<O> entityType) { + return newConverter(entityType, entityType); + } + + public static <E extends TopiaEntity> JsonConverter<E> newEntityconverter(Class<E> entityType) { + Class<E> implementationClass = PollenEntityEnum.getImplementationClass(entityType); + return newConverter(entityType, implementationClass); + } + + public static <O> JsonConverter<O> newConverter(Class<O> entityType, Class<O> implementationClass) { + return new JsonConverter<>(entityType, implementationClass); + } + + public JsonConverter(Class<O> entityType, Class<O> implementationClass) { + + this.entityType = entityType; + + this.implementationClass = implementationClass; + + SimpleModule module = new SimpleModule(); + + if (entityType != implementationClass) { + + module.addAbstractTypeMapping(entityType, implementationClass); + + } + + for (Class<? extends TopiaEntity> entityClass : PollenEntityEnum.getContractClasses()) { + + Class concreteClass = PollenEntityEnum.getImplementationClass(entityClass); + module.addAbstractTypeMapping(entityClass, concreteClass); + + } + + mapper = Jsons.newEntityMapper(); + + } + + public ObjectMapper getMapper() { + + return mapper; + + } + + @Override + protected String convertToString(Object value) throws Throwable { + + String result = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(value); + return result; + + } + + @Override + protected <T> T convertToType(Class<T> type, Object value) throws Throwable { + + String stringValue; + + if (value instanceof String) { + + stringValue = (String) value; + + } else { + + stringValue = ((String[]) value)[0]; + + } + + try { + + T result = (T) mapper.readValue(stringValue, implementationClass); + + return result; + + } catch (IOException e) { + throw new PollenTechnicalException("Could not convert " + stringValue + " to " + type.getName(), e); + } + + } + + @Override + protected Class<O> getDefaultType() { + + return entityType; + + } + + +} Copied: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverter.java (from rev 3938, trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverter.java) =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverter.java (rev 0) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverter.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,88 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import com.fasterxml.jackson.databind.ObjectMapper; +import org.apache.commons.beanutils.converters.AbstractConverter; +import org.chorem.pollen.rest.api.Jsons; +import org.chorem.pollen.services.PollenTechnicalException; +import org.nuiton.topia.persistence.TopiaEntity; + +import java.io.IOException; +import java.lang.reflect.Array; + +/** + * Created on 5/7/14. + * + * @author Tony Chemit <chemit(a)codelutin.com> + * @since 2.0 + */ +public class TopiaEntityArrayConverter<E extends TopiaEntity> extends AbstractConverter { + + protected final Class<E[]> type; + + protected final ObjectMapper mapper; + + public static <E extends TopiaEntity> TopiaEntityArrayConverter<E> newconverter(Class<E> entityType) { + return new TopiaEntityArrayConverter<>(entityType); + } + + public TopiaEntityArrayConverter(Class<E> entityType) { + this.type = getArrayClass(entityType); + this.mapper = Jsons.newEntityMapper(); + } + + <T> Class<T[]> getArrayClass(Class<T> clazz) { + return (Class<T[]>) Array.newInstance(clazz, 0).getClass(); + } + + @Override + protected <T> T convertToType(Class<T> type, Object value) throws Throwable { + + String stringValue; + + if (value instanceof String) { + + stringValue = (String) value; + + } else { + + stringValue = ((String[]) value)[0]; + + } + + try { + + E[] values = mapper.readValue(stringValue, this.type); + return (T) values; + + } catch (IOException e) { + throw new PollenTechnicalException("Could not convert " + stringValue + " to " + type.getName(), e); + } + + } + + @Override + public Class<?> getDefaultType() { + return type; + } +} Copied: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverter.java (from rev 3938, trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/TopiaEntityConverter.java) =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverter.java (rev 0) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverter.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,120 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.module.SimpleModule; +import org.apache.commons.beanutils.converters.AbstractConverter; +import org.chorem.pollen.persistence.PollenEntityEnum; +import org.chorem.pollen.rest.api.Jsons; +import org.chorem.pollen.services.PollenTechnicalException; +import org.nuiton.topia.persistence.TopiaEntity; + +import java.io.IOException; + +/** + * Created on 5/6/14. + * + * @author Tony Chemit <chemit(a)codelutin.com> + * @since 2.0 + */ +public class TopiaEntityConverter<E extends TopiaEntity> extends AbstractConverter { + + protected Class<E> entityType; + + protected Class<E> implementationClass; + + protected ObjectMapper mapper; + + public static <E extends TopiaEntity> TopiaEntityConverter<E> newconverter(Class<E> entityType) { + return new TopiaEntityConverter<>(entityType); + } + + public TopiaEntityConverter(Class<E> entityType) { + + this.entityType = entityType; + + this.implementationClass = PollenEntityEnum.getImplementationClass(entityType); + + SimpleModule module = new SimpleModule(); + + for (Class<? extends TopiaEntity> entityClass : PollenEntityEnum.getContractClasses()) { + + Class concreteClass = PollenEntityEnum.getImplementationClass(entityClass); + module.addAbstractTypeMapping(entityClass, concreteClass); + + } + + mapper = Jsons.newEntityMapper(); + + } + + public ObjectMapper getMapper() { + + return mapper; + + } + + @Override + protected String convertToString(Object value) throws Throwable { + + String result = mapper.writerWithDefaultPrettyPrinter().writeValueAsString(value); + return result; + + } + + @Override + protected <T> T convertToType(Class<T> type, Object value) throws Throwable { + + String stringValue; + + if (value instanceof String) { + + stringValue = (String) value; + + } else { + + stringValue = ((String[]) value)[0]; + + } + + try { + + T result = (T) mapper.readValue(stringValue, implementationClass); + + return result; + + } catch (IOException e) { + throw new PollenTechnicalException("Could not convert " + stringValue + " to " + type.getName(), e); + } + + } + + @Override + protected Class<E> getDefaultType() { + + return entityType; + + } + + +} Modified: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteApi.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteApi.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteApi.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -29,6 +29,7 @@ import org.chorem.pollen.services.service.VoteService; import org.debux.webmotion.server.WebMotionController; +import java.util.ArrayList; import java.util.List; /** @@ -39,33 +40,47 @@ */ public class VoteApi extends WebMotionController { - public List<Vote> getVotes(VoteService voteService, String pollId) { + public List<VoteBean> getVotes(VoteService voteService, String pollId) { List<Vote> votes = voteService.getVotes(pollId); - return votes; + List<VoteBean> votesBean = new ArrayList<>(); + for (Vote vote : votes) { + VoteBean voteBean = VoteBean.fromEntity(vote); + votesBean.add(voteBean); + + } + + return votesBean; + } - public Vote getVote(VoteService voteService, String pollId, String voteId) { + public VoteBean getVote(VoteService voteService, String pollId, String voteId) { Vote vote = voteService.getVote(pollId, voteId); - return vote; + VoteBean voteBean = VoteBean.fromEntity(vote); + return voteBean; } - public PollenPrincipalRef<Vote> addVote(VoteService voteService, String pollId, Vote vote) throws InvalidFormException { + public PollenPrincipalRef<Vote> addVote(VoteService voteService, String pollId, VoteBean vote) throws InvalidFormException { - Vote createdVote = voteService.addVote(pollId, vote); + Vote entity = vote.toEntity(); + + Vote createdVote = voteService.addVote(pollId, entity); PollenPrincipalRef<Vote> principalRef = PollenPrincipalRef.newRef(createdVote); return principalRef; } - public Vote editVote(VoteService voteService, String pollId, Vote vote) throws InvalidFormException { + public VoteBean editVote(VoteService voteService, String pollId, VoteBean vote) throws InvalidFormException { - Vote editedVote = voteService.editVote(pollId, vote); - return editedVote; + Vote entity = vote.toEntity(); + Vote editedVote = voteService.editVote(pollId, entity); + VoteBean editedVoteBean = VoteBean.fromEntity(editedVote); + return editedVoteBean; + } public void deleteVote(VoteService voteService, String pollId, String voteId) { Added: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java (rev 0) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,80 @@ +package org.chorem.pollen.rest.api.v1; + +import org.chorem.pollen.persistence.entity.PollenPrincipal; +import org.chorem.pollen.persistence.entity.Vote; +import org.chorem.pollen.persistence.entity.VoteImpl; +import org.chorem.pollen.persistence.entity.VoteToChoice; + +import java.util.HashSet; +import java.util.Set; + +/** + * Created on 5/15/14. + * + * @author Tony Chemit <chemit(a)codelutin.com> + * @since 2.0 + */ +public class VoteBean { + + protected PollenPrincipal voter; + + protected Boolean anonymous; + + protected Set<VoteToChoiceBean> choice = new HashSet<>(); + + public PollenPrincipal getVoter() { + return voter; + } + + public void setVoter(PollenPrincipal voter) { + this.voter = voter; + } + + public Boolean getAnonymous() { + return anonymous; + } + + public void setAnonymous(Boolean anonymous) { + this.anonymous = anonymous; + } + + public Set<VoteToChoiceBean> getChoice() { + return choice; + } + + public void addChoice(VoteToChoiceBean choice) { + this.choice.add(choice); + } + + public static VoteBean fromEntity(Vote vote) { + + VoteBean voteBean = new VoteBean(); + voteBean.setAnonymous(vote.isAnonymous()); + + for (VoteToChoice voteToChoice : vote.getVoteToChoice()) { + + VoteToChoiceBean choiceBean = new VoteToChoiceBean(); + choiceBean.setChoiceId(voteToChoice.getChoice().getTopiaId()); + choiceBean.setVoteValue(voteToChoice.getVoteValue()); + voteBean.addChoice(choiceBean); + + } + + return voteBean; + + } + + public Vote toEntity() { + + Vote vote = new VoteImpl(); + vote.setAnonymous(getAnonymous() != null && getAnonymous()); + for (VoteToChoiceBean choiceBean : choice) { + + VoteToChoice voteToChoice = choiceBean.toEntity(); + vote.addVoteToChoice(voteToChoice); + + } + return vote; + + } +} Property changes on: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteBean.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision Added: svn:eol-style + native Added: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteToChoiceBean.java =================================================================== --- trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteToChoiceBean.java (rev 0) +++ trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteToChoiceBean.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,45 @@ +package org.chorem.pollen.rest.api.v1; + +import org.chorem.pollen.persistence.entity.ChoiceImpl; +import org.chorem.pollen.persistence.entity.VoteToChoice; +import org.chorem.pollen.persistence.entity.VoteToChoiceImpl; + +/** + * Created on 5/15/14. + * + * @author Tony Chemit <chemit(a)codelutin.com> + * @since 2.0 + */ +public class VoteToChoiceBean { + + protected String choiceId; + + protected Double voteValue; + + public String getChoiceId() { + return choiceId; + } + + public void setChoiceId(String choiceId) { + this.choiceId = choiceId; + } + + public Double getVoteValue() { + return voteValue; + } + + public void setVoteValue(Double voteValue) { + this.voteValue = voteValue; + } + + public VoteToChoice toEntity() { + + VoteToChoice voteToChoice = new VoteToChoiceImpl(); + voteToChoice.setVoteValue(getVoteValue()); + voteToChoice.setChoice(new ChoiceImpl()); + voteToChoice.getChoice().setTopiaId(getChoiceId()); + + return voteToChoice; + + } +} Property changes on: trunk/pollen-rest-api/src/main/java/org/chorem/pollen/rest/api/v1/VoteToChoiceBean.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision Added: svn:eol-style + native Modified: trunk/pollen-rest-api/src/main/resources/mapping =================================================================== --- trunk/pollen-rest-api/src/main/resources/mapping 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/main/resources/mapping 2014-05-15 10:32:05 UTC (rev 3944) @@ -119,6 +119,8 @@ # VoteApi GET /v1/polls/{pollId}/votes VoteApi.getVotes +GET /v1/polls/{pollId}/votes/add VoteApi.addVote +GET /v1/polls/{pollId}/votes/{voteId}/edit VoteApi.editVote POST /v1/polls/{pollId}/votes VoteApi.addVote GET /v1/polls/{pollId}/votes/{voteId} VoteApi.getVote PUT /v1/polls/{pollId}/votes/{voteId} VoteApi.editVote Deleted: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverterTest.java =================================================================== --- trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverterTest.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverterTest.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -1,54 +0,0 @@ -package org.chorem.pollen.rest.api; - -/* - * #%L - * Pollen :: Rest Api - * %% - * Copyright (C) 2009 - 2014 CodeLutin - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * #L% - */ - -import org.chorem.pollen.persistence.entity.Choice; -import org.chorem.pollen.persistence.entity.ChoiceType; -import org.junit.Assert; -import org.junit.Test; - -public class TopiaEntityArrayConverterTest { - - @Test - public void convertToType() throws Exception { - - String choicesStr = "[ {name: \"choice1\", choiceType: \"TEXT\", choiceOrder: 1}, " + - "{name: \"choice2\", choiceType: \"IMAGE\", choiceOrder: 2} ]"; - - TopiaEntityArrayConverter converter = TopiaEntityArrayConverter.newconverter(Choice.class); - - Choice[] choices = converter.convert(Choice[].class, choicesStr); - Assert.assertNotNull(choices); - Assert.assertEquals(2, choices.length); - - Assert.assertNotNull(choices[0]); - Assert.assertEquals("choice1", choices[0].getName()); - Assert.assertEquals(ChoiceType.TEXT, choices[0].getChoiceType()); - Assert.assertEquals(1, choices[0].getChoiceOrder()); - - Assert.assertNotNull(choices[1]); - Assert.assertEquals("choice2", choices[1].getName()); - Assert.assertEquals(ChoiceType.IMAGE, choices[1].getChoiceType()); - Assert.assertEquals(2, choices[1].getChoiceOrder()); - - } -} \ No newline at end of file Deleted: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityConverterTest.java =================================================================== --- trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityConverterTest.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityConverterTest.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -1,61 +0,0 @@ -package org.chorem.pollen.rest.api; - -/* - * #%L - * Pollen :: Rest Api - * %% - * Copyright (C) 2009 - 2014 CodeLutin - * %% - * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Affero General Public License as published by - * the Free Software Foundation, either version 3 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU Affero General Public License - * along with this program. If not, see <http://www.gnu.org/licenses/>. - * #L% - */ - -import org.chorem.pollen.persistence.entity.CommentVisibility; -import org.chorem.pollen.persistence.entity.Poll; -import org.chorem.pollen.persistence.entity.PollType; -import org.chorem.pollen.persistence.entity.VoteVisibility; -import org.junit.Assert; -import org.junit.Test; - -public class TopiaEntityConverterTest { - - @Test - public void convert() { - - String pollStr = "{topiaCreateDate: 1399033089600, title: \"pollTitle\", " + - "choice: [ {name: \"choice1\", choiceType: \"TEXT\"}, " + - "{name: \"choice2\", choiceType: \"IMAGE\"} ], voteVisibility: \"ANONYMOUS\", " + - "commentVisibility:\"NOBODY\", pollType: \"FREE\" }"; - - TopiaEntityConverter<Poll> converter = new TopiaEntityConverter<>(Poll.class); - - Poll poll = converter.convert(Poll.class, pollStr); - - Assert.assertNotNull(poll); - Assert.assertEquals("pollTitle", poll.getTitle()); - Assert.assertEquals(VoteVisibility.ANONYMOUS, poll.getVoteVisibility()); - Assert.assertEquals(CommentVisibility.NOBODY, poll.getCommentVisibility()); - Assert.assertEquals(PollType.FREE, poll.getPollType()); -// Assert.assertEquals(2, poll.sizeChoice()); -// Assert.assertEquals("choice1", poll.getChoice(0).getName()); -// Assert.assertEquals(ChoiceType.TEXT, poll.getChoice(0).getChoiceType()); -// Assert.assertEquals("choice2", poll.getChoice(1).getName()); -// Assert.assertEquals(ChoiceType.IMAGE, poll.getChoice(1).getChoiceType()); - - String convert = converter.convert(String.class, poll); - Assert.assertNotNull(convert); - - } - -} \ No newline at end of file Added: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/JsonConverterTest.java =================================================================== --- trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/JsonConverterTest.java (rev 0) +++ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/JsonConverterTest.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,90 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import org.chorem.pollen.persistence.entity.CommentVisibility; +import org.chorem.pollen.persistence.entity.Poll; +import org.chorem.pollen.persistence.entity.PollType; +import org.chorem.pollen.persistence.entity.VoteVisibility; +import org.chorem.pollen.rest.api.v1.VoteBean; +import org.chorem.pollen.rest.api.v1.VoteToChoiceBean; +import org.junit.Assert; +import org.junit.Test; + +public class JsonConverterTest { + + @Test + public void convertBean() { + + String pollStr = "{voter:{name:\"toto\"},anonymous:true,choice:[{voteValue:1.5,choiceId:\"AA\"}]}"; + + JsonConverter<VoteBean> converter = JsonConverter.newConverter(VoteBean.class); + + VoteBean voteBean = converter.convert(VoteBean.class, pollStr); + + Assert.assertNotNull(voteBean); + Assert.assertEquals(true, voteBean.getAnonymous()); + + Assert.assertNotNull(voteBean.getVoter()); + Assert.assertEquals("toto", voteBean.getVoter().getName()); + + Assert.assertNotNull(voteBean.getChoice()); + Assert.assertEquals(1, voteBean.getChoice().size()); + VoteToChoiceBean voteToChoiceBean = voteBean.getChoice().iterator().next(); + Assert.assertNotNull(voteToChoiceBean); + Assert.assertEquals(1.5, voteToChoiceBean.getVoteValue(), 0); + Assert.assertEquals("AA", voteToChoiceBean.getChoiceId()); + + String convert = converter.convert(String.class, voteBean); + Assert.assertNotNull(convert); + + } + + @Test + public void convertEntity() { + + String pollStr = "{topiaCreateDate: 1399033089600, title: \"pollTitle\", " + + "choice: [ {name: \"choice1\", choiceType: \"TEXT\"}, " + + "{name: \"choice2\", choiceType: \"IMAGE\"} ], voteVisibility: \"ANONYMOUS\", " + + "commentVisibility:\"NOBODY\", pollType: \"FREE\" }"; + + TopiaEntityConverter<Poll> converter = new TopiaEntityConverter<>(Poll.class); + + Poll poll = converter.convert(Poll.class, pollStr); + + Assert.assertNotNull(poll); + Assert.assertEquals("pollTitle", poll.getTitle()); + Assert.assertEquals(VoteVisibility.ANONYMOUS, poll.getVoteVisibility()); + Assert.assertEquals(CommentVisibility.NOBODY, poll.getCommentVisibility()); + Assert.assertEquals(PollType.FREE, poll.getPollType()); +// Assert.assertEquals(2, poll.sizeChoice()); +// Assert.assertEquals("choice1", poll.getChoice(0).getName()); +// Assert.assertEquals(ChoiceType.TEXT, poll.getChoice(0).getChoiceType()); +// Assert.assertEquals("choice2", poll.getChoice(1).getName()); +// Assert.assertEquals(ChoiceType.IMAGE, poll.getChoice(1).getChoiceType()); + + String convert = converter.convert(String.class, poll); + Assert.assertNotNull(convert); + + } + +} \ No newline at end of file Property changes on: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/JsonConverterTest.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision Added: svn:eol-style + native Copied: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverterTest.java (from rev 3938, trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityArrayConverterTest.java) =================================================================== --- trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverterTest.java (rev 0) +++ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityArrayConverterTest.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,54 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import org.chorem.pollen.persistence.entity.Choice; +import org.chorem.pollen.persistence.entity.ChoiceType; +import org.junit.Assert; +import org.junit.Test; + +public class TopiaEntityArrayConverterTest { + + @Test + public void convertToType() throws Exception { + + String choicesStr = "[ {name: \"choice1\", choiceType: \"TEXT\", choiceOrder: 1}, " + + "{name: \"choice2\", choiceType: \"IMAGE\", choiceOrder: 2} ]"; + + TopiaEntityArrayConverter converter = TopiaEntityArrayConverter.newconverter(Choice.class); + + Choice[] choices = converter.convert(Choice[].class, choicesStr); + Assert.assertNotNull(choices); + Assert.assertEquals(2, choices.length); + + Assert.assertNotNull(choices[0]); + Assert.assertEquals("choice1", choices[0].getName()); + Assert.assertEquals(ChoiceType.TEXT, choices[0].getChoiceType()); + Assert.assertEquals(1, choices[0].getChoiceOrder()); + + Assert.assertNotNull(choices[1]); + Assert.assertEquals("choice2", choices[1].getName()); + Assert.assertEquals(ChoiceType.IMAGE, choices[1].getChoiceType()); + Assert.assertEquals(2, choices[1].getChoiceOrder()); + + } +} \ No newline at end of file Copied: trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverterTest.java (from rev 3938, trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/TopiaEntityConverterTest.java) =================================================================== --- trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverterTest.java (rev 0) +++ trunk/pollen-rest-api/src/test/java/org/chorem/pollen/rest/api/converter/TopiaEntityConverterTest.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -0,0 +1,61 @@ +package org.chorem.pollen.rest.api.converter; + +/* + * #%L + * Pollen :: Rest Api + * %% + * Copyright (C) 2009 - 2014 CodeLutin + * %% + * This program is free software: you can redistribute it and/or modify + * it under the terms of the GNU Affero General Public License as published by + * the Free Software Foundation, either version 3 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU Affero General Public License + * along with this program. If not, see <http://www.gnu.org/licenses/>. + * #L% + */ + +import org.chorem.pollen.persistence.entity.CommentVisibility; +import org.chorem.pollen.persistence.entity.Poll; +import org.chorem.pollen.persistence.entity.PollType; +import org.chorem.pollen.persistence.entity.VoteVisibility; +import org.junit.Assert; +import org.junit.Test; + +public class TopiaEntityConverterTest { + + @Test + public void convert() { + + String pollStr = "{topiaCreateDate: 1399033089600, title: \"pollTitle\", " + + "choice: [ {name: \"choice1\", choiceType: \"TEXT\"}, " + + "{name: \"choice2\", choiceType: \"IMAGE\"} ], voteVisibility: \"ANONYMOUS\", " + + "commentVisibility:\"NOBODY\", pollType: \"FREE\" }"; + + TopiaEntityConverter<Poll> converter = new TopiaEntityConverter<>(Poll.class); + + Poll poll = converter.convert(Poll.class, pollStr); + + Assert.assertNotNull(poll); + Assert.assertEquals("pollTitle", poll.getTitle()); + Assert.assertEquals(VoteVisibility.ANONYMOUS, poll.getVoteVisibility()); + Assert.assertEquals(CommentVisibility.NOBODY, poll.getCommentVisibility()); + Assert.assertEquals(PollType.FREE, poll.getPollType()); +// Assert.assertEquals(2, poll.sizeChoice()); +// Assert.assertEquals("choice1", poll.getChoice(0).getName()); +// Assert.assertEquals(ChoiceType.TEXT, poll.getChoice(0).getChoiceType()); +// Assert.assertEquals("choice2", poll.getChoice(1).getName()); +// Assert.assertEquals(ChoiceType.IMAGE, poll.getChoice(1).getChoiceType()); + + String convert = converter.convert(String.class, poll); + Assert.assertNotNull(convert); + + } + +} \ No newline at end of file Modified: trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java =================================================================== --- trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java 2014-05-15 10:23:42 UTC (rev 3943) +++ trunk/pollen-services/src/main/java/org/chorem/pollen/services/service/ChoiceService.java 2014-05-15 10:32:05 UTC (rev 3944) @@ -147,6 +147,7 @@ Poll poll = getPollService().getPoll0(pollId); Choice choice = getChoice(poll, choiceId); + //TODO Check if this is not the last choice, if so can not delete getChoiceDao().delete(choice); commit();

1 0