- Coser-commits - mailman.cloud.codelutin.com

r164 - in trunk/coser-business/src: main/java/fr/ifremer/coser/validators main/resources main/resources/fr/ifremer/coser/data test/java/fr/ifremer/coser/services
by chatellier＠users.labs.libre-entreprise.org 04 Nov '10

04 Nov '10

Author: chatellier Date: 2010-11-04 10:15:16 +0000 (Thu, 04 Nov 2010) New Revision: 164 Log: Fix test. Add custom validator to catch exception. Added: trunk/coser-business/src/main/java/fr/ifremer/coser/validators/CoserExpressionValidator.java Modified: trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Catch-error-validation.xml trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Haul-error-validation.xml trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Length-error-validation.xml trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Strata-error-validation.xml trunk/coser-business/src/main/resources/validators.xml trunk/coser-business/src/test/java/fr/ifremer/coser/services/ValidationServiceTest.java Added: trunk/coser-business/src/main/java/fr/ifremer/coser/validators/CoserExpressionValidator.java =================================================================== --- trunk/coser-business/src/main/java/fr/ifremer/coser/validators/CoserExpressionValidator.java (rev 0) +++ trunk/coser-business/src/main/java/fr/ifremer/coser/validators/CoserExpressionValidator.java 2010-11-04 10:15:16 UTC (rev 164) @@ -0,0 +1,79 @@ +package fr.ifremer.coser.validators; + +import com.opensymphony.xwork2.util.ValueStack; +import com.opensymphony.xwork2.validator.ValidationException; +import com.opensymphony.xwork2.validator.validators.ExpressionValidator; + +/** + * Modification de {@link ExpressionValidator} pour avoir les exceptions. + * + * @author chatellier + * @version $Revision$ + * + * Last update : $Date$ + * By : $Author$ + */ +public class CoserExpressionValidator extends ExpressionValidator { + + private ValueStack localStack; + + public void setValueStack(ValueStack localStack) { + super.setValueStack(localStack); + this.localStack = localStack; + } + + public void validate(Object object) throws ValidationException { + Boolean answer = Boolean.FALSE; + Object obj = null; + + try { + obj = getFieldValue(getExpression(), object, true); + } catch (ValidationException e) { + throw e; + } catch (Exception e) { + + // arrive si des valeurs NA sont comparée par exemple + // le test lance une exception, mais on le considere + // valide pour la suite + obj = Boolean.TRUE; + } + + if ((obj != null) && (obj instanceof Boolean)) { + answer = (Boolean) obj; + } else { + log.warn("Got result of " + obj + " when trying to get Boolean."); + } + + if (!answer.booleanValue()) { + if (log.isDebugEnabled()) log.debug("Validation failed on expression " + getExpression() + " with validated object "+ object); + addActionError(object); + } + } + + /** + * Return the field value named <code>name</code> from <code>object</code>, + * <code>object</code> should have the appropriate getter/setter. + * + * @param name + * @param object + * @return Object as field value + * @throws ValidationException + */ + protected Object getFieldValue(String name, Object object, boolean throwExceptionOnFailure) throws ValidationException { + + boolean pop = false; + + if (!localStack.getRoot().contains(object)) { + localStack.push(object); + pop = true; + } + + Object retVal = localStack.findValue(name, throwExceptionOnFailure); + + if (pop) { + localStack.pop(); + } + + return retVal; + } +} Property changes on: trunk/coser-business/src/main/java/fr/ifremer/coser/validators/CoserExpressionValidator.java ___________________________________________________________________ Added: svn:keywords + Author Date Id Revision HeadURL Modified: trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Catch-error-validation.xml =================================================================== --- trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Catch-error-validation.xml 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Catch-error-validation.xml 2010-11-04 10:15:16 UTC (rev 164) @@ -5,7 +5,7 @@ $Id$ $HeadURL$ %% - Copyright (C) 2010 Ifremer, Codelutin + Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric %% This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as @@ -51,18 +51,18 @@ </field-validator> </field> <field name="numberAsString"> - <field-validator type="checkDouble" short-circuit="true"> + <field-validator type="checkDouble"> <param name="notAvailable">NA</param> <message>Number attribute is not a valid double</message> </field-validator> </field> <field name="weightAsString"> - <field-validator type="checkDouble" short-circuit="true"> + <field-validator type="checkDouble"> <param name="notAvailable">NA</param> <message>Weight attribute is not a valid double</message> </field-validator> </field> - <validator type="expression"> + <validator type="coserExpression"> <param name="expression"><![CDATA[ (weight > 0 && number > 0) || weight == 0]]></param> <message><![CDATA[coser.business.control.error.noCatchNumberWithWeight]]></message> </validator> Modified: trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Haul-error-validation.xml =================================================================== --- trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Haul-error-validation.xml 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Haul-error-validation.xml 2010-11-04 10:15:16 UTC (rev 164) @@ -5,7 +5,7 @@ $Id$ $HeadURL$ %% - Copyright (C) 2010 Ifremer, Codelutin + Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric %% This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as Modified: trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Length-error-validation.xml =================================================================== --- trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Length-error-validation.xml 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Length-error-validation.xml 2010-11-04 10:15:16 UTC (rev 164) @@ -5,7 +5,7 @@ $Id$ $HeadURL$ %% - Copyright (C) 2010 Ifremer, Codelutin + Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric %% This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as @@ -51,34 +51,34 @@ </field-validator> </field> <field name="sex"> - <field-validator type="requiredstring" short-circuit="true"> + <field-validator type="requiredstring"> <message>Sex is mandatory</message> </field-validator> </field> <field name="maturity"> - <field-validator type="requiredstring" short-circuit="true"> + <field-validator type="requiredstring"> <message>Maturity attribute is required</message> </field-validator> </field> <field name="length"> - <field-validator type="checkDouble" short-circuit="true"> + <field-validator type="checkDouble"> <message>length attribute is not a valid double</message> </field-validator> </field> <field name="number"> - <field-validator type="checkDouble" short-circuit="true"> + <field-validator type="checkDouble"> <param name="notAvailable">NA</param> <message>number attribute is not a valid double</message> </field-validator> </field> <field name="weight"> - <field-validator type="checkDouble" short-circuit="true"> + <field-validator type="checkDouble"> <param name="notAvailable">NA</param> <message>Weight attribute is not a valid double</message> </field-validator> </field> <field name="age"> - <field-validator type="requiredstring" short-circuit="true"> + <field-validator type="requiredstring"> <message>Age attribute is required</message> </field-validator> </field> Modified: trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Strata-error-validation.xml =================================================================== --- trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Strata-error-validation.xml 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/main/resources/fr/ifremer/coser/data/Strata-error-validation.xml 2010-11-04 10:15:16 UTC (rev 164) @@ -5,7 +5,7 @@ $Id$ $HeadURL$ %% - Copyright (C) 2010 Ifremer, Codelutin + Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric %% This program is free software: you can redistribute it and/or modify it under the terms of the GNU Lesser General Public License as Modified: trunk/coser-business/src/main/resources/validators.xml =================================================================== --- trunk/coser-business/src/main/resources/validators.xml 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/main/resources/validators.xml 2010-11-04 10:15:16 UTC (rev 164) @@ -47,5 +47,6 @@ <validator name="checkDouble" class="fr.ifremer.coser.validators.CoserCheckDoubleValidator"/> <validator name="coserDouble" class="fr.ifremer.coser.validators.CoserDoubleValidator"/> + <validator name="coserExpression" class="fr.ifremer.coser.validators.CoserExpressionValidator"/> </validators> Modified: trunk/coser-business/src/test/java/fr/ifremer/coser/services/ValidationServiceTest.java =================================================================== --- trunk/coser-business/src/test/java/fr/ifremer/coser/services/ValidationServiceTest.java 2010-11-04 10:09:36 UTC (rev 163) +++ trunk/coser-business/src/test/java/fr/ifremer/coser/services/ValidationServiceTest.java 2010-11-04 10:15:16 UTC (rev 164) @@ -66,12 +66,12 @@ myCatch.setData(new String[]{"1", "","","","","",""}); List<ValidationError> errors = validationService.validate(myCatch); Assert.assertNotNull(errors); - Assert.assertEquals(4, errors.size()); + Assert.assertEquals(3, errors.size()); myCatch.setData(new String[]{"1", "Toto","","","","999",""}); errors = validationService.validate(myCatch); Assert.assertNotNull(errors); - Assert.assertEquals(3, errors.size()); + Assert.assertEquals(2, errors.size()); } /**

1 0

r163 - trunk/coser-business/src/test/java/fr/ifremer/coser/services
by chatellier＠users.labs.libre-entreprise.org 04 Nov '10

04 Nov '10

Author: chatellier Date: 2010-11-04 10:09:36 +0000 (Thu, 04 Nov 2010) New Revision: 163 Log: Correction du test (les lignes sont maintenant numerot?\195?\169e ?\195?\160 partir de 1) Modified: trunk/coser-business/src/test/java/fr/ifremer/coser/services/CommandServiceTest.java Modified: trunk/coser-business/src/test/java/fr/ifremer/coser/services/CommandServiceTest.java =================================================================== --- trunk/coser-business/src/test/java/fr/ifremer/coser/services/CommandServiceTest.java 2010-11-04 09:56:07 UTC (rev 162) +++ trunk/coser-business/src/test/java/fr/ifremer/coser/services/CommandServiceTest.java 2010-11-04 10:09:36 UTC (rev 163) @@ -98,16 +98,16 @@ @Test public void testDeleteLineUndo() throws CoserBusinessException { Project project = createTestProject(projectService); - Assert.assertEquals("3", project.getControl().getLength().get(4)[Length.INDEX_LINE]); + Assert.assertEquals("4", project.getControl().getLength().get(4)[Length.INDEX_LINE]); DeleteLineCommand command = new DeleteLineCommand(); - command.setLineNumber("3"); + command.setLineNumber("4"); command.setCategory(Category.LENGTH); commandService.doAction(command, project, project.getControl()); + Assert.assertEquals("5", project.getControl().getLength().get(4)[Length.INDEX_LINE]); + commandService.undoAction(project, project.getControl()); Assert.assertEquals("4", project.getControl().getLength().get(4)[Length.INDEX_LINE]); - commandService.undoAction(project, project.getControl()); - Assert.assertEquals("3", project.getControl().getLength().get(4)[Length.INDEX_LINE]); } /**

1 0

r162 - in trunk/coser-ui/src/main/java/fr/ifremer/coser/ui: . project
by chatellier＠users.labs.libre-entreprise.org 04 Nov '10

04 Nov '10

Author: chatellier Date: 2010-11-04 09:56:07 +0000 (Thu, 04 Nov 2010) New Revision: 162 Log: Move project ui to project package Added: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectCreationView.jaxx trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectOpenView.jaxx Removed: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectOpenView.jaxx Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectNamesListModel.java Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java 2010-11-04 09:47:44 UTC (rev 161) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java 2010-11-04 09:56:07 UTC (rev 162) @@ -62,12 +62,14 @@ import fr.ifremer.coser.services.ProjectService; import fr.ifremer.coser.ui.control.ControlHandler; import fr.ifremer.coser.ui.control.ControlView; +import fr.ifremer.coser.ui.project.ProjectCreationView; +import fr.ifremer.coser.ui.project.ProjectOpenView; import fr.ifremer.coser.ui.selection.SelectionHandler; import fr.ifremer.coser.ui.selection.SelectionView; import fr.ifremer.coser.ui.widgets.LookAndFeelViewMenuItem; /** - * Coser hendler for main frame. + * Coser handler for main frame. * * @author chatellier * @version $Revision$ Deleted: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx 2010-11-04 09:47:44 UTC (rev 161) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx 2010-11-04 09:56:07 UTC (rev 162) @@ -1,153 +0,0 @@ - -<Table> - <CoserFrameHandler id="handler" javaBean="null" /> - -  - <fr.ifremer.coser.bean.Project id="project" /> - <jaxx.runtime.validator.swing.SwingValidatorMessageTableModel id='errorsTableModel' - onTableChanged='createProjectButton.setEnabled(errorsTableModel.getRowCount()==0)'/> - <BeanValidator id='validatorProject' bean='project' - uiClass="jaxx.runtime.validator.swing.ui.ImageValidationUI" - errorTableModel="errorsTableModel"> - <field name="name" component="projectProjectName" /> - </BeanValidator> - - <script><![CDATA[ - JCheckBox customReferenceCheckBox = new JCheckBox(_("coser.ui.project.useCustomReferenceSpeciesFile")); - void $afterCompleteSetup() { - fr.ifremer.coser.ui.widgets.ComponentTitledBorder componentBorder = - new fr.ifremer.coser.ui.widgets.ComponentTitledBorder(customReferenceCheckBox, useCustomReferenceFilePanel, BorderFactory.createEtchedBorder()); - useCustomReferenceFilePanel.setBorder(componentBorder); - } - public JCheckBox getCustomReferenceCheckBox() { - return customReferenceCheckBox; - } - ]]></script> - - <row> - <cell weightx="1" fill="horizontal"> - <Table border='{BorderFactory.createTitledBorder(_("coser.ui.project.newProject"))}'> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.projectname" /> - </cell> - <cell anchor="west"> - <JTextField id="projectProjectName" text="{project.getName()}" /> - <javax.swing.text.Document javaBean="projectProjectName.getDocument()" - onInsertUpdate='getProject().setName(projectProjectName.getText())' - onRemoveUpdate='getProject().setName(projectProjectName.getText())' /> - - </cell> - </row> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.captureFile" /> - </cell> - <cell weightx="1" fill="horizontal"> - <JTextField id="projectCapturesFileField" /> - </cell> - <cell> - <JButton id="projectCapturesSelectButton" text="coser.ui.common.selectFile" - onActionPerformed="getHandler().selectInputFile(this, projectCapturesFileField)" /> - </cell> - </row> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.stratesFile" /> - </cell> - <cell fill="horizontal"> - <JTextField id="projectStratesFileField" /> - </cell> - <cell> - <JButton id="projectStratesFileSelectButton" text="coser.ui.common.selectFile" - onActionPerformed="getHandler().selectInputFile(this, projectStratesFileField)" /> - </cell> - </row> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.lengthFile" /> - </cell> - <cell fill="horizontal"> - <JTextField id="projectLengthFileField" /> - </cell> - <cell> - <JButton id="projectSizeFileSelectButton" text="coser.ui.common.selectFile" - onActionPerformed="getHandler().selectInputFile(this, projectLengthFileField)" /> - </cell> - </row> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.traitsFile" /> - </cell> - <cell fill="horizontal"> - <JTextField id="projectTraitsFileField" /> - </cell> - <cell> - <JButton id="projectTraitsFileSelectButton" text="coser.ui.common.selectFile" - onActionPerformed="getHandler().selectInputFile(this, projectTraitsFileField)" /> - </cell> - </row> - <row> - <cell> - <JLabel id="referenceSpeciesDescriptionLabel" text="coser.ui.project.usedReferenceSpeciesFile" - enabled="{!customReferenceCheckBox.isSelected()}" /> - </cell> - <cell anchor="west"> - <JLabel id="referenceSpeciesFileLabel" text="{getContextValue(fr.ifremer.coser.CoserConfig.class).getReferenceSpeciesPath()}" - enabled="{!customReferenceCheckBox.isSelected()}" /> - </cell> - </row> - <row> - <cell columns="3" fill="horizontal"> - <Table id="useCustomReferenceFilePanel"> - <row> - <cell> - <JLabel id="customReferenceSpeciesFileLabel" text="coser.ui.project.customReferenceSpeciesFile" - enabled="{customReferenceCheckBox.isSelected()}"/> - </cell> - <cell weightx="1" fill="horizontal"> - <JTextField id="customReferenceSpeciesFileTextField" - enabled="{customReferenceCheckBox.isSelected()}"/> - </cell> - <cell> - <JButton text="coser.ui.common.selectFile" - onActionPerformed="getHandler().selectInputFile(this, customReferenceSpeciesFileTextField)" - enabled="{customReferenceCheckBox.isSelected()}"/> - </cell> - </row> - </Table> - </cell> - </row> - <row> - <cell columns="3" anchor="east"> - <JButton id="createProjectButton" text="coser.ui.project.createProject" - onActionPerformed="getHandler().createProject(this)" /> - </cell> - </row> - </Table> - </cell> - </row> -</Table> Deleted: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectOpenView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectOpenView.jaxx 2010-11-04 09:47:44 UTC (rev 161) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectOpenView.jaxx 2010-11-04 09:56:07 UTC (rev 162) @@ -1,54 +0,0 @@ - -<Table> - <CoserFrameHandler id="handler" javaBean="null" /> - - <row> - <cell weightx="1" fill="horizontal"> - <Table border='{BorderFactory.createTitledBorder(_("coser.ui.project.openProjectTitle"))}'> - <row> - <cell anchor="west"> - <JLabel text="coser.ui.project.project" /> - </cell> - <cell anchor="west" weightx="1"> - <JComboBox id="projectsComboBox" model="{new fr.ifremer.coser.ui.project.ProjectNamesListModel(this)}" /> - </cell> - </row> - <row> - <cell weightx="1" anchor="east" columns="2"> - <JButton text="coser.ui.project.openProject" - enabled="{projectsComboBox.getSelectedItem() != null}" - onActionPerformed="getHandler().loadProject(this)" /> - </cell> - </row> - <row> - <cell weightx="1" fill="horizontal" columns="2"> - <JProgressBar id="loadingProgressBar" indeterminate="true" visible="false" /> - </cell> - </row> - </Table> - </cell> - </row> -</Table> Copied: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectCreationView.jaxx (from rev 155, trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx) =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectCreationView.jaxx (rev 0) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectCreationView.jaxx 2010-11-04 09:56:07 UTC (rev 162) @@ -0,0 +1,153 @@ + +<Table> + <fr.ifremer.coser.ui.CoserFrameHandler id="handler" javaBean="null" /> + +  + <fr.ifremer.coser.bean.Project id="project" /> + <jaxx.runtime.validator.swing.SwingValidatorMessageTableModel id='errorsTableModel' + onTableChanged='createProjectButton.setEnabled(errorsTableModel.getRowCount()==0)'/> + <BeanValidator id='validatorProject' bean='project' + uiClass="jaxx.runtime.validator.swing.ui.ImageValidationUI" + errorTableModel="errorsTableModel"> + <field name="name" component="projectProjectName" /> + </BeanValidator> + + <script><![CDATA[ + JCheckBox customReferenceCheckBox = new JCheckBox(_("coser.ui.project.useCustomReferenceSpeciesFile")); + void $afterCompleteSetup() { + fr.ifremer.coser.ui.widgets.ComponentTitledBorder componentBorder = + new fr.ifremer.coser.ui.widgets.ComponentTitledBorder(customReferenceCheckBox, useCustomReferenceFilePanel, BorderFactory.createEtchedBorder()); + useCustomReferenceFilePanel.setBorder(componentBorder); + } + public JCheckBox getCustomReferenceCheckBox() { + return customReferenceCheckBox; + } + ]]></script> + + <row> + <cell weightx="1" fill="horizontal"> + <Table border='{BorderFactory.createTitledBorder(_("coser.ui.project.newProject"))}'> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.projectname" /> + </cell> + <cell anchor="west"> + <JTextField id="projectProjectName" text="{project.getName()}" /> + <javax.swing.text.Document javaBean="projectProjectName.getDocument()" + onInsertUpdate='getProject().setName(projectProjectName.getText())' + onRemoveUpdate='getProject().setName(projectProjectName.getText())' /> + + </cell> + </row> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.captureFile" /> + </cell> + <cell weightx="1" fill="horizontal"> + <JTextField id="projectCapturesFileField" /> + </cell> + <cell> + <JButton id="projectCapturesSelectButton" text="coser.ui.common.selectFile" + onActionPerformed="getHandler().selectInputFile(this, projectCapturesFileField)" /> + </cell> + </row> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.stratesFile" /> + </cell> + <cell fill="horizontal"> + <JTextField id="projectStratesFileField" /> + </cell> + <cell> + <JButton id="projectStratesFileSelectButton" text="coser.ui.common.selectFile" + onActionPerformed="getHandler().selectInputFile(this, projectStratesFileField)" /> + </cell> + </row> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.lengthFile" /> + </cell> + <cell fill="horizontal"> + <JTextField id="projectLengthFileField" /> + </cell> + <cell> + <JButton id="projectSizeFileSelectButton" text="coser.ui.common.selectFile" + onActionPerformed="getHandler().selectInputFile(this, projectLengthFileField)" /> + </cell> + </row> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.traitsFile" /> + </cell> + <cell fill="horizontal"> + <JTextField id="projectTraitsFileField" /> + </cell> + <cell> + <JButton id="projectTraitsFileSelectButton" text="coser.ui.common.selectFile" + onActionPerformed="getHandler().selectInputFile(this, projectTraitsFileField)" /> + </cell> + </row> + <row> + <cell> + <JLabel id="referenceSpeciesDescriptionLabel" text="coser.ui.project.usedReferenceSpeciesFile" + enabled="{!customReferenceCheckBox.isSelected()}" /> + </cell> + <cell anchor="west"> + <JLabel id="referenceSpeciesFileLabel" text="{getContextValue(fr.ifremer.coser.CoserConfig.class).getReferenceSpeciesPath()}" + enabled="{!customReferenceCheckBox.isSelected()}" /> + </cell> + </row> + <row> + <cell columns="3" fill="horizontal"> + <Table id="useCustomReferenceFilePanel"> + <row> + <cell> + <JLabel id="customReferenceSpeciesFileLabel" text="coser.ui.project.customReferenceSpeciesFile" + enabled="{customReferenceCheckBox.isSelected()}"/> + </cell> + <cell weightx="1" fill="horizontal"> + <JTextField id="customReferenceSpeciesFileTextField" + enabled="{customReferenceCheckBox.isSelected()}"/> + </cell> + <cell> + <JButton text="coser.ui.common.selectFile" + onActionPerformed="getHandler().selectInputFile(this, customReferenceSpeciesFileTextField)" + enabled="{customReferenceCheckBox.isSelected()}"/> + </cell> + </row> + </Table> + </cell> + </row> + <row> + <cell columns="3" anchor="east"> + <JButton id="createProjectButton" text="coser.ui.project.createProject" + onActionPerformed="getHandler().createProject(this)" /> + </cell> + </row> + </Table> + </cell> + </row> +</Table> Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectNamesListModel.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectNamesListModel.java 2010-11-04 09:47:44 UTC (rev 161) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectNamesListModel.java 2010-11-04 09:56:07 UTC (rev 162) @@ -31,7 +31,6 @@ import javax.swing.ComboBoxModel; import fr.ifremer.coser.services.ProjectService; -import fr.ifremer.coser.ui.ProjectOpenView; /** * Validation categories list model. Copied: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectOpenView.jaxx (from rev 84, trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectOpenView.jaxx) =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectOpenView.jaxx (rev 0) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/project/ProjectOpenView.jaxx 2010-11-04 09:56:07 UTC (rev 162) @@ -0,0 +1,54 @@ + +<Table> + <fr.ifremer.coser.ui.CoserFrameHandler id="handler" javaBean="null" /> + + <row> + <cell weightx="1" fill="horizontal"> + <Table border='{BorderFactory.createTitledBorder(_("coser.ui.project.openProjectTitle"))}'> + <row> + <cell anchor="west"> + <JLabel text="coser.ui.project.project" /> + </cell> + <cell anchor="west" weightx="1"> + <JComboBox id="projectsComboBox" model="{new fr.ifremer.coser.ui.project.ProjectNamesListModel(this)}" /> + </cell> + </row> + <row> + <cell weightx="1" anchor="east" columns="2"> + <JButton text="coser.ui.project.openProject" + enabled="{projectsComboBox.getSelectedItem() != null}" + onActionPerformed="getHandler().loadProject(this)" /> + </cell> + </row> + <row> + <cell weightx="1" fill="horizontal" columns="2"> + <JProgressBar id="loadingProgressBar" indeterminate="true" visible="false" /> + </cell> + </row> + </Table> + </cell> + </row> +</Table>

1 0

r161 - in trunk/coser-ui/src/main: java/fr/ifremer/coser/ui java/fr/ifremer/coser/ui/control resources/i18n
by chatellier＠users.labs.libre-entreprise.org 04 Nov '10

04 Nov '10

Author: chatellier Date: 2010-11-04 09:47:44 +0000 (Thu, 04 Nov 2010) New Revision: 161 Log: Ajout d'un check (avec messages d'avertissement) si l'on tente de creer une selection avec des erreurs et warning encore pr?\195?\169sents Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java 2010-11-03 16:11:15 UTC (rev 160) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/CoserFrameHandler.java 2010-11-04 09:47:44 UTC (rev 161) @@ -119,12 +119,21 @@ setMainComponent(projectOpenView); } - public void setMainComponent(Component component) { + /** + * Replace window main component. + * + * @param component new component + */ + protected void setMainComponent(Component component) { view.getMainViewContent().removeAll(); view.getMainViewContent().add(component, BorderLayout.CENTER); view.getMainViewContent().validate(); } + /** + * Exit application. + * + */ public void quit() { System.exit(0); } @@ -358,7 +367,7 @@ if (reloadData) { project = projectService.loadControlData(project); } - + ControlView controlView = new ControlView(view); controlView.setHandler(new ControlHandler()); setMainComponent(controlView); @@ -371,7 +380,12 @@ * Show selection view to create new selection. */ public void showSelectionView() { - + + // verifie que les données sont toutes validée d'abord + if (!checkControlSession()) { + return; + } + // create new selection ProjectService projectService = view.getContextValue(ProjectService.class); Project project = view.getContextValue(Project.class); @@ -394,7 +408,7 @@ ImageIcon icon = new ImageIcon(file.toURI().toURL()); selectionView.getSelectionDetailsTab().getZonesMap().setIcon(icon); - } catch(Exception e){ + } catch(Exception e) { e.printStackTrace(); }; setMainComponent(selectionView); @@ -406,6 +420,29 @@ } /** + * Cette methode vérifie que si une session de control est en cours on + * verifie que la liste des erreurs ne contient pas d'erreur ou + * de message warning non coché. + * + * @return {@code true} if user confirm selection creation even if there is some errors + */ + protected boolean checkControlSession() { + + boolean result = false; + + // basé sur un hack, car ici, on ne sais pas ce que contient + // le panel principal + // attention, c'est du big hack ;) + Component comp = view.getMainViewContent().getComponent(0); + if (comp instanceof ControlView) { + ControlView controlView = (ControlView)comp; + result = controlView.getHandler().checkValidationModelErrors(controlView); + } + + return result; + } + + /** * Show selection view to open selection. * * @param selectionName selection name to open @@ -439,8 +476,10 @@ } /** + * Called by {@link LookAndFeelViewMenuItem} when look and feel selection + * change. * - * @param event + * @param event change event */ public void saveLookAndFeelConfiguration(PropertyChangeEvent event) { if (event.getPropertyName().equals(LookAndFeelViewMenuItem.PROPERTY_LOOK_AND_FEEL)) { Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java 2010-11-03 16:11:15 UTC (rev 160) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java 2010-11-04 09:47:44 UTC (rev 161) @@ -338,9 +338,7 @@ errorFound = true; } } - if (!errorFound) { - view.getSaveButton().setEnabled(true); - } + view.getSaveButton().setEnabled(true); } catch (Exception ex) { throw new CoserException("Can't validate data", ex); } @@ -582,8 +580,12 @@ String headerValue = header[fieldIndex]; String fieldValue = line[fieldIndex]; - final String beanFieldName = Introspector.decapitalize(enHeaders[fieldIndex - 1]); + String beanFieldName = Introspector.decapitalize(enHeaders[fieldIndex - 1]); + // l'ui ne peut utiliser les getter/setter que sur les champs + // xxxAsString + final String stringBeanFieldName = beanFieldName + "AsString"; + JLabel label = new JLabel(headerValue + "\u2009:"); final JTextField fieldTextField = new JTextField(fieldValue); fieldTextField.getDocument().addDocumentListener(new DocumentListener() { @@ -604,10 +606,10 @@ protected void valueChanged(DocumentEvent event) { try { - PropertyUtils.setProperty(finalBean, beanFieldName, fieldTextField.getText()); + PropertyUtils.setProperty(finalBean, stringBeanFieldName, fieldTextField.getText()); } catch (Exception ex) { if (log.isErrorEnabled()) { - log.error("Can't set property value (" + beanFieldName + ")", ex); + log.error("Can't set property value (" + stringBeanFieldName + ")", ex); } } } @@ -620,7 +622,11 @@ GridBagConstraints.WEST, GridBagConstraints.HORIZONTAL, new Insets( 1, 1, 1, 1), 0, 0)); + // permet de dire a jaxx que les erreurs sur les + // champs d'origine, et les champs string pointent sur le + // même composant validator.setFieldRepresentation(beanFieldName, fieldTextField); + validator.setFieldRepresentation(stringBeanFieldName, fieldTextField); } validator.installUIs(); @@ -649,12 +655,16 @@ /** * Save project after control. * + * Can't save if : + * - validation contains error + * - validation contains non checked warning + * * @param view view */ public void saveControl(ControlView view) { Project project = view.getContextValue(Project.class); ProjectService service = view.getContextValue(ProjectService.class); - + try { long before = System.currentTimeMillis(); service.saveProjectControl(project); @@ -669,8 +679,67 @@ } /** - * Display data graph. + * Verifie que le modele ne contient pas d'erreur (error/fatal) et + * demande à l'utilisateur s'il confirme vouloir sauver lorsque des warning + * ont été trouvé. * + * La liste peut être vide, soit parce que le check global n'a pas été + * lancé, soit parce qu'il n'y a réelement pas d'erreur. + * + * @param controlView view + * @return {@code true} if should perform save + */ + public boolean checkValidationModelErrors(ControlView controlView) { + GlobalValidationModel model = controlView.getGlobalValidationModel(); + controlView.getControlDataTableSelectionModel().clearSelection(); + + int errorFound = 0; + int nonCheckedWarningFound = 0; + + int groupCount = model.getChildCount(model.getRoot()); + for (int indexGroup = 0 ; indexGroup < groupCount ; ++indexGroup) { + Object group = model.getChild(model.getRoot(), indexGroup); + + int childCount = model.getChildCount(group); + for (int indexChild = 0 ; indexChild < childCount ; ++indexChild) { + ValidationError validationError = (ValidationError)model.getChild(group, indexChild); + if (validationError.getLevel() == ValidationLevel.ERROR || + validationError.getLevel() == ValidationLevel.FATAL) { + errorFound++; + } + else if (validationError.getLevel() == ValidationLevel.WARNING) { + + // on verifie que le warning est coché ou pas + Boolean checked = (Boolean)model.getValueAt(validationError, 1); + if (!checked) { + nonCheckedWarningFound++; + } + } + } + } + + boolean perform = true; + if (errorFound > 0) { + int response = JOptionPane.showConfirmDialog(controlView, _("coser.ui.control.check.containsError"), + _("coser.ui.control.check.title"), JOptionPane.ERROR_MESSAGE, JOptionPane.YES_NO_OPTION); + if (response == JOptionPane.NO_OPTION) { + perform = false; + } + } + else if (nonCheckedWarningFound > 0) { + int response = JOptionPane.showConfirmDialog(controlView, _("coser.ui.control.check.containsUncheckedWarning", nonCheckedWarningFound), + _("coser.ui.control.check.title"), JOptionPane.WARNING_MESSAGE, JOptionPane.YES_NO_OPTION); + if (response == JOptionPane.NO_OPTION) { + perform = false; + } + } + return perform; + } + + /** + * Display data graph, initialized with graph for first specy + * selected in specyComboModel. + * * @param view view */ public void displayGraph(ControlView view) { Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx 2010-11-03 16:11:15 UTC (rev 160) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx 2010-11-04 09:47:44 UTC (rev 161) @@ -95,8 +95,7 @@ </JScrollPane> </cell> <cell fill="both" weightx="1" weighty="1"> - <jaxx.runtime.validator.swing.SwingValidatorMessageTableModel id='errorsTableModel' - onTableChanged='saveButton.setEnabled(errorsTableModel.getRowCount()==0)'/> + <jaxx.runtime.validator.swing.SwingValidatorMessageTableModel id='errorsTableModel' /> <fr.ifremer.coser.data.Catch id="beanCatch" javaBean="null" /> <fr.ifremer.coser.data.Haul id="beanHaul" javaBean="null" /> <fr.ifremer.coser.data.Strata id="beanStrata" javaBean="null" /> Modified: trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties =================================================================== --- trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties 2010-11-03 16:11:15 UTC (rev 160) +++ trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties 2010-11-04 09:47:44 UTC (rev 161) @@ -14,6 +14,9 @@ coser.ui.common.unselectAll=None coser.ui.common.valid=Valid coser.ui.config.title=Configuration +coser.ui.control.check.containsError= +coser.ui.control.check.containsUncheckedWarning= +coser.ui.control.check.title= coser.ui.control.confirmDeletionMessage=Are you sure you want to delete this data ? coser.ui.control.confirmDeletionTitle=Confirm delete coser.ui.control.confirmDeletionsMessage=Are you sure you want to delete %d selected lines ? Modified: trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties =================================================================== --- trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties 2010-11-03 16:11:15 UTC (rev 160) +++ trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties 2010-11-04 09:47:44 UTC (rev 161) @@ -14,13 +14,16 @@ coser.ui.common.unselectAll=Aucun coser.ui.common.valid=Valider coser.ui.config.title=Configuration +coser.ui.control.check.containsError=Les donn\u00E9es contiennent encore des erreurs non corrig\u00E9es\npouvant fausser la cr\u00E9ation de la s\u00E9lection.\nVoulez vous poursuivre la cr\u00E9ation de la s\u00E9lection ? +coser.ui.control.check.containsUncheckedWarning=Les donn\u00E9es contiennent encore %d avertissements non coch\uFFFDs pouvant fausser la cr\u00E9ation de la selection.\nVoulez vous poursuivre la cr\u00E9ation de la s\u00E9lection ? +coser.ui.control.check.title=V\u00E9rification des erreurs coser.ui.control.confirmDeletionMessage=\u00CAtes vous s\u00FBr de vouloir supprimer cette donn\u00E9e ? coser.ui.control.confirmDeletionTitle=Confirmation de suppression coser.ui.control.confirmDeletionsMessage=\u00CAtes vous s\u00FBr de vouloir supprimer les %d lignes s\u00E9lectionn\u00E9es ? coser.ui.control.dataMenuDeleteSelected=Supprimer les lignes s\u00E9lectionn\u00E9es coser.ui.control.dataMenuLabel=Menu des donn\u00E9es coser.ui.control.dataMenuReplace=Remplacer dans %s pour la s\u00E9lection -coser.ui.control.dataMenuReplaceAll=Replacer dans %s pour toutes les lignes +coser.ui.control.dataMenuReplaceAll=Remplacer dans %s pour toutes les lignes coser.ui.control.deleteLine=Supprimer la ligne coser.ui.control.global.done=\u2026 coser.ui.control.global.message=Message

1 0

r160 - trunk/coser-ui/src/main/resources/icons
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 16:11:15 +0000 (Wed, 03 Nov 2010) New Revision: 160 Log: Add save icon Added: trunk/coser-ui/src/main/resources/icons/bullet_disk.png Added: trunk/coser-ui/src/main/resources/icons/bullet_disk.png =================================================================== (Binary files differ) Property changes on: trunk/coser-ui/src/main/resources/icons/bullet_disk.png ___________________________________________________________________ Added: svn:mime-type + application/octet-stream

1 0

r159 - in trunk: coser-business/src/main/java/fr/ifremer/coser/control coser-business/src/main/java/fr/ifremer/coser/services coser-ui/src/main/java/fr/ifremer/coser/ui/control coser-ui/src/main/resources/i18n
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 16:11:03 +0000 (Wed, 03 Nov 2010) New Revision: 159 Log: Ajout des menus contextuel sur l'arbre des erreurs et sur la table des donn?\195?\169es Modified: trunk/coser-business/src/main/java/fr/ifremer/coser/control/ValidationError.java trunk/coser-business/src/main/java/fr/ifremer/coser/services/ProjectService.java trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/GlobalValidationGroup.java trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties Modified: trunk/coser-business/src/main/java/fr/ifremer/coser/control/ValidationError.java =================================================================== --- trunk/coser-business/src/main/java/fr/ifremer/coser/control/ValidationError.java 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-business/src/main/java/fr/ifremer/coser/control/ValidationError.java 2010-11-03 16:11:03 UTC (rev 159) @@ -27,7 +27,6 @@ import java.io.Serializable; -import fr.ifremer.coser.CoserConstants.Category; import fr.ifremer.coser.CoserConstants.ValidationLevel; /** Modified: trunk/coser-business/src/main/java/fr/ifremer/coser/services/ProjectService.java =================================================================== --- trunk/coser-business/src/main/java/fr/ifremer/coser/services/ProjectService.java 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-business/src/main/java/fr/ifremer/coser/services/ProjectService.java 2010-11-03 16:11:03 UTC (rev 159) @@ -605,8 +605,8 @@ * Set content into project depending on category type. * * @param project project + * @param container data container * @param category category - * @param content content to set * @param deletedContent if content means deleted objects for {@code category} */ protected DataStorage getProjectContent(Project project, AbstractDataContainer container, @@ -661,18 +661,35 @@ * @param control control * @param category category * @param index index to delete + * @param commandUUID command UUID * @throws CoserBusinessException */ - public void deleteData(Project project, Control control, Category category, String index) throws CoserBusinessException { + public void deleteData(Project project, Control control, Category category, String index, String commandUUID) throws CoserBusinessException { // create new delete action DeleteLineCommand command = new DeleteLineCommand(); command.setCategory(category); command.setLineNumber(index); + command.setCommandUUID(commandUUID); commandService.doAction(command, project, control); } /** + * Supprime une données via son index. + * + * Used in control ui. + * + * @param project project + * @param control control + * @param category category + * @param index index to delete + * @throws CoserBusinessException + */ + public void deleteData(Project project, Control control, Category category, String index) throws CoserBusinessException { + deleteData(project, control, category, index, null); + } + + /** * Replace une valeur d'un champs si nécéssaire. * * If {@code currentValue} is not equals to current data value for fieldName, Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlHandler.java 2010-11-03 16:11:03 UTC (rev 159) @@ -49,12 +49,15 @@ import javax.swing.event.DocumentEvent; import javax.swing.event.DocumentListener; import javax.swing.event.ListSelectionEvent; +import javax.swing.event.TreeSelectionEvent; +import javax.swing.tree.TreePath; import jaxx.runtime.JAXXUtil; import jaxx.runtime.SwingUtil; import jaxx.runtime.validator.swing.SwingValidator; import org.apache.commons.beanutils.PropertyUtils; +import org.apache.commons.lang.ArrayUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.jfree.chart.ChartPanel; @@ -112,12 +115,15 @@ int[] dataSelectedRows = controlView.getControlDataTable().getSelectedRows(); final int columnIndex = controlView.getControlDataTable().getColumnModel().getColumnIndexAtX(event.getX()); + JPopupMenu popupMenu = new JPopupMenu(_("coser.ui.control.dataMenuLabel")); + // plusieurs lignes selectionnées et pas la premiere colonne (Line index) if (dataSelectedRows.length > 0 && columnIndex > 0) { ControlDataTableModel controlDataModel = controlView.getControlDataTableModel(); final String columnName = controlView.getControlDataTable().getColumnName(columnIndex); final String firstValue = (String)controlDataModel.getValueAt(dataSelectedRows[0], columnIndex); - JPopupMenu popupMenu = new JPopupMenu(_("coser.ui.control.dataMenuLabel")); + + // replace in selection JMenuItem replaceMenu = new JMenuItem(_("coser.ui.control.dataMenuReplace", columnName)); replaceMenu.addActionListener(new ActionListener() { @Override @@ -132,12 +138,84 @@ } }); popupMenu.add(replaceMenu); - popupMenu.show(controlView.getControlDataTable(), event.getX(), event.getY()); } + + // replace in everywhere + if (columnIndex > 0) { + final String columnName = controlView.getControlDataTable().getColumnName(columnIndex); + JMenuItem replaceAllMenu = new JMenuItem(_("coser.ui.control.dataMenuReplaceAll", columnName)); + replaceAllMenu.addActionListener(new ActionListener() { + @Override + public void actionPerformed(ActionEvent e) { + ControlFindReplaceDialog viewDialog = new ControlFindReplaceDialog(controlView); + viewDialog.setHandler(ControlHandler.this); + viewDialog.setColumnIndex(columnIndex); + viewDialog.getReplaceFieldNameLabel().setText(columnName); + viewDialog.setLocationRelativeTo(controlView); + viewDialog.setVisible(true); + } + }); + popupMenu.add(replaceAllMenu); + } + + // delete selected + if (dataSelectedRows.length > 0) { + + JMenuItem deleteSelectedMenu = new JMenuItem(_("coser.ui.control.dataMenuDeleteSelected")); + deleteSelectedMenu.addActionListener(new ActionListener() { + @Override + public void actionPerformed(ActionEvent e) { + deletedSelectedDataLines(controlView); + } + }); + popupMenu.add(deleteSelectedMenu); + } + + popupMenu.show(controlView.getControlDataTable(), event.getX(), event.getY()); } } /** + * Delete selected line in data table (called from context menu). + * + * @param controlView view + */ + protected void deletedSelectedDataLines(ControlView controlView) { + + JTable controlDataTable = controlView.getControlDataTable(); + int[] selectedLines = controlDataTable.getSelectedRows(); + if (ArrayUtils.isNotEmpty(selectedLines)) { + + int response = JOptionPane.showConfirmDialog(controlView, _("coser.ui.control.confirmDeletionsMessage", selectedLines.length), + _("coser.ui.control.confirmDeletionTitle"), + JOptionPane.YES_NO_OPTION, JOptionPane.QUESTION_MESSAGE); + + if (response == JOptionPane.YES_OPTION) { + Project project = controlView.getContextValue(Project.class); + ProjectService projectService = controlView.getContextValue(ProjectService.class); + Category category = (Category)controlView.getCategoryComboBox().getSelectedItem(); + + ControlDataTableModel model = (ControlDataTableModel)controlDataTable.getModel(); + String commandUUID = UUID.randomUUID().toString(); + + // il faut le faire à l'envers, sinon, les index de + // selection change en cours de route + for (int indexSelected = selectedLines.length - 1 ; indexSelected >= 0 ; --indexSelected) { + int selectedLine = selectedLines[indexSelected]; + String[] data = model.getDataAt(selectedLine); + try { + projectService.deleteData(project, project.getControl(), category, data[AbstractDataEntity.INDEX_LINE], commandUUID); + model.fireTableRowsDeleted(selectedLine, selectedLine); + } + catch (CoserBusinessException ex) { + throw new CoserException("Can't delete data", ex); + } + } + } + } + } + + /** * Perform find and replace. * * @param replaceView view @@ -336,22 +414,91 @@ * @param view view * @param event selection event */ - public void showSelectedError(ControlView view, ListSelectionEvent event) { - int selectedError = view.getValidationGlobalErrorsTable().getSelectedRow(); - if (selectedError != -1) { - /*ValidationError error = view.getGlobalValidationModel().getErrorAt(selectedError); - String errorLineNumber = error.getLineNumber(); - - // peut être null, si l'erreur ne porte pas sur un bean en particulier - if (errorLineNumber != null) { - int errorLineIndex = view.getControlDataTableModel().getRealIndexOfLine(errorLineNumber); - view.getControlDataTableSelectionModel().setSelectionInterval(errorLineIndex, errorLineIndex); - scrollToVisible(view.getControlDataTable(), errorLineIndex, 0); - }*/ + public void showSelectedError(ControlView view, TreeSelectionEvent event) { + TreePath selectedError = view.getValidationGlobalErrorsTable().getTreeSelectionModel().getSelectionPath(); + if (selectedError != null) { + Object[] pathWay = selectedError.getPath(); + + // 2 = validation group (middle level) + // 3 = validation error (last level) + if (pathWay.length == 3) { + ValidationError error = (ValidationError)pathWay[2]; + String errorLineNumber = error.getLineNumber(); + // peut être null, si l'erreur ne porte pas sur un bean en particulier + if (errorLineNumber != null) { + int errorLineIndex = view.getControlDataTableModel().getRealIndexOfLine(errorLineNumber); + + // ca peut arriver si la ligne a été supprimée + if (errorLineIndex >= 0) { + view.getControlDataTableSelectionModel().setSelectionInterval(errorLineIndex, errorLineIndex); + scrollToVisible(view.getControlDataTable(), errorLineIndex, 0); + } + } + } } } + + /** + * Affiche le menu contextuel de l'arbre qui contient les erreurs de + * validation globales. + * + * @param controlView view + * @param event mouse event + */ + public void showGlobalErrorTableContextMenu(final ControlView controlView, MouseEvent event) { + // clic contextuel + if (event.getButton() == MouseEvent.BUTTON3) { + TreePath selectedError = controlView.getValidationGlobalErrorsTable().getTreeSelectionModel().getSelectionPath(); + + // plusieurs lignes selectionnées et pas la premiere colonne (Line index) + if (selectedError != null) { + Object[] pathWay = selectedError.getPath(); + + // 2 = validation group (middle level) + if (pathWay.length == 2) { + final GlobalValidationGroup validationGroup = (GlobalValidationGroup)pathWay[1]; + JPopupMenu popupMenu = new JPopupMenu(_("coser.ui.control.globalErrorMenuLabel")); + JMenuItem replaceMenu = new JMenuItem(_("coser.ui.control.globalErrorMenuSelectAll")); + replaceMenu.addActionListener(new ActionListener() { + @Override + public void actionPerformed(ActionEvent e) { + selectAllErrorGroupLines(controlView, validationGroup); + } + }); + popupMenu.add(replaceMenu); + popupMenu.show(controlView.getValidationGlobalErrorsTable(), event.getX(), event.getY()); + } + } + } + } + /** + * Selectionne toutes les lignes associés au erreur d'un group d'erreur. + * + * @param controlView controlView + * @param validationGroup validationGroup + */ + protected void selectAllErrorGroupLines(ControlView controlView, GlobalValidationGroup validationGroup) { + GlobalValidationModel model = controlView.getGlobalValidationModel(); + controlView.getControlDataTableSelectionModel().clearSelection(); + int childCount = model.getChildCount(validationGroup); + for (int indexChild = 0 ; indexChild < childCount ; ++indexChild) { + ValidationError validationError = (ValidationError)model.getChild(validationGroup, indexChild); + String errorLineNumber = validationError.getLineNumber(); + int errorLineIndex = controlView.getControlDataTableModel().getRealIndexOfLine(errorLineNumber); + + // ca peut arriver si la ligne a été supprimée + if (errorLineIndex >= 0) { + controlView.getControlDataTableSelectionModel().addSelectionInterval(errorLineIndex, errorLineIndex); + if (indexChild == 0) { + scrollToVisible(controlView.getControlDataTable(), errorLineIndex, 0); + } + } + } + } + + /** * Scroll le viewport de la table à la ligne demandée. * * @param table table Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/ControlView.jaxx 2010-11-03 16:11:03 UTC (rev 159) @@ -39,6 +39,10 @@ <row> <cell fill="horizontal" insets="0" anchor="west" columns="2"> <JToolBar floatable="false"> + <JButton id="saveButton" icon="bullet_disk.png" + text="coser.ui.control.save" enabled="false" + onActionPerformed="getHandler().saveControl(this)" /> + <JSeparator /> <fr.ifremer.coser.ui.control.ControlCategoryListModel id="categoryComboBoxModel" /> <JComboBox id="categoryComboBox" model="{categoryComboBoxModel}" renderer="{new fr.ifremer.coser.ui.control.ControlCategoryListRenderer()}" @@ -122,9 +126,11 @@ <GlobalValidationModel id="globalValidationModel" /> <JXTreeTable id='validationGlobalErrorsTable' treeTableModel="{globalValidationModel}" rootVisible="false" showsRootHandles="true" - treeCellRenderer="{new ControlValidationRenderer()}" /> - <ListSelectionModel id="globalValidationTableSelectionModel" - javaBean="validationGlobalErrorsTable.getSelectionModel()" + treeCellRenderer="{new ControlValidationRenderer()}" + onMouseClicked="getHandler().showGlobalErrorTableContextMenu(this, event)" + selectionMode="{ListSelectionModel.SINGLE_SELECTION}" /> + <javax.swing.tree.TreeSelectionModel id="globalValidationTableSelectionModel" + javaBean="validationGlobalErrorsTable.getTreeSelectionModel()" onValueChanged="getHandler().showSelectedError(this, event)" /> </JScrollPane> </cell> @@ -142,10 +148,4 @@ <JButton text="coser.ui.validation.checkData" onActionPerformed="getHandler().checkData(this)" /> </cell> </row> - <row> - <cell anchor="east" columns="2"> - <JButton id="saveButton" text="coser.ui.control.save" enabled="false" - onActionPerformed="getHandler().saveControl(this)" /> - </cell> - </row> </Table> Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/GlobalValidationGroup.java =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/GlobalValidationGroup.java 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/control/GlobalValidationGroup.java 2010-11-03 16:11:03 UTC (rev 159) @@ -1,25 +1,23 @@ /* * #%L - * - * * $Id$ * $HeadURL$ * %% * Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric * %% * This program is free software: you can redistribute it and/or modify - * it under the terms of the GNU Lesser General Public License as + * it under the terms of the GNU General Public License as * published by the Free Software Foundation, either version 3 of the * License, or (at your option) any later version. * * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Lesser Public License for more details. + * GNU General Public License for more details. * - * You should have received a copy of the GNU General Lesser Public + * You should have received a copy of the GNU General Public * License along with this program. If not, see - * <http://www.gnu.org/licenses/lgpl-3.0.html>. + * <http://www.gnu.org/licenses/gpl-3.0.html>. * #L% */ Modified: trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties =================================================================== --- trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-ui/src/main/resources/i18n/coser-ui-en_GB.properties 2010-11-03 16:11:03 UTC (rev 159) @@ -9,7 +9,6 @@ coser.config.support.email.description=Support email address coser.ui.common.cancel=Cancel coser.ui.common.comment=Comment -coser.ui.common.delete=Delete coser.ui.common.selectAll=All coser.ui.common.selectFile=Select\u2026 coser.ui.common.unselectAll=None @@ -17,12 +16,16 @@ coser.ui.config.title=Configuration coser.ui.control.confirmDeletionMessage=Are you sure you want to delete this data ? coser.ui.control.confirmDeletionTitle=Confirm delete +coser.ui.control.confirmDeletionsMessage=Are you sure you want to delete %d selected lines ? +coser.ui.control.dataMenuDeleteSelected=Deleted selected lines coser.ui.control.dataMenuLabel=Data menu -coser.ui.control.dataMenuReplace=Replace in %s +coser.ui.control.dataMenuReplace=Replace in %s for selection +coser.ui.control.dataMenuReplaceAll=Replace in %s in all data coser.ui.control.deleteLine=Delete line coser.ui.control.global.done=\u2026 -coser.ui.control.global.level=Type coser.ui.control.global.message=Message +coser.ui.control.globalErrorMenuLabel=Error menu +coser.ui.control.globalErrorMenuSelectAll=Select all lines coser.ui.control.graph.specy=Specy \: coser.ui.control.graphtitle=Graph coser.ui.control.replace.find=Find \: Modified: trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties =================================================================== --- trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties 2010-11-03 16:10:01 UTC (rev 158) +++ trunk/coser-ui/src/main/resources/i18n/coser-ui-fr_FR.properties 2010-11-03 16:11:03 UTC (rev 159) @@ -9,7 +9,6 @@ coser.config.support.email.description=Adresse de suport pour l'envoi des erreurs coser.ui.common.cancel=Annuler coser.ui.common.comment=Commentaire -coser.ui.common.delete=Supprimer coser.ui.common.selectAll=Tous coser.ui.common.selectFile=S\u00E9lectionner\u2026 coser.ui.common.unselectAll=Aucun @@ -17,12 +16,16 @@ coser.ui.config.title=Configuration coser.ui.control.confirmDeletionMessage=\u00CAtes vous s\u00FBr de vouloir supprimer cette donn\u00E9e ? coser.ui.control.confirmDeletionTitle=Confirmation de suppression +coser.ui.control.confirmDeletionsMessage=\u00CAtes vous s\u00FBr de vouloir supprimer les %d lignes s\u00E9lectionn\u00E9es ? +coser.ui.control.dataMenuDeleteSelected=Supprimer les lignes s\u00E9lectionn\u00E9es coser.ui.control.dataMenuLabel=Menu des donn\u00E9es -coser.ui.control.dataMenuReplace=Remplacer dans %s +coser.ui.control.dataMenuReplace=Remplacer dans %s pour la s\u00E9lection +coser.ui.control.dataMenuReplaceAll=Replacer dans %s pour toutes les lignes coser.ui.control.deleteLine=Supprimer la ligne coser.ui.control.global.done=\u2026 -coser.ui.control.global.level=Type coser.ui.control.global.message=Message +coser.ui.control.globalErrorMenuLabel=Menu des erreurs +coser.ui.control.globalErrorMenuSelectAll=S\u00E9lectionner toutes les lignes coser.ui.control.graph.specy=Esp\u00E8ces \: coser.ui.control.graphtitle=Graphique coser.ui.control.replace.find=Chercher \:

1 0

r158 - trunk/coser-business/src/test/java/fr/ifremer/coser/services
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 16:10:01 +0000 (Wed, 03 Nov 2010) New Revision: 158 Log: Selection de l'espece sur laquelle porte le graphique. Changement du type de graphique en ligne (xy). Ajoute de la deuxieme s?\195?\169rie taille sur le graphique des captures. Modified: trunk/coser-business/src/test/java/fr/ifremer/coser/services/ChartServiceTest.java Modified: trunk/coser-business/src/test/java/fr/ifremer/coser/services/ChartServiceTest.java =================================================================== --- trunk/coser-business/src/test/java/fr/ifremer/coser/services/ChartServiceTest.java 2010-11-03 16:07:52 UTC (rev 157) +++ trunk/coser-business/src/test/java/fr/ifremer/coser/services/ChartServiceTest.java 2010-11-03 16:10:01 UTC (rev 158) @@ -45,6 +45,7 @@ * Last update : $Date$ * By : $Author$ */ + at Ignore public class ChartServiceTest extends CoserTestAbstract { protected ProjectService projectService;

1 0

r157 - trunk/src/site/rst/user
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 16:07:52 +0000 (Wed, 03 Nov 2010) New Revision: 157 Log: Add license header Modified: trunk/src/site/rst/user/validation.rst Modified: trunk/src/site/rst/user/validation.rst =================================================================== --- trunk/src/site/rst/user/validation.rst 2010-11-03 16:02:00 UTC (rev 156) +++ trunk/src/site/rst/user/validation.rst 2010-11-03 16:07:52 UTC (rev 157) @@ -1,3 +1,27 @@ +.. - +.. * #%L +.. * Coser +.. * +.. * $Id$ +.. * $HeadURL$ +.. * %% +.. * Copyright (C) 2010 Ifremer, Codelutin, Chatellier Eric +.. * %% +.. * This program is free software: you can redistribute it and/or modify +.. * it under the terms of the GNU Lesser General Public License as +.. * published by the Free Software Foundation, either version 3 of the +.. * License, or (at your option) any later version. +.. * +.. * This program is distributed in the hope that it will be useful, +.. * but WITHOUT ANY WARRANTY; without even the implied warranty of +.. * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +.. * GNU General Lesser Public License for more details. +.. * +.. * You should have received a copy of the GNU General Lesser Public +.. * License along with this program. If not, see +.. * <http://www.gnu.org/licenses/lgpl-3.0.html>. +.. * #L% +.. - Validation ==========

1 0

r156 - in trunk/coser-business/src/main: java/fr/ifremer/coser/services resources/i18n
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 16:02:00 +0000 (Wed, 03 Nov 2010) New Revision: 156 Log: Modification du message d'erreur concernant le s?\195?\169parateur Modified: trunk/coser-business/src/main/java/fr/ifremer/coser/services/ImportService.java trunk/coser-business/src/main/resources/i18n/coser-business-en_GB.properties trunk/coser-business/src/main/resources/i18n/coser-business-fr_FR.properties Modified: trunk/coser-business/src/main/java/fr/ifremer/coser/services/ImportService.java =================================================================== --- trunk/coser-business/src/main/java/fr/ifremer/coser/services/ImportService.java 2010-11-03 13:49:04 UTC (rev 155) +++ trunk/coser-business/src/main/java/fr/ifremer/coser/services/ImportService.java 2010-11-03 16:02:00 UTC (rev 156) @@ -102,8 +102,8 @@ // check header String[] line = csvReader.readNext(); if (line == null || line.length <= 1) { - throw new CoserBusinessException(_("Can't read file '%s'. Check CSV file separator (%c)", - file.getAbsolutePath(), CoserConstants.CSV_SEPARATOR_CHAR)); + throw new CoserBusinessException(_("Can't read file '%s'. Check CSV file separator", + file.getAbsolutePath())); } else { if (originalLoading) { Modified: trunk/coser-business/src/main/resources/i18n/coser-business-en_GB.properties =================================================================== --- trunk/coser-business/src/main/resources/i18n/coser-business-en_GB.properties 2010-11-03 13:49:04 UTC (rev 155) +++ trunk/coser-business/src/main/resources/i18n/coser-business-en_GB.properties 2010-11-03 16:02:00 UTC (rev 156) @@ -2,7 +2,7 @@ Can't\ create\ project= Can't\ find\ line\ %s\ for\ deletion= Can't\ find\ line\ %s\ for\ undeletion= -Can't\ read\ file\ '%s'.\ Check\ CSV\ file\ separator\ (%c)= +Can't\ read\ file\ '%s'.\ Check\ CSV\ file\ separator= Can't\ replace\ data\ value.\ Expected\ %s\ but\ was\ %s= Depth\ attribute\ is\ not\ a\ valid\ double= Maturity\ attribute\ is\ required= Modified: trunk/coser-business/src/main/resources/i18n/coser-business-fr_FR.properties =================================================================== --- trunk/coser-business/src/main/resources/i18n/coser-business-fr_FR.properties 2010-11-03 13:49:04 UTC (rev 155) +++ trunk/coser-business/src/main/resources/i18n/coser-business-fr_FR.properties 2010-11-03 16:02:00 UTC (rev 156) @@ -2,7 +2,7 @@ Can't\ create\ project=Impossible de cr\u00E9er le projet Can't\ find\ line\ %s\ for\ deletion= Can't\ find\ line\ %s\ for\ undeletion= -Can't\ read\ file\ '%s'.\ Check\ CSV\ file\ separator\ (%c)=Impossible de lire le fichier '%s'.\nMerci de v\u00E9rifier le s\u00E9parateur utilis\u00E9 (%c). +Can't\ read\ file\ '%s'.\ Check\ CSV\ file\ separator=Impossible de lire le fichier '%s'.\nMerci de v\u00E9rifier le s\u00E9parateur utilis\u00E9 est bien un point-virgule ';' Can't\ replace\ data\ value.\ Expected\ %s\ but\ was\ %s= Depth\ attribute\ is\ not\ a\ valid\ double= Maturity\ attribute\ is\ required=

1 0

r155 - in trunk/coser-ui/src/main/java/fr/ifremer/coser/ui: . selection
by chatellier＠users.labs.libre-entreprise.org 03 Nov '10

03 Nov '10

Author: chatellier Date: 2010-11-03 13:49:04 +0000 (Wed, 03 Nov 2010) New Revision: 155 Log: Retrait des valeurs par defaut (tests) Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/selection/SelectionResultView.jaxx Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx 2010-11-03 13:45:45 UTC (rev 154) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/ProjectCreationView.jaxx 2010-11-03 13:49:04 UTC (rev 155) @@ -67,7 +67,7 @@ <JLabel text="coser.ui.project.captureFile" /> </cell> <cell weightx="1" fill="horizontal"> - <JTextField id="projectCapturesFileField" text="/home/chatellier/tmp/coser/rsufi/base/captures.csv" /> + <JTextField id="projectCapturesFileField" /> </cell> <cell> <JButton id="projectCapturesSelectButton" text="coser.ui.common.selectFile" @@ -79,7 +79,7 @@ <JLabel text="coser.ui.project.stratesFile" /> </cell> <cell fill="horizontal"> - <JTextField id="projectStratesFileField" text="/home/chatellier/tmp/coser/rsufi/base/strates.csv" /> + <JTextField id="projectStratesFileField" /> </cell> <cell> <JButton id="projectStratesFileSelectButton" text="coser.ui.common.selectFile" @@ -91,7 +91,7 @@ <JLabel text="coser.ui.project.lengthFile" /> </cell> <cell fill="horizontal"> - <JTextField id="projectLengthFileField" text="/home/chatellier/tmp/coser/rsufi/base/tailles.csv" /> + <JTextField id="projectLengthFileField" /> </cell> <cell> <JButton id="projectSizeFileSelectButton" text="coser.ui.common.selectFile" @@ -103,7 +103,7 @@ <JLabel text="coser.ui.project.traitsFile" /> </cell> <cell fill="horizontal"> - <JTextField id="projectTraitsFileField" text="/home/chatellier/tmp/coser/rsufi/base/traits.csv" /> + <JTextField id="projectTraitsFileField" /> </cell> <cell> <JButton id="projectTraitsFileSelectButton" text="coser.ui.common.selectFile" Modified: trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/selection/SelectionResultView.jaxx =================================================================== --- trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/selection/SelectionResultView.jaxx 2010-11-03 13:45:45 UTC (rev 154) +++ trunk/coser-ui/src/main/java/fr/ifremer/coser/ui/selection/SelectionResultView.jaxx 2010-11-03 13:49:04 UTC (rev 155) @@ -32,7 +32,7 @@ <JLabel text="coser.ui.result.extractDataLabel" /> </cell> <cell weightx="1" fill="horizontal"> - <JTextField id="resultExtractDataField" editable="false" /> + <JTextField id="resultExtractDataField" /> </cell> <cell> <JButton text="coser.ui.common.selectFile" />

1 0