Author: echatellier Date: 2012-03-28 22:14:41 +0200 (Wed, 28 Mar 2012) New Revision: 2849 Url: http://chorem.org/repositories/revision/jtimer/2849 Log: Fix synchronize on boolean (spotted by sonar) Modified: trunk/src/main/java/org/chorem/jtimer/ui/tasks/RunTaskJob.java Modified: trunk/src/main/java/org/chorem/jtimer/ui/tasks/RunTaskJob.java =================================================================== --- trunk/src/main/java/org/chorem/jtimer/ui/tasks/RunTaskJob.java 2012-03-28 16:37:31 UTC (rev 2848) +++ trunk/src/main/java/org/chorem/jtimer/ui/tasks/RunTaskJob.java 2012-03-28 20:14:41 UTC (rev 2849) @@ -29,6 +29,7 @@ import java.util.Collection; import java.util.Date; import java.util.HashSet; +import java.util.concurrent.atomic.AtomicBoolean; import java.util.concurrent.atomic.AtomicLong; import javax.swing.JOptionPane; @@ -84,7 +85,7 @@ protected AtomicLong lastUserActivity; /** Want to stop flag. */ - protected Boolean bWantToStop; + protected AtomicBoolean bWantToStop; /** * Constructor. @@ -101,7 +102,7 @@ this.parentApp = parentApp; // init with False - bWantToStop = Boolean.FALSE; + bWantToStop = new AtomicBoolean(false); // save vars this.managedTask = managedTask; @@ -240,7 +241,7 @@ // test if task want to stop synchronized (bWantToStop) { - dontWantToStop = !bWantToStop.booleanValue(); + dontWantToStop = !bWantToStop.get(); } } @@ -368,7 +369,7 @@ */ public void wantToStop() { synchronized (bWantToStop) { - bWantToStop = Boolean.TRUE; + bWantToStop.set(true); } } @@ -380,7 +381,7 @@ public boolean isStopping() { boolean stopping; synchronized (bWantToStop) { - stopping = bWantToStop.booleanValue(); + stopping = bWantToStop.get(); } return stopping; }