April 2008 - Nuiton-rss-commits - mailman.cloud.codelutin.com

[Lutinweb-commits] r20 - in trunk/lutinrss: . src/main/webapp src/test/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 25 Apr '08

25 Apr '08

Author: tchemit Date: 2008-04-25 07:33:18 +0000 (Fri, 25 Apr 2008) New Revision: 20 Modified: trunk/lutinrss/ trunk/lutinrss/src/main/webapp/ trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java Log: utilisation RSSConfigInitializer + introduction parametre resolv pour forcer la resolution Property changes on: trunk/lutinrss ___________________________________________________________________ Name: svn:ignore - target + target profiles.xml nbactions.xml Property changes on: trunk/lutinrss/src/main/webapp ___________________________________________________________________ Name: svn:ignore + META-INF Modified: trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java =================================================================== --- trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java 2008-04-25 07:32:20 UTC (rev 19) +++ trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java 2008-04-25 07:33:18 UTC (rev 20) @@ -71,16 +71,16 @@ int nbItem = -1; RSSHelper instance = new RSSHelper(); String expResult = ""; - String result = instance.getHTML(feedName, feedRepr, nbItem); + String result = instance.getHTML(feedName, feedRepr, nbItem,false); System.out.println("***" + result); - result = instance.getHTML(feedName, feedRepr, nbItem); + result = instance.getHTML(feedName, feedRepr, nbItem,false); System.out.println("***" + result); Thread.sleep(2000); - result = instance.getHTML(feedName, feedRepr, nbItem); + result = instance.getHTML(feedName, feedRepr, nbItem,false); System.out.println("***" + result); - result = instance.getHTML(feedName, feedRepr, nbItem); + result = instance.getHTML(feedName, feedRepr, nbItem,false); System.out.println("***" + result); // assertEquals(expResult, result); // TODO review the generated test code and remove the default call to fail.

1 0

[Lutinweb-commits] r19 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 25 Apr '08

25 Apr '08

Author: tchemit Date: 2008-04-25 07:32:20 +0000 (Fri, 25 Apr 2008) New Revision: 19 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java Log: utilisation RSSConfigInitializer + introduction parametre resolv pour forcer la resolution Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java 2008-04-25 07:31:11 UTC (rev 18) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java 2008-04-25 07:32:20 UTC (rev 19) @@ -2,11 +2,8 @@ import java.io.*; -import java.util.logging.Level; -import java.util.logging.Logger; import javax.servlet.*; import javax.servlet.http.*; -import org.apache.commons.beanutils.BeanUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; @@ -39,10 +36,6 @@ private static final Log log = LogFactory.getLog(RSSServlet.class); /** - * la propriete de configuration qui definit le prefix a jouter pour scruter la configuration - */ - protected static final String CONFIGURATION_PREFIX_PROPERTY= RSSServlet.class.getSimpleName()+"_configuration_prefix"; - /** * L'objet permettant de recupérer la representation HTML d'un feed */ protected transient RSSHelper rss; @@ -92,13 +85,17 @@ public void init(ServletConfig config,boolean initRssConfig) throws ServletException { try { super.init(config); - if (initRssConfig) { - + if (initRssConfig) { // init depuis la config de servlet - initRssConfig(config); + new RSSConfig.RSSConfigInitializer<ServletConfig>() { + @Override + protected String getConfigValue(ServletConfig config, String fullConfigName) { + return config.getInitParameter(fullConfigName); + } + }.init(config); // instanciate rss avec les implanatation par defaut - initDefaultRssHelper(); + rss = RSSHelper.newDefaultInstance(); } } catch (Exception eee) { log.warn("Can't configure Servlet", eee); @@ -134,51 +131,16 @@ PrintWriter out = response.getWriter(); try { String feedRepr = request.getParameter("feedRepr"); - Integer nbItem = convertToInt(request.getParameter("nbItem")); - out.println(getHTML(feedName, feedRepr, nbItem)); + Integer nbItem = convertToInt(request.getParameter("nbItem")); + String t = request.getParameter("resolv"); + Boolean resolv = t!=null && "true".equals(t); + out.println(rss.getHTML(feedName, feedRepr, nbItem,resolv)); } finally { out.close(); } } - } - - protected void initDefaultRssHelper() throws ServletException { - try { - rss = new RSSHelper(RSSConfig.DEFAULT_RESOLVER_CLASS.newInstance(), - RSSConfig.DEFAULT_RENDERER_CLASS.newInstance()); - } catch (Exception ex) { - log.warn("Can't configure rsshelper", ex); - throw new ServletException("Can't configure rsshelper", ex); - } - } - - protected void initRssConfig(ServletConfig config) throws Exception { - // recherche de la propriete RSSServlet_configuration_prefix - String prefixConfig = config.getInitParameter(CONFIGURATION_PREFIX_PROPERTY); - prefixConfig = prefixConfig==null?"":prefixConfig.trim(); - loadConfig(config, prefixConfig,"TIME_FORCE_RETRIEVED"); - loadConfig(config, prefixConfig,"DEFAULT_RENDERER_CONFIG"); - loadConfig(config, prefixConfig,"DEFAULT_NB_ITEM"); - loadConfig(config, prefixConfig,"DEFAULT_RENDERER_CLASS"); - loadConfig(config, prefixConfig,"DEFAULT_RESOLVER_CLASS"); - } + } - protected void loadConfig(ServletConfig config,String prefix, String configName) throws Exception { - String value = config.getInitParameter(prefix+configName); - loadConfig(configName,value); - } - - protected void loadConfig(String configName,String value ) throws Exception { - if (value != null && !"".equals(value)) { - log.info("key: "+configName+", value:"+value); - BeanUtils.setProperty(new RSSConfig(), configName, value); - } - } - - protected String getHTML(String feedName,String feedRepr,Integer nbItems) { - return rss.getHTML(feedName, feedRepr, nbItems); - } - protected Integer convertToInt(String parameter) { Integer result = null; try {

1 0

[Lutinweb-commits] r18 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 25 Apr '08

25 Apr '08

Author: tchemit Date: 2008-04-25 07:31:11 +0000 (Fri, 25 Apr 2008) New Revision: 18 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java Log: ajout de la class RSSConfigInitializer qui permet d'initialiser RSSConfig de mani?\195?\168re dynamique Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java 2008-04-25 07:30:28 UTC (rev 17) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java 2008-04-25 07:31:11 UTC (rev 18) @@ -1,17 +1,27 @@ package org.codelutin.rss; +import org.apache.commons.beanutils.BeanUtils; + /** * * @author poussin */ public class RSSConfig { + /** + * la propriete de configuration qui definit le prefix a jouter pour scruter la configuration + */ + protected static final String CONFIGURATION_PREFIX_PROPERTY = RSSServlet.class.getSimpleName() + "_configuration_prefix"; + /** Temps a partir duquel on reforce une recuperation */ public static long TIME_FORCE_RETRIEVED = 5 * 60 * 1000; + public static FeedRendererConfig DEFAULT_RENDERER_CONFIG = new FeedRendererConfig("n-natd"); - public static int DEFAULT_NB_ITEM = -1; + public static int DEFAULT_NB_ITEM = 7; + public static Class<? extends FeedRenderer> DEFAULT_RENDERER_CLASS = FeedHTMLRenderer.class; + public static Class<? extends FeedURLResolver> DEFAULT_RESOLVER_CLASS = SimpleFeedURLResolver.class; public void setTIME_FORCE_RETRIEVED(long TIME_FORCE_RETRIEVED) { @@ -34,4 +44,44 @@ RSSConfig.DEFAULT_RESOLVER_CLASS = DEFAULT_RESOLVER_CLASS; } + /** + * + * @param T la classe sources de la configuration + */ + public static abstract class RSSConfigInitializer<T> { + + /** + * + * @param config l'object source contenant les configs + * @param fullConfigName le nom complet de la propriete recherchee + * @return la valeur de la propriete ou null si non trouve + */ + protected abstract String getConfigValue(T config, String fullConfigName); + + /** + * Initialise RSSConfig. + * @param config l'object de configuration + */ + public void init(T config) { + String prefixConfig = getConfigValue(config, CONFIGURATION_PREFIX_PROPERTY); + prefixConfig = prefixConfig == null ? "" : prefixConfig.trim(); + RSSConfig instance = new RSSConfig(); + loadConfig(config, instance, prefixConfig, "TIME_FORCE_RETRIEVED"); + loadConfig(config, instance, prefixConfig, "DEFAULT_RENDERER_CONFIG"); + loadConfig(config, instance, prefixConfig, "DEFAULT_NB_ITEM"); + loadConfig(config, instance, prefixConfig, "DEFAULT_RENDERER_CLASS"); + loadConfig(config, instance, prefixConfig, "DEFAULT_RESOLVER_CLASS"); + } + + protected void loadConfig(T config, RSSConfig instance, String prefix, String configName) { + String value = getConfigValue(config, prefix + configName); + if (value != null && !"".equals(value)) { + try { + BeanUtils.setProperty(instance, configName, value); + } catch (Exception ex) { + throw new IllegalStateException("could not load property " + configName + " from config " + config + " for reason : " + ex.getMessage()); + } + } + } + } }

1 0

[Lutinweb-commits] r17 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 25 Apr '08

25 Apr '08

Author: tchemit Date: 2008-04-25 07:30:28 +0000 (Fri, 25 Apr 2008) New Revision: 17 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java Log: ajout methode newDefaultInstance pour obtenir une nouvelle instance de RssHelper avec les implanations trouvees dans RSSConfig Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java 2008-04-24 13:06:57 UTC (rev 16) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java 2008-04-25 07:30:28 UTC (rev 17) @@ -21,6 +21,19 @@ /** to use log facility, just put in your code: log.info(\"...\"); */ private static final Log log = LogFactory.getLog(RSSHelper.class); + + /** + * + * @return une nouvelle instance de RssHelper en utilisant les implantations + * definies dans RSSConfig. + * @throws java.lang.Exception pour tout pb lors de l'instanciation des objects + */ + public static RSSHelper newDefaultInstance() throws Exception { + FeedURLResolver r = RSSConfig.DEFAULT_RESOLVER_CLASS.newInstance(); + FeedRenderer rr = RSSConfig.DEFAULT_RENDERER_CLASS.newInstance(); + RSSHelper helper = new RSSHelper(r,rr); + return helper; + } /** La classe permettant de resoudre les urls */ protected FeedURLResolver resolver = null; @@ -57,20 +70,29 @@ public FeedURLResolver getResolver() { return resolver; } - + + public void removeFeed(String feedName) { + feeds.remove(feedName); + } + /** * Permet de recuperer un certain nombre d'item du feed demande * * @param feedName nom du feed souhaite, l'url sera resolu avec le FeedURLResolver * @param representation indique les champs en sortie souhaites (ex: n-nt) * @param nbItem le nombre d'item du feed souhaite + * @param forceResolv un flag pour forcer la resolution * @return le code html representant le feed */ - public String getHTML(String feedName, String representation, Integer nbItem) { + public String getHTML(String feedName, String representation, Integer nbItem,boolean forceResolv) { try { FeedData feed = (FeedData) feeds.get(feedName); - if (feed == null) { + if (feed == null || forceResolv) { feed = resolver.resolv(feedName); + if (feed==null) { + log.warn("could not find feed for "+feedName); + return "<span class='feed-error'>No feed found for " + feedName + "</span>"; + } feeds.put(feedName, feed); }

1 0

[Lutinweb-commits] r16 - trunk/lutinrss/src/main/webapp
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 13:06:57 +0000 (Thu, 24 Apr 2008) New Revision: 16 Modified: trunk/lutinrss/src/main/webapp/test.html Log: empty tag + title Modified: trunk/lutinrss/src/main/webapp/test.html =================================================================== --- trunk/lutinrss/src/main/webapp/test.html 2008-04-24 13:06:13 UTC (rev 15) +++ trunk/lutinrss/src/main/webapp/test.html 2008-04-24 13:06:57 UTC (rev 16) @@ -6,7 +6,7 @@ <!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"> <html> <head> - <title></title> + <title>Page de test rss</title> <style type="text/css"> div {border: solid black;} </style> @@ -15,12 +15,12 @@ </head> <body> <h1>Test RSS</h1> - <div id="lmi"></div> - <div id="lemonde"></div> - <div id="developpez"></div> - <div id="formatouvert"></div> - <div id="h2"></div> - <div id="opensi"></div> + <div id="lmi"/> + <div id="lemonde"/> + <div id="developpez"/> + <div id="formatouvert"/> + <div id="h2"/> + <div id="opensi"/> <script> rssinclude("http://www.lemondeinformatique.fr/flux-rss/open-source/rss.xml", "lmi", 5, "indat-natd");

1 0

[Lutinweb-commits] r15 - trunk/lutinrss
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 13:06:13 +0000 (Thu, 24 Apr 2008) New Revision: 15 Modified: trunk/lutinrss/pom.xml Log: ajout du repository dans le pom pour permettre le deployement sans avoir le repo dans son settings... Modified: trunk/lutinrss/pom.xml =================================================================== --- trunk/lutinrss/pom.xml 2008-04-24 12:59:55 UTC (rev 14) +++ trunk/lutinrss/pom.xml 2008-04-24 13:06:13 UTC (rev 15) @@ -18,6 +18,11 @@ <id>labs</id> <url>scp://labs.libre-entreprise.org/home/groups/${pom.artifactId}/htdocs/</url> </site> + <repository> + <id>labs</id> + <url>scp://labs.libre-entreprise.org/home/groups/lutinbuilder/htdocs/maven2</url> + </repository> + </distributionManagement>  @@ -154,12 +159,12 @@ <maven.compile.source>1.5</maven.compile.source> <maven.compile.target>1.5</maven.compile.target> </properties> - <pluginRepositories> +  </profile> </profiles>

1 0

[Lutinweb-commits] r14 - trunk/lutinrss/src/test/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 12:59:55 +0000 (Thu, 24 Apr 2008) New Revision: 14 Modified: trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java Log: suppression test qui ne fonctionne pas pourle moment Modified: trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java =================================================================== --- trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java 2008-04-24 12:59:01 UTC (rev 13) +++ trunk/lutinrss/src/test/java/org/codelutin/rss/RSSTest.java 2008-04-24 12:59:55 UTC (rev 14) @@ -61,8 +61,10 @@ /** * Test of getHTML method, of class RSSHelper. + * TODO do the test, for the moment, do not launch it... + * @throws Exception if any pb */ - public void testGetHTML() throws Exception { + public void _testGetHTML() throws Exception { System.out.println("getHTML"); String feedName = "http://localhost/rss/rss_1.0.xml"; String feedRepr = "n-ndat";

1 0

[Lutinweb-commits] r13 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 12:59:01 +0000 (Thu, 24 Apr 2008) New Revision: 13 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java Log: permettre de configurer le prefix des clef de configuration. suppression des traitements des cas limites sur les param?\195?\168tres, ce n'est pas de la responsabilit?\195?\169 de la servlet Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java 2008-04-24 12:48:52 UTC (rev 12) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSServlet.java 2008-04-24 12:59:01 UTC (rev 13) @@ -1,8 +1,9 @@ package org.codelutin.rss; import java.io.*; -import java.net.*; +import java.util.logging.Level; +import java.util.logging.Logger; import javax.servlet.*; import javax.servlet.http.*; import org.apache.commons.beanutils.BeanUtils; @@ -38,9 +39,13 @@ private static final Log log = LogFactory.getLog(RSSServlet.class); /** + * la propriete de configuration qui definit le prefix a jouter pour scruter la configuration + */ + protected static final String CONFIGURATION_PREFIX_PROPERTY= RSSServlet.class.getSimpleName()+"_configuration_prefix"; + /** * L'objet permettant de recupérer la representation HTML d'un feed */ - protected RSSHelper rss; + protected transient RSSHelper rss; /** * Le code JavaScript a utilise dans les pages clientes */ @@ -57,14 +62,17 @@ " div.innerHTML = \"<span class='feed-error'>Votre navigateur ne supporte pas les objets XMLHTTPRequest...</span>\";\n" + " return;\n" + " }\n" + - " if (!nbItem) {\n" + - " nbItem = -1;\n" + - " }\n" + - " if (!feedRepr) {\n" + - " feedRepr = \"\";\n" + - " }\n" + - " var param = \"feedName=\" + escape(feedName) + \"&nbItem=\" + escape(nbItem) + \"&feedRepr=\" + escape(feedRepr);\n" + - " var url = serlvetUrl + \"?\" + param;\n" + + //" if (!nbItem) {\n" + + //" nbItem = null;\n" + + //" }\n" + + //" if (!feedRepr) {\n" + + //" feedRepr = \"\";\n" + + //" }\n" + + //" var param = \"feedName=\" + escape(feedName) + \"&nbItem=\" + escape(nbItem) + \"&feedRepr=\" + escape(feedRepr);\n" + + //" var url = serlvetUrl + \"?\" + param;\n" + + " var url = serlvetUrl + \"?feedName=\" + escape(feedName);"+ + " if (!!nbItem) {url += \"&nbItem=\" + escape(nbItem);}"+ + " if (!!feedRepr) {url += \"&feedRepr=\" + escape(feedRepr);}"+ " xhr.open(\"GET\", url, true);\n" + " xhr.onreadystatechange = function() {\n" + " if(xhr.readyState == 4) {\n" + @@ -73,38 +81,42 @@ " }\n" + " xhr.send(null);\n" + "}\n"; + private static final long serialVersionUID = 1L; + @Override public void init(ServletConfig config) throws ServletException { + init(config,true); + } + + public void init(ServletConfig config,boolean initRssConfig) throws ServletException { try { super.init(config); - loadConfig(config, "TIME_FORCE_RETRIEVED"); - loadConfig(config, "DEFAULT_RENDERER_CONFIG"); - loadConfig(config, "DEFAULT_NBITEM"); - loadConfig(config, "DEFAULT_RENDERER_CLASS"); - loadConfig(config, "DEFAULT_RESOLVER_CLASS"); - rss = new RSSHelper( - (FeedURLResolver) RSSConfig.DEFAULT_RESOLVER_CLASS.newInstance(), - (FeedRenderer) RSSConfig.DEFAULT_RENDERER_CLASS.newInstance()); + if (initRssConfig) { + + // init depuis la config de servlet + initRssConfig(config); + + // instanciate rss avec les implanatation par defaut + initDefaultRssHelper(); + } } catch (Exception eee) { log.warn("Can't configure Servlet", eee); + if (eee instanceof ServletException) { + throw (ServletException)eee; + } throw new ServletException("Can't configure Servlet", eee); } } - - protected void loadConfig(ServletConfig config, String configName) throws Exception { - String value = config.getInitParameter(configName); - if (value != null && !"".equals(value)) { - BeanUtils.setProperty(new RSSConfig(), configName, value); - } - } /** * Processes requests for both HTTP <code>GET</code> and <code>POST</code> methods. * @param request servlet request * @param response servlet response + * @throws java.io.IOException TODO + * @throws ServletException TODO */ - protected void processRequest(HttpServletRequest request, HttpServletResponse response) + public void processRequest(HttpServletRequest request, HttpServletResponse response) throws ServletException, IOException { String feedName = request.getParameter("feedName"); if (feedName == null || "".equals(feedName)) { @@ -121,22 +133,54 @@ response.setContentType("text/html;charset=UTF-8"); PrintWriter out = response.getWriter(); try { - String feedRepr = request.getParameter("feedRepr"); - if (null == feedRepr || "".equals(feedRepr)) { - feedRepr = "n-ndat"; - } - int nbItem = convertToInt(request.getParameter("nbItem")); - - out.println(rss.getHTML(feedName, feedRepr, nbItem)); - + String feedRepr = request.getParameter("feedRepr"); + Integer nbItem = convertToInt(request.getParameter("nbItem")); + out.println(getHTML(feedName, feedRepr, nbItem)); } finally { out.close(); } } } + + protected void initDefaultRssHelper() throws ServletException { + try { + rss = new RSSHelper(RSSConfig.DEFAULT_RESOLVER_CLASS.newInstance(), + RSSConfig.DEFAULT_RENDERER_CLASS.newInstance()); + } catch (Exception ex) { + log.warn("Can't configure rsshelper", ex); + throw new ServletException("Can't configure rsshelper", ex); + } + } + + protected void initRssConfig(ServletConfig config) throws Exception { + // recherche de la propriete RSSServlet_configuration_prefix + String prefixConfig = config.getInitParameter(CONFIGURATION_PREFIX_PROPERTY); + prefixConfig = prefixConfig==null?"":prefixConfig.trim(); + loadConfig(config, prefixConfig,"TIME_FORCE_RETRIEVED"); + loadConfig(config, prefixConfig,"DEFAULT_RENDERER_CONFIG"); + loadConfig(config, prefixConfig,"DEFAULT_NB_ITEM"); + loadConfig(config, prefixConfig,"DEFAULT_RENDERER_CLASS"); + loadConfig(config, prefixConfig,"DEFAULT_RESOLVER_CLASS"); + } - protected int convertToInt(String parameter) { - int result = -1; + protected void loadConfig(ServletConfig config,String prefix, String configName) throws Exception { + String value = config.getInitParameter(prefix+configName); + loadConfig(configName,value); + } + + protected void loadConfig(String configName,String value ) throws Exception { + if (value != null && !"".equals(value)) { + log.info("key: "+configName+", value:"+value); + BeanUtils.setProperty(new RSSConfig(), configName, value); + } + } + + protected String getHTML(String feedName,String feedRepr,Integer nbItems) { + return rss.getHTML(feedName, feedRepr, nbItems); + } + + protected Integer convertToInt(String parameter) { + Integer result = null; try { result = Integer.parseInt(parameter); } catch(Exception eee) {

1 0

[Lutinweb-commits] r12 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 12:48:52 +0000 (Thu, 24 Apr 2008) New Revision: 12 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java Log: ajout getter + unboxing Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java 2008-04-24 12:47:38 UTC (rev 11) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSHelper.java 2008-04-24 12:48:52 UTC (rev 12) @@ -8,7 +8,6 @@ import com.sun.syndication.feed.synd.SyndEntry; import com.sun.syndication.feed.synd.SyndFeed; import java.net.MalformedURLException; -import java.net.URL; import java.util.List; import org.apache.commons.collections.map.ReferenceMap; import org.apache.commons.logging.Log; @@ -50,7 +49,15 @@ public void setRenderer(FeedRenderer renderer) { this.renderer = renderer; } - + + public FeedRenderer getRenderer() { + return renderer; + } + + public FeedURLResolver getResolver() { + return resolver; + } + /** * Permet de recuperer un certain nombre d'item du feed demande * @@ -61,27 +68,28 @@ */ public String getHTML(String feedName, String representation, Integer nbItem) { try { - FeedData feed = (FeedData) feeds.get(feedName); + FeedData feed = (FeedData) feeds.get(feedName); if (feed == null) { feed = resolver.resolv(feedName); feeds.put(feedName, feed); } - FeedRendererConfig c = null; + FeedRendererConfig c; if (representation != null) { c = new FeedRendererConfig(representation); } else { c = feed.getRendererConfig(); } - int nb = -1; + int nb; if (nbItem != null) { - nb = nbItem.intValue(); + nb = nbItem; } else { nb = feed.getNbItem(); } SyndFeed sf = feed.getFeed(); + //TODO Deal with NPE... if feed is null List syndEntries = sf.getEntries(); if (nb >= 0 && syndEntries.size() >= nb) { syndEntries = syndEntries.subList(syndEntries.size() - nb, syndEntries.size());

1 0

[Lutinweb-commits] r11 - trunk/lutinrss/src/main/java/org/codelutin/rss
by tchemit＠users.labs.libre-entreprise.org 24 Apr '08

24 Apr '08

Author: tchemit Date: 2008-04-24 12:47:38 +0000 (Thu, 24 Apr 2008) New Revision: 11 Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java Log: normalisation nom propri?\195?\169t?\195?\169 NB_ITEM et pas NBITEM + generic Modified: trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java =================================================================== --- trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java 2008-04-24 12:47:17 UTC (rev 10) +++ trunk/lutinrss/src/main/java/org/codelutin/rss/RSSConfig.java 2008-04-24 12:47:38 UTC (rev 11) @@ -9,10 +9,10 @@ /** Temps a partir duquel on reforce une recuperation */ public static long TIME_FORCE_RETRIEVED = 5 * 60 * 1000; public static FeedRendererConfig DEFAULT_RENDERER_CONFIG = new FeedRendererConfig("n-natd"); - public static int DEFAULT_NBITEM = -1; + public static int DEFAULT_NB_ITEM = -1; - public static Class DEFAULT_RENDERER_CLASS = FeedHTMLRenderer.class; - public static Class DEFAULT_RESOLVER_CLASS = SimpleFeedURLResolver.class; + public static Class<? extends FeedRenderer> DEFAULT_RENDERER_CLASS = FeedHTMLRenderer.class; + public static Class<? extends FeedURLResolver> DEFAULT_RESOLVER_CLASS = SimpleFeedURLResolver.class; public void setTIME_FORCE_RETRIEVED(long TIME_FORCE_RETRIEVED) { RSSConfig.TIME_FORCE_RETRIEVED = TIME_FORCE_RETRIEVED; @@ -23,14 +23,14 @@ } public void setDEFAULT_NBITEM(int DEFAULT_NBITEM) { - RSSConfig.DEFAULT_NBITEM = DEFAULT_NBITEM; + RSSConfig.DEFAULT_NB_ITEM = DEFAULT_NBITEM; } - public void setDEFAULT_RENDERER_CLASS(Class DEFAULT_RENDERER_CLASS) { + public void setDEFAULT_RENDERER_CLASS(Class<? extends FeedRenderer> DEFAULT_RENDERER_CLASS) { RSSConfig.DEFAULT_RENDERER_CLASS = DEFAULT_RENDERER_CLASS; } - public void setDEFAULT_RESOLVER_CLASS(Class DEFAULT_RESOLVER_CLASS) { + public void setDEFAULT_RESOLVER_CLASS(Class<? extends FeedURLResolver> DEFAULT_RESOLVER_CLASS) { RSSConfig.DEFAULT_RESOLVER_CLASS = DEFAULT_RESOLVER_CLASS; }

1 0