Index: topia/src/java/org/codelutin/topia/security/TopiaAccessController.java diff -u topia/src/java/org/codelutin/topia/security/TopiaAccessController.java:1.3 topia/src/java/org/codelutin/topia/security/TopiaAccessController.java:1.4 --- topia/src/java/org/codelutin/topia/security/TopiaAccessController.java:1.3 Tue Jul 26 14:00:39 2005 +++ topia/src/java/org/codelutin/topia/security/TopiaAccessController.java Thu Aug 11 16:30:40 2005 @@ -24,7 +24,7 @@ * Created: 4 mai 2005 * * @author Arnaud Thimel -* @version $Revision: 1.3 $ +* @version $Revision: 1.4 $ */ @@ -95,7 +95,7 @@ if (!doSecurity()) return; if (actions == null) - actions = "read"; //TODO Arno : DEFAULT_ACTIONS ??? + actions = "read"; //TODO DEFAULT_ACTIONS ??? Subject subj = Subject.getSubject(AccessController.getContext()); if (subj == null) throw new TopiaSecurityException("Use doAs() and login first"); Index: topia/src/java/org/codelutin/topia/security/TopiaPermission.java diff -u topia/src/java/org/codelutin/topia/security/TopiaPermission.java:1.2 topia/src/java/org/codelutin/topia/security/TopiaPermission.java:1.3 --- topia/src/java/org/codelutin/topia/security/TopiaPermission.java:1.2 Fri May 20 17:51:10 2005 +++ topia/src/java/org/codelutin/topia/security/TopiaPermission.java Thu Aug 11 16:30:40 2005 @@ -24,7 +24,7 @@ * Created: 2 mai 2005 * * @author Benjamin Poussin - * @version $Revision: 1.2 $ + * @version $Revision: 1.3 $ */ package org.codelutin.topia.security; @@ -199,7 +199,7 @@ String principalName = null; if (tok.hasMoreTokens()) { principalName = tok.nextToken(); - } else {//TODO Arno !!! + } else { throw new IllegalArgumentException( "Principal must be followed by name"); } Index: topia/src/java/org/codelutin/topia/security/TopiaPolicy.java diff -u topia/src/java/org/codelutin/topia/security/TopiaPolicy.java:1.3 topia/src/java/org/codelutin/topia/security/TopiaPolicy.java:1.4 --- topia/src/java/org/codelutin/topia/security/TopiaPolicy.java:1.3 Wed Jun 15 15:14:54 2005 +++ topia/src/java/org/codelutin/topia/security/TopiaPolicy.java Thu Aug 11 16:30:40 2005 @@ -24,7 +24,7 @@ * Created: 2 mai 2005 * * @author Benjamin Poussin - * @version $Revision: 1.3 $ + * @version $Revision: 1.4 $ */ package org.codelutin.topia.security; @@ -182,14 +182,14 @@ TopiaPermission perm = (TopiaPermission)p; key = new HashMapMultiKey.Key().add(perm.getId()).add(perm.getPrincipals()); } else { - key.add(p.getName());//TODO Arno : A vérif !!! + key.add(p.getName());//TODO A vérifier } if (permissions.get(key) == null) log.finest("adding new Permission (" + key + "): " + p); else log.finest("replacing Permission (" + key + "): " + p); permissions.put(key, p); - //TODO Arno ??? Faut-il parcourir les principals pour les ajouter un à un + //Faut-il parcourir les principals pour les ajouter un à un //Réponse : Non ! car si on fait ca, plus de diff entre "perm(princ1+princ2)" et "perm(princ1)+perm(princ2)" } @@ -207,8 +207,9 @@ */ private void modifyPermission(Permission permission) { log.finest("permissionModified : " + permission); - addPermission(permission); //TODO Arno : A priori idem à addPerm car on - //utilise une HashMap (donc écrase le précedent) - A vérif + addPermission(permission); //A priori idem à addPerm car on + //utilise une HashMap (donc écrase le précedent) + //TODO A vérifier } /* (non-Javadoc) @@ -228,7 +229,7 @@ TopiaPermission perm = (TopiaPermission)permission; key = new HashMapMultiKey.Key().add(perm.getId()).add(perm.getPrincipals()); } else { - key.add(permission.getName()); //TODO Arno : A vérif !!! + key.add(permission.getName()); //TODO A vérifier } if (permissions.get(key) == null) log.finest("Permission not found for delete: " + permission); Index: topia/src/java/org/codelutin/topia/security/TopiaSecurityHelper.java diff -u topia/src/java/org/codelutin/topia/security/TopiaSecurityHelper.java:1.10 topia/src/java/org/codelutin/topia/security/TopiaSecurityHelper.java:1.11 --- topia/src/java/org/codelutin/topia/security/TopiaSecurityHelper.java:1.10 Fri Jul 29 17:18:45 2005 +++ topia/src/java/org/codelutin/topia/security/TopiaSecurityHelper.java Thu Aug 11 16:30:40 2005 @@ -23,9 +23,9 @@ * Created: 15 juillet 2005 17:39:35 CEST * * @author Benjamin POUSSIN - * @version $Revision: 1.10 $ + * @version $Revision: 1.11 $ * - * Last update: $Date: 2005/07/29 17:18:45 $ + * Last update: $Date: 2005/08/11 16:30:40 $ * by : $Author: thimel $ */ @@ -213,8 +213,8 @@ */ protected List ldapAuthentication(String login, String password) throws TopiaSecurityException { + //TODO A implémenter throw new TopiaSecurityException("ldapAuthentication not supported"); - //TODO Arno ;) } /**