February 2013 - Tutti-commits - mailman.cloud.codelutin.com

r325 - in trunk/tutti-persistence/src: main/xmi test/java/fr/ifremer/tutti/persistence/entities/protocol
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 09:39:17 +0100 (Mon, 04 Feb 2013) New Revision: 325 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/325 Log: fix species and speciesProtocol api Modified: trunk/tutti-persistence/src/main/xmi/tutti-persistence.zargo trunk/tutti-persistence/src/test/java/fr/ifremer/tutti/persistence/entities/protocol/TuttiProtocolsTest.java Modified: trunk/tutti-persistence/src/main/xmi/tutti-persistence.zargo =================================================================== (Binary files differ) Modified: trunk/tutti-persistence/src/test/java/fr/ifremer/tutti/persistence/entities/protocol/TuttiProtocolsTest.java =================================================================== --- trunk/tutti-persistence/src/test/java/fr/ifremer/tutti/persistence/entities/protocol/TuttiProtocolsTest.java 2013-02-04 01:48:10 UTC (rev 324) +++ trunk/tutti-persistence/src/test/java/fr/ifremer/tutti/persistence/entities/protocol/TuttiProtocolsTest.java 2013-02-04 08:39:17 UTC (rev 325) @@ -70,7 +70,6 @@ " id: 1\n" + " calcifySampleEnabled: true\n" + " cruiseCode: BAR\n" + - " genusSpecies: bar\n" + " lengthStepPmfmId: 1394\n" + " maturityEnabled: true\n" + " sexEnabled: true\n" + @@ -82,7 +81,6 @@ " calcifySampleEnabled: true\n" + " countIfNoFrequencyEnabled: true\n" + " cruiseCode: CHIN\n" + - " genusSpecies: chinchard\n" + " lengthStepPmfmId: 323\n" + " maturityEnabled: true\n" + " sexEnabled: true\n" + @@ -149,7 +147,6 @@ Assert.assertEquals("1", sp1.getId()); Assert.assertEquals("11242", sp1.getSpeciesId()); Assert.assertEquals("BAR", sp1.getCruiseCode()); - Assert.assertEquals("bar", sp1.getGenusSpecies()); Assert.assertEquals("1394", sp1.getLengthStepPmfmId()); Assert.assertFalse(sp1.isAgeEnabled()); Assert.assertTrue(sp1.isCalcifySampleEnabled()); @@ -164,7 +161,6 @@ Assert.assertEquals("2", sp2.getId()); Assert.assertEquals("3835", sp2.getSpeciesId()); Assert.assertEquals("CHIN", sp2.getCruiseCode()); - Assert.assertEquals("chinchard", sp2.getGenusSpecies()); Assert.assertEquals("323", sp2.getLengthStepPmfmId()); Assert.assertTrue(sp2.isAgeEnabled()); Assert.assertTrue(sp2.isCalcifySampleEnabled()); @@ -190,7 +186,6 @@ sp1.setId("1"); sp1.setSpeciesId("11242"); sp1.setCruiseCode("BAR"); - sp1.setGenusSpecies("bar"); sp1.setLengthStepPmfmId("1394"); sp1.setCalcifySampleEnabled(true); sp1.setMaturityEnabled(true); @@ -202,7 +197,6 @@ sp2.setId("2"); sp2.setSpeciesId("3835"); sp2.setCruiseCode("CHIN"); - sp2.setGenusSpecies("chinchard"); sp2.setLengthStepPmfmId("323"); sp2.setAgeEnabled(true); sp2.setCalcifySampleEnabled(true);

1 0

r324 - trunk/tutti-service/src/main/java/fr/ifremer/tutti/service
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 02:48:10 +0100 (Mon, 04 Feb 2013) New Revision: 324 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/324 Log: fix decorator Modified: trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java Modified: trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java =================================================================== --- trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java 2013-02-04 01:35:24 UTC (rev 323) +++ trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java 2013-02-04 01:48:10 UTC (rev 324) @@ -138,41 +138,9 @@ return bean == null ? "" : String.valueOf(bean); } }); - registerDecorator(new MultiJXPathDecorator<Vessel>(Vessel.class, "${name}$s#${internalRegistrationCode}$s", SEPARATOR, " - ") { + registerDecorator(new VesselMultiJXPathDecorator()); - private static final long serialVersionUID = 1L; - - @Override - protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { - Comparable result = super.getTokenValue(jxcontext, token); - if ("internalRegistrationCode".equals(token)) { - if (result == null || "null".equals(result)) { - result = _("tutti.propety.no.vessel.internalRegistrationCode"); - } - } else if ("name".equals(token)) { - if (result == null || "null".equals(result)) { - result = _("tutti.propety.no.vessel.name"); - } - } - return result; - } - }); - - registerDecorator(SPECIES_BY_CRUISE_CODE, new MultiJXPathDecorator<Species>(Species.class, "${cruiseCode}$s#${refTaxCode}$s#${name}$s", SEPARATOR, " - ") { - - private static final long serialVersionUID = 1L; - - @Override - protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { - Comparable result = super.getTokenValue(jxcontext, token); - if ("cruiseCode".equals(token)) { - if (result == null || "null".equals(result)) { - result = _("tutti.propety.no.species.cruiseCode"); - } - } - return result; - } - }); + registerDecorator(SPECIES_BY_CRUISE_CODE, new SpeciesMultiJXPathDecorator()); } }; } @@ -212,4 +180,57 @@ n_("tutti.property.caracteristic"); } + public static class SpeciesMultiJXPathDecorator extends MultiJXPathDecorator<Species> implements Cloneable { + + private static final long serialVersionUID = 1L; + + public SpeciesMultiJXPathDecorator() throws IllegalArgumentException, NullPointerException { + super(Species.class, "${cruiseCode}$s#${refTaxCode}$s#${name}$s", DecoratorService.SEPARATOR, " - "); + } + + @Override + protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { + Comparable result = super.getTokenValue(jxcontext, token); + if ("cruiseCode".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.species.cruiseCode"); + } + } + return result; + } + + @Override + public Object clone() throws CloneNotSupportedException { + return super.clone(); + } + } + + public static class VesselMultiJXPathDecorator extends MultiJXPathDecorator<Vessel> implements Cloneable { + + private static final long serialVersionUID = 1L; + + public VesselMultiJXPathDecorator() throws IllegalArgumentException, NullPointerException { + super(Vessel.class, "${name}$s#${internalRegistrationCode}$s", DecoratorService.SEPARATOR, " - "); + } + + @Override + protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { + Comparable result = super.getTokenValue(jxcontext, token); + if ("internalRegistrationCode".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.vessel.internalRegistrationCode"); + } + } else if ("name".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.vessel.name"); + } + } + return result; + } + + @Override + public Object clone() throws CloneNotSupportedException { + return super.clone(); + } + } }

1 0

r323 - in trunk: tutti-service/src/main/java/fr/ifremer/tutti/service tutti-service/src/main/resources/i18n tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/split
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 02:35:24 +0100 (Mon, 04 Feb 2013) New Revision: 323 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/323 Log: utilisation du cruiseCode (reste ?\195?\160 bien l'utiliser dans les combos) Modified: trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java trunk/tutti-service/src/main/resources/i18n/tutti-service_fr_FR.properties trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/split/CreateSpeciesBatchUIHandler.java Modified: trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java =================================================================== --- trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java 2013-02-04 01:30:03 UTC (rev 322) +++ trunk/tutti-service/src/main/java/fr/ifremer/tutti/service/DecoratorService.java 2013-02-04 01:35:24 UTC (rev 323) @@ -39,11 +39,14 @@ import fr.ifremer.tutti.persistence.entities.referential.Species; import fr.ifremer.tutti.persistence.entities.referential.Vessel; import fr.ifremer.tutti.persistence.entities.referential.Zone; +import org.apache.commons.jxpath.JXPathContext; import org.nuiton.util.decorator.Decorator; import org.nuiton.util.decorator.DecoratorProvider; +import org.nuiton.util.decorator.MultiJXPathDecorator; import java.io.Serializable; +import static org.nuiton.i18n.I18n._; import static org.nuiton.i18n.I18n.n_; /** @@ -64,7 +67,7 @@ String getLabel(); } - public static final String SPECIES_BY_CRUISE_CODE= "byCruiseCode"; + public static final String SPECIES_BY_CRUISE_CODE = "byCruiseCode"; public static final String SPECIES_BY_REF_TAX_CODE = "byRefTaxCode"; @@ -95,6 +98,10 @@ return decoratorProvider.getDecoratorByType(type, name); } + public static String getSpeciesContext(boolean protocolFilled) { + return protocolFilled ? SPECIES_BY_CRUISE_CODE : null; + } + @Override public void setServiceContext(TuttiServiceContext context) { super.setServiceContext(context); @@ -108,7 +115,7 @@ registerMultiJXPathDecorator(TuttiProtocol.class, "${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(FishingOperation.class, "${stationNumber}$s#${fishingOperationNumber}$s#${multirigAggregation}$s#${gearShootingStartDate}$td/%4$tm/%4$tY", SEPARATOR, " - "); registerMultiJXPathDecorator(Zone.class, "${label}$s#${name}$s", SEPARATOR, " - "); - registerMultiJXPathDecorator(Vessel.class, "${name}$s#${internalRegistrationCode}$s", SEPARATOR, " - "); +// registerMultiJXPathDecorator(Vessel.class, "${name}$s#${internalRegistrationCode}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Country.class, "${label}$s#${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Gear.class, "${label}$s#${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Person.class, "${firstName}$s#${lastName}$s#${department}$s", SEPARATOR, " "); @@ -117,7 +124,7 @@ registerMultiJXPathDecorator(Caracteristic.class, CARACTERISTIC_WITH_UNIT, "${parameterName}$s#${matrixName}$s#${fractionName}$s#${methodName}$s (${unit}$s)", SEPARATOR, " - "); registerMultiJXPathDecorator(CaracteristicQualitativeValue.class, "${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Species.class, "${refTaxCode}$s#${name}$s", SEPARATOR, " - "); - registerMultiJXPathDecorator(Species.class, SPECIES_BY_CRUISE_CODE, "${cruiseCode}$s#${refTaxCode}$s#${name}$s", SEPARATOR, " - "); +// registerMultiJXPathDecorator(Species.class, SPECIES_BY_CRUISE_CODE, "${cruiseCode}$s#${refTaxCode}$s#${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Species.class, SPECIES_BY_REF_TAX_CODE, "${refTaxCode}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(Species.class, SPECIES_BY_GENUS, "${name}$s", SEPARATOR, " - "); registerMultiJXPathDecorator(SpeciesProtocol.class, "${speciesId}", SEPARATOR, " - "); @@ -131,6 +138,41 @@ return bean == null ? "" : String.valueOf(bean); } }); + registerDecorator(new MultiJXPathDecorator<Vessel>(Vessel.class, "${name}$s#${internalRegistrationCode}$s", SEPARATOR, " - ") { + + private static final long serialVersionUID = 1L; + + @Override + protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { + Comparable result = super.getTokenValue(jxcontext, token); + if ("internalRegistrationCode".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.vessel.internalRegistrationCode"); + } + } else if ("name".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.vessel.name"); + } + } + return result; + } + }); + + registerDecorator(SPECIES_BY_CRUISE_CODE, new MultiJXPathDecorator<Species>(Species.class, "${cruiseCode}$s#${refTaxCode}$s#${name}$s", SEPARATOR, " - ") { + + private static final long serialVersionUID = 1L; + + @Override + protected Comparable<Comparable<?>> getTokenValue(JXPathContext jxcontext, String token) { + Comparable result = super.getTokenValue(jxcontext, token); + if ("cruiseCode".equals(token)) { + if (result == null || "null".equals(result)) { + result = _("tutti.propety.no.species.cruiseCode"); + } + } + return result; + } + }); } }; } Modified: trunk/tutti-service/src/main/resources/i18n/tutti-service_fr_FR.properties =================================================================== --- trunk/tutti-service/src/main/resources/i18n/tutti-service_fr_FR.properties 2013-02-04 01:30:03 UTC (rev 322) +++ trunk/tutti-service/src/main/resources/i18n/tutti-service_fr_FR.properties 2013-02-04 01:35:24 UTC (rev 323) @@ -38,4 +38,7 @@ tutti.property.user=Utilisateur tutti.property.vessel=Navire tutti.property.zone=Zone +tutti.propety.no.species.cruiseCode=\# +tutti.propety.no.vessel.internalRegistrationCode=Immatriculation inconnu +tutti.propety.no.vessel.name=Nom inconnu tutti.service.config=Configuration des services de Tutti Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java 2013-02-04 01:30:03 UTC (rev 322) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java 2013-02-04 01:35:24 UTC (rev 323) @@ -40,6 +40,7 @@ import fr.ifremer.tutti.persistence.entities.referential.Caracteristic; import fr.ifremer.tutti.persistence.entities.referential.CaracteristicQualitativeValue; import fr.ifremer.tutti.persistence.entities.referential.Species; +import fr.ifremer.tutti.service.DecoratorService; import fr.ifremer.tutti.ui.swing.TuttiUI; import fr.ifremer.tutti.ui.swing.content.operation.AbstractTuttiBatchTableUIHandler; import fr.ifremer.tutti.ui.swing.content.operation.catches.EditCatchesUI; @@ -455,7 +456,8 @@ HashMultimap.create(); - if (context.isProtocolFilled()) { + boolean protocolFilled = context.isProtocolFilled(); + if (protocolFilled) { // get loaded protocol @@ -537,7 +539,7 @@ addColumnToModel(columnModel, null, - newTableCellRender(Species.class), + newTableCellRender(Species.class, DecoratorService.getSpeciesContext(protocolFilled)), SpeciesBatchTableModel.SPECIES); } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/split/CreateSpeciesBatchUIHandler.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/split/CreateSpeciesBatchUIHandler.java 2013-02-04 01:30:03 UTC (rev 322) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/split/CreateSpeciesBatchUIHandler.java 2013-02-04 01:35:24 UTC (rev 323) @@ -30,6 +30,7 @@ import fr.ifremer.tutti.persistence.entities.referential.Caracteristic; import fr.ifremer.tutti.persistence.entities.referential.CaracteristicQualitativeValue; import fr.ifremer.tutti.persistence.entities.referential.Species; +import fr.ifremer.tutti.service.DecoratorService; import fr.ifremer.tutti.service.PersistenceService; import fr.ifremer.tutti.ui.swing.AbstractTuttiUIHandler; import fr.ifremer.tutti.ui.swing.TuttiUI; @@ -106,9 +107,12 @@ initUI(ui); + boolean protocolFilled = context.isProtocolFilled(); + initBeanComboBox(ui.getSpeciesComboBox(), Lists.<Species>newArrayList(), - null); + null, + DecoratorService.getSpeciesContext(protocolFilled)); Caracteristic caracteristic = persistenceService.getSortedUnsortedCaracteristic();

1 0

r322 - trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 02:30:03 +0100 (Mon, 04 Feb 2013) New Revision: 322 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/322 Log: add new init with decorator Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiUIHandler.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiUIHandler.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiUIHandler.java 2013-02-04 00:42:26 UTC (rev 321) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiUIHandler.java 2013-02-04 01:30:03 UTC (rev 322) @@ -291,13 +291,22 @@ List<E> data, E selectedData) { + initBeanComboBox(comboBox, data, selectedData, null); + } + + protected <E extends Serializable> void initBeanComboBox( + BeanComboBox<E> comboBox, + List<E> data, + E selectedData, + String decoratorContext) { + Preconditions.checkNotNull(comboBox, "No comboBox!"); Class<E> beanType = comboBox.getBeanType(); Preconditions.checkNotNull(beanType, "No beanType on the combobox!"); - Decorator<E> decorator = getDecorator(beanType, null); + Decorator<E> decorator = getDecorator(beanType, decoratorContext); if (data == null) { data = Lists.newArrayList();

1 0

r321 - in trunk: tutti-persistence/src/main/xmi tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol tutti-ui-swing/src/main/resources/i18n
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:42:26 +0100 (Mon, 04 Feb 2013) New Revision: 321 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/321 Log: refs #1817: [PROTOCOLE] - Import / Export du protocole (caracteristics + species are ok) refs #1824: [PROTOCOLE] - Gestion des param?\195?\168tres suivis par esp?\195?\168ces (add cruiseCode) Modified: trunk/tutti-persistence/src/main/xmi/tutti-persistence.zargo trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ExportProtocolAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ImportProtocolAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesRowModel.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesTableModel.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIHandler.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIModel.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportAllCaracteristicAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolCaracteristicAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolSpeciesAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolCaracteristicAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolSpeciesAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/SaveProtocolAction.java trunk/tutti-ui-swing/src/main/resources/i18n/tutti-ui-swing_fr_FR.properties Modified: trunk/tutti-persistence/src/main/xmi/tutti-persistence.zargo =================================================================== (Binary files differ) Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ExportProtocolAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ExportProtocolAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ExportProtocolAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -72,7 +72,7 @@ _("tutti.title.choose.protocolExportFile"), _("tutti.action.chooseProtocolFile"), null, - "^.*\\*.tuttiProtocol$", _("tutti.file.protocol") + "^.+\\.tuttiProtocol$", _("tutti.file.protocol") ); boolean doAction = file != null; Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ImportProtocolAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ImportProtocolAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/home/ImportProtocolAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -75,7 +75,7 @@ _("tutti.title.choose.protocolImportFile"), _("tutti.action.chooseProtocolFile"), null, - "^.*\\.tuttiProtocol$", _("tutti.file.protocol") + "^.+\\.tuttiProtocol$", _("tutti.file.protocol") ); boolean doAction = file != null; if (doAction) { Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesRowModel.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesRowModel.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesRowModel.java 2013-02-04 00:42:26 UTC (rev 321) @@ -39,7 +39,7 @@ private static final long serialVersionUID = 1L; - public static final String PROPERTY_SPECIES_CRUISE_CODE = "speciesCruiseCode"; + public static final String PROPERTY_CRUISE_CODE = "cruiseCode"; public static final String PROPERTY_SPECIES = "species"; @@ -61,7 +61,7 @@ protected Species species; - protected String speciesCruiseCode; + protected String cruiseCode; protected boolean sizeEnabled; @@ -105,14 +105,14 @@ firePropertyChange(PROPERTY_SPECIES, oldValue, species); } - public String getSpeciesCruiseCode() { - return speciesCruiseCode; + public String getCruiseCode() { + return cruiseCode; } - public void setSpeciesCruiseCode(String speciesCruiseCode) { - Object oldValue = getSpeciesCruiseCode(); - this.speciesCruiseCode = speciesCruiseCode; - firePropertyChange(PROPERTY_SPECIES_CRUISE_CODE, oldValue, speciesCruiseCode); + public void setCruiseCode(String cruiseCode) { + Object oldValue = getCruiseCode(); + this.cruiseCode = cruiseCode; + firePropertyChange(PROPERTY_CRUISE_CODE, oldValue, cruiseCode); } public boolean isSizeEnabled() { Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesTableModel.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesTableModel.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolSpeciesTableModel.java 2013-02-04 00:42:26 UTC (rev 321) @@ -40,47 +40,53 @@ public static final ColumnIdentifier<EditProtocolSpeciesRowModel> SPECIES_ID = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_SPECIES, n_("tutti.table.protocol.species.header.speciesId"), - n_("tutti.table.protocol.species.header.speciesId")); + n_("tutti.table.protocol.species.header.speciesId.tip")); + public static final ColumnIdentifier<EditProtocolSpeciesRowModel> CRUISE_CODE_ID = ColumnIdentifier.newId( + EditProtocolSpeciesRowModel.PROPERTY_CRUISE_CODE, + n_("tutti.table.protocol.species.header.cruiseCode"), + n_("tutti.table.protocol.species.header.cruiseCode.tip")); + + public static final ColumnIdentifier<EditProtocolSpeciesRowModel> SIZE_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_SIZE_ENABLED, n_("tutti.table.protocol.species.header.size"), - n_("tutti.table.protocol.species.header.size")); + n_("tutti.table.protocol.species.header.size.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> SEX_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_SEX_ENABLED, n_("tutti.table.protocol.species.header.sex"), - n_("tutti.table.protocol.species.header.sex")); + n_("tutti.table.protocol.species.header.sex.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> MATURITY_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_MATURITY_ENABLED, n_("tutti.table.protocol.species.header.maturity"), - n_("tutti.table.protocol.species.header.maturity")); + n_("tutti.table.protocol.species.header.maturity.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> AGE_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_AGE_ENABLED, n_("tutti.table.protocol.species.header.age"), - n_("tutti.table.protocol.species.header.age")); + n_("tutti.table.protocol.species.header.age.tip")); - public static final ColumnIdentifier<EditProtocolSpeciesRowModel> SIZE_FRENQUENCY_PMFM_ID = ColumnIdentifier.newId( + public static final ColumnIdentifier<EditProtocolSpeciesRowModel> LENGTH_STEP_PMFM_ID = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_LENGTH_STEP_PMFM, n_("tutti.table.protocol.species.header.lengthStep"), - n_("tutti.table.protocol.species.header.lengthStep")); + n_("tutti.table.protocol.species.header.lengthStep.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> WEIGHT_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_WEIGHT_ENABLED, n_("tutti.table.protocol.species.header.weight"), - n_("tutti.table.protocol.species.header.weight")); + n_("tutti.table.protocol.species.header.weight.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> COUNT_IF_NO_FREQUENCY_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_COUNT_IF_NO_FREQUENCY_ENABLED, n_("tutti.table.protocol.species.header.countIfNoFrequency"), - n_("tutti.table.protocol.species.header.countIfNoFrequency")); + n_("tutti.table.protocol.species.header.countIfNoFrequency.tip")); public static final ColumnIdentifier<EditProtocolSpeciesRowModel> CALCIFY_SAMPLE_ENABLED = ColumnIdentifier.newId( EditProtocolSpeciesRowModel.PROPERTY_CALCIFY_SAMPLE_ENABLED, n_("tutti.table.protocol.species.header.calcifySample"), - n_("tutti.table.protocol.species.header.calcifySample")); + n_("tutti.table.protocol.species.header.calcifySample.tip")); private static final long serialVersionUID = 1L; Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIHandler.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIHandler.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIHandler.java 2013-02-04 00:42:26 UTC (rev 321) @@ -38,16 +38,27 @@ import fr.ifremer.tutti.ui.swing.content.home.ImportProtocolAction; import fr.ifremer.tutti.ui.swing.util.TuttiBeanMonitor; import fr.ifremer.tutti.ui.swing.util.table.AbstractTuttiTableUIHandler; +import fr.ifremer.tutti.ui.swing.util.table.ColumnIdentifier; +import jaxx.runtime.SwingUtil; import jaxx.runtime.swing.editor.bean.BeanDoubleList; +import jaxx.runtime.swing.editor.bean.BeanDoubleListModel; +import jaxx.runtime.swing.editor.bean.BeanUIUtil; import jaxx.runtime.validator.swing.SwingValidator; import org.apache.commons.collections.CollectionUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.jdesktop.swingx.JXTable; +import org.jdesktop.swingx.autocomplete.ComboBoxCellEditor; +import org.jdesktop.swingx.autocomplete.ObjectToStringConverter; import org.jdesktop.swingx.table.DefaultTableColumnModelExt; +import org.nuiton.util.decorator.Decorator; +import javax.swing.JComboBox; import javax.swing.JOptionPane; +import javax.swing.table.TableColumnModel; import java.awt.event.ActionEvent; +import java.beans.PropertyChangeEvent; +import java.beans.PropertyChangeListener; import java.util.List; import java.util.Map; @@ -71,9 +82,9 @@ protected Map<String, Species> allSpecies; - protected Map<String, Caracteristic> allLengthStepPmfm; + protected List<Caracteristic> caracteristics; - protected List<Caracteristic> allCaracteristic; + protected Map<String, Caracteristic> allCaracteristic; // protected Multimap<String, String> hydroCaracteristics; @@ -162,20 +173,16 @@ listModelIsModify(model); ui.setContextValue(model); - allSpecies = TuttiEntities.splitById( - persistenceService.getAllSpecies()); + allSpecies = TuttiEntities.splitById(persistenceService.getAllSpecies()); List<String> protocolNames = persistenceService.getAllProtocolNames(); model.setProtocolNames(protocolNames); - allLengthStepPmfm = TuttiEntities.splitById( - persistenceService.getAllCaracteristic()); - - allCaracteristic = persistenceService.getAllCaracteristic(); - + caracteristics = persistenceService.getAllCaracteristic(); + allCaracteristic = TuttiEntities.splitById(caracteristics); } - public List<Caracteristic> getAllCaracteristic() { + public Map<String, Caracteristic> getAllCaracteristic() { return allCaracteristic; } @@ -183,10 +190,6 @@ return allSpecies; } - public Map<String, Caracteristic> getAllLengthStepPmfm() { - return allLengthStepPmfm; - } - @Override public void afterInitUI() { @@ -256,11 +259,13 @@ newTableCellRender(Species.class), EditProtocolSpeciesTableModel.SPECIES_ID); - addComboDataColumnToModel(columnModel, - EditProtocolSpeciesTableModel.SIZE_FRENQUENCY_PMFM_ID, - getDecorator(Caracteristic.class, null), - Lists.newArrayList(allLengthStepPmfm.values())); + addColumnToModel(columnModel, + null, + null, + EditProtocolSpeciesTableModel.CRUISE_CODE_ID); + addLengthClassesColumnToModel(columnModel, model.getLengthClassesPmfmId()); + addBooleanColumnToModel(columnModel, EditProtocolSpeciesTableModel.WEIGHT_ENABLED, table); addBooleanColumnToModel(columnModel, EditProtocolSpeciesTableModel.COUNT_IF_NO_FREQUENCY_ENABLED, table); addBooleanColumnToModel(columnModel, EditProtocolSpeciesTableModel.CALCIFY_SAMPLE_ENABLED, table); @@ -279,22 +284,15 @@ List<Species> speciesList = Lists.newArrayList(allSpecies.values()); - List<EditProtocolSpeciesRowModel> rows = Lists.newArrayList(); + List<EditProtocolSpeciesRowModel> rows; // build speciesProtocol rows - if (protocol != null) { - List<SpeciesProtocol> speciesProtocols = protocol.getSpecies(); - if (CollectionUtils.isNotEmpty(speciesProtocols)) { - for (SpeciesProtocol speciesProtocol : speciesProtocols) { - Species species = allSpecies.get(speciesProtocol.getSpeciesId()); - speciesList.remove(species); - EditProtocolSpeciesRowModel row = tableModel.createNewRow(); - row.setSpecies(species); - row.setLengthStepPmfm(allLengthStepPmfm.get(speciesProtocol.getLengthStepPmfmId())); - row.fromBean(speciesProtocol); - rows.add(row); - } - } + if (protocol == null) { + rows = Lists.newArrayList(); + } else { + + rows = toRows(speciesList, protocol.getSpecies()); + if (log.isDebugEnabled()) { log.debug("Will edit protocol with " + rows.size() + " species declared."); @@ -307,26 +305,57 @@ initBeanComboBox(ui.getSpeciesComboBox(), speciesList, null); selectFirstInCombo(ui.getSpeciesComboBox()); - initDoubleList(ui.getLengthClassesList(), - Lists.newArrayList(allCaracteristic), + initDoubleList(EditProtocolUIModel.PROPERTY_LENGTH_CLASSES_PMFM_ID, + ui.getLengthClassesList(), + Lists.newArrayList(caracteristics), model.getLengthClassesPmfmId()); - initDoubleList(ui.getGearList(), - Lists.newArrayList(allCaracteristic), + initDoubleList(EditProtocolUIModel.PROPERTY_GEAR_PMFM_ID, + ui.getGearList(), + Lists.newArrayList(caracteristics), model.getGearPmfmId()); - initDoubleList(ui.getEnvironmentList(), - Lists.newArrayList(allCaracteristic), + initDoubleList(EditProtocolUIModel.PROPERTY_ENVIRONMENT_PMFM_ID, + ui.getEnvironmentList(), + Lists.newArrayList(caracteristics), model.getEnvironmentPmfmId()); - initDoubleList(ui.getHydrologyList(), - Lists.newArrayList(allCaracteristic), + initDoubleList(EditProtocolUIModel.PROPERTY_HYDROLOGY_PMFM_ID, + ui.getHydrologyList(), + Lists.newArrayList(caracteristics), model.getHydrologyPmfmId()); // if new protocol can already cancel his creation model.setModify(model.isCreate()); } + public List<EditProtocolSpeciesRowModel> toRows(List<Species> speciesList, + List<SpeciesProtocol> speciesProtocols) { + + boolean useComboData = speciesList == null; + + if (useComboData) { + speciesList = ui.getSpeciesComboBox().getData(); + } + List<EditProtocolSpeciesRowModel> result = Lists.newArrayList(); + if (CollectionUtils.isNotEmpty(speciesProtocols)) { + for (SpeciesProtocol speciesProtocol : speciesProtocols) { + Species species = allSpecies.get(speciesProtocol.getSpeciesId()); + speciesList.remove(species); + EditProtocolSpeciesRowModel row = getTableModel().createNewRow(); + row.setSpecies(species); + row.setLengthStepPmfm(allCaracteristic.get(speciesProtocol.getLengthStepPmfmId())); + row.fromBean(speciesProtocol); + result.add(row); + } + } + + if (useComboData) { + selectFirstInCombo(ui.getSpeciesComboBox()); + } + return result; + } + @Override public void onCloseUI() { if (log.isInfoEnabled()) { @@ -369,7 +398,7 @@ EditProtocolSpeciesRowModel protocol = getTableModel().createNewRow(); protocol.setSpecies(species); getTableModel().addNewRow(protocol); - ui.getSpeciesComboBox().removeItem(species); + ui.getSpeciesComboBox().getData().remove(species); selectFirstInCombo(ui.getSpeciesComboBox()); getModel().setModify(true); @@ -389,21 +418,162 @@ getTableModel().fireTableRowsDeleted(rowIndex, rowIndex); } + public void addDoubleListListeners() { + String id; + UpdateSelectedList updateListener; + EditProtocolUIModel model = getModel(); + + id = (String) ui.getLengthClassesList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getLengthClassesList().getClientProperty("_updateListener"); + model.addPropertyChangeListener(id, updateListener); + + id = (String) ui.getEnvironmentList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getEnvironmentList().getClientProperty("_updateListener"); + model.addPropertyChangeListener(id, updateListener); + + id = (String) ui.getGearList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getGearList().getClientProperty("_updateListener"); + model.addPropertyChangeListener(id, updateListener); + + id = (String) ui.getHydrologyList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getHydrologyList().getClientProperty("_updateListener"); + model.addPropertyChangeListener(id, updateListener); + } + + public void removeDoubleListListeners() { + String id; + UpdateSelectedList updateListener; + EditProtocolUIModel model = getModel(); + + id = (String) ui.getLengthClassesList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getLengthClassesList().getClientProperty("_updateListener"); + + model.removePropertyChangeListener(id, updateListener); + + id = (String) ui.getEnvironmentList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getEnvironmentList().getClientProperty("_updateListener"); + model.removePropertyChangeListener(id, updateListener); + + id = (String) ui.getGearList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getGearList().getClientProperty("_updateListener"); + model.removePropertyChangeListener(id, updateListener); + + id = (String) ui.getHydrologyList().getClientProperty("_updateListenerId"); + updateListener = (UpdateSelectedList) ui.getHydrologyList().getClientProperty("_updateListener"); + model.removePropertyChangeListener(id, updateListener); + } + //------------------------------------------------------------------------// //-- Internal methods --// //------------------------------------------------------------------------// - protected void initDoubleList(BeanDoubleList<Caracteristic> widget, + protected void initDoubleList(String propertyId, + BeanDoubleList<Caracteristic> widget, List<Caracteristic> availableCaracteristics, List<String> selectedCaracteristics) { + + initBeanList(widget, availableCaracteristics, + Lists.<Caracteristic>newArrayList()); + + UpdateSelectedList listener = new UpdateSelectedList(widget, allCaracteristic); + widget.putClientProperty("_updateListener", listener); + widget.putClientProperty("_updateListenerId", propertyId); + listener.select(selectedCaracteristics); + } + + protected void selectLengthClasses(List<String> ids, JComboBox comboBox) { + List<Caracteristic> selection = Lists.newArrayList(); - if (selectedCaracteristics != null) { - for (Caracteristic caracteristic : availableCaracteristics) { - if (selectedCaracteristics.contains(caracteristic.getId())) { - selection.add(caracteristic); + if (CollectionUtils.isNotEmpty(ids)) { + for (String id : ids) { + selection.add(allCaracteristic.get(id)); + } + } + + List<Caracteristic> dataToList = Lists.newArrayList(selection); + + // add a null value at first position + if (!dataToList.isEmpty() && dataToList.get(0) != null) { + dataToList.add(0, null); + } + SwingUtil.fillComboBox(comboBox, dataToList, null); + } + + protected void addLengthClassesColumnToModel(TableColumnModel model, List<String> selectedIds) { + + ColumnIdentifier<EditProtocolSpeciesRowModel> identifier = + EditProtocolSpeciesTableModel.LENGTH_STEP_PMFM_ID; + + Decorator<Caracteristic> decorator = + getDecorator(Caracteristic.class, null); + + final JComboBox comboBox = new JComboBox(); + + getModel().addPropertyChangeListener(EditProtocolUIModel.PROPERTY_LENGTH_CLASSES_PMFM_ID, new PropertyChangeListener() { + @Override + public void propertyChange(PropertyChangeEvent evt) { + List<String> ids = (List<String>) evt.getNewValue(); + selectLengthClasses(ids, comboBox); + } + }); + comboBox.setRenderer(newListCellRender(decorator)); + + selectLengthClasses(selectedIds, comboBox); + ObjectToStringConverter converter = BeanUIUtil.newDecoratedObjectToStringConverter(decorator); + BeanUIUtil.decorate(comboBox, converter); + ComboBoxCellEditor editor = new ComboBoxCellEditor(comboBox); + + + addColumnToModel(model, + editor, + newTableCellRender(decorator), + EditProtocolSpeciesTableModel.LENGTH_STEP_PMFM_ID); + } + + protected static class UpdateSelectedList implements PropertyChangeListener { + + private final BeanDoubleListModel<Caracteristic> model; + + private final Map<String, Caracteristic> caracteristicMap; + + public UpdateSelectedList(BeanDoubleList<Caracteristic> doubleList, + Map<String, Caracteristic> caracteristicMap) { + this.model = doubleList.getModel(); + this.caracteristicMap = caracteristicMap; + } + + private boolean valueIsAdjusting; + + @Override + public void propertyChange(PropertyChangeEvent evt) { + + if (!valueIsAdjusting) { + + valueIsAdjusting = true; + + try { + List<String> selectedIds = (List<String>) evt.getNewValue(); + if (log.isInfoEnabled()) { + log.info("[" + evt.getPropertyName() + "] selected ids: " + selectedIds); + } + + select(selectedIds); + } finally { + valueIsAdjusting = false; } } + } - initBeanList(widget, availableCaracteristics, selection); + + public void select(List<String> selectedIds) { + + List<Caracteristic> selection = Lists.newArrayList(); + if (CollectionUtils.isNotEmpty(selectedIds)) { + for (String selectedId : selectedIds) { + selection.add(caracteristicMap.get(selectedId)); + } + } + model.setSelected(selection); + } } } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIModel.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIModel.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/EditProtocolUIModel.java 2013-02-04 00:42:26 UTC (rev 321) @@ -116,9 +116,9 @@ } public void setLengthClassesPmfmId(List<String> lengthClassesPmfmId) { - Object oldValue = getLengthClassesPmfmId(); this.lengthClassesPmfmId = lengthClassesPmfmId; - firePropertyChange(PROPERTY_LENGTH_CLASSES_PMFM_ID, oldValue, lengthClassesPmfmId); + // force to always propagates (need to recompte data of combobox in species table) + firePropertyChange(PROPERTY_LENGTH_CLASSES_PMFM_ID, null, lengthClassesPmfmId); } public void setLengthClassesPmfm(List<Caracteristic> lengthClassesPmfm) { Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportAllCaracteristicAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportAllCaracteristicAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportAllCaracteristicAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -24,8 +24,6 @@ * #L% */ -import fr.ifremer.tutti.persistence.entities.TuttiEntities; -import fr.ifremer.tutti.persistence.entities.referential.Caracteristic; import fr.ifremer.tutti.service.protocol.TuttiProtocolImportExportService; import fr.ifremer.tutti.ui.swing.AbstractTuttiAction; import fr.ifremer.tutti.ui.swing.util.TuttiUIUtil; @@ -34,8 +32,6 @@ import java.awt.event.ActionEvent; import java.io.File; -import java.util.List; -import java.util.Map; import static org.nuiton.i18n.I18n._; @@ -100,11 +96,10 @@ TuttiProtocolImportExportService service = getContext().getService(TuttiProtocolImportExportService.class); - List<Caracteristic> allCaracteristic = getHandler().getAllCaracteristic(); - Map<String, Caracteristic> caracteristicMap = TuttiEntities.splitById(allCaracteristic); + service.exportAllCaracteristic(file, + getHandler().getAllCaracteristic()); - service.exportAllCaracteristic(file, caracteristicMap); - - sendMessage("Caractéristiques exportées dans le fichier."); + sendMessage("Toutes les caractéristiques exportées dans le fichier " + + file + "."); } } \ No newline at end of file Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolCaracteristicAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolCaracteristicAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolCaracteristicAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -24,9 +24,7 @@ * #L% */ -import fr.ifremer.tutti.persistence.entities.TuttiEntities; import fr.ifremer.tutti.persistence.entities.protocol.TuttiProtocol; -import fr.ifremer.tutti.persistence.entities.referential.Caracteristic; import fr.ifremer.tutti.service.protocol.TuttiProtocolImportExportService; import fr.ifremer.tutti.ui.swing.AbstractTuttiAction; import fr.ifremer.tutti.ui.swing.util.TuttiUIUtil; @@ -35,8 +33,6 @@ import java.awt.event.ActionEvent; import java.io.File; -import java.util.List; -import java.util.Map; import static org.nuiton.i18n.I18n._; @@ -104,11 +100,11 @@ TuttiProtocolImportExportService service = getContext().getService(TuttiProtocolImportExportService.class); - List<Caracteristic> allCaracteristic = getHandler().getAllCaracteristic(); - Map<String, Caracteristic> caracteristicMap = TuttiEntities.splitById(allCaracteristic); + service.exportProtocolCaracteristic(file, + protocol, + getHandler().getAllCaracteristic()); - service.exportProtocolCaracteristic(file, protocol, caracteristicMap); - - sendMessage("Caractéristiques du Protocole [" + protocol.getName() + "] exportées dans le fichier."); + sendMessage("Caractéristiques du Protocole exportées dans le fichier " + + file + "."); } } \ No newline at end of file Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolSpeciesAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolSpeciesAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ExportProtocolSpeciesAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -24,6 +24,8 @@ * #L% */ +import com.google.common.collect.Lists; +import fr.ifremer.tutti.persistence.entities.protocol.SpeciesProtocol; import fr.ifremer.tutti.persistence.entities.protocol.TuttiProtocol; import fr.ifremer.tutti.service.protocol.TuttiProtocolImportExportService; import fr.ifremer.tutti.ui.swing.AbstractTuttiAction; @@ -33,6 +35,7 @@ import java.awt.event.ActionEvent; import java.io.File; +import java.util.List; import static org.nuiton.i18n.I18n._; @@ -96,14 +99,21 @@ // bind to a protocol TuttiProtocol protocol = getModel().toBean(); + List<SpeciesProtocol> protocols = Lists.newArrayList(); + for (EditProtocolSpeciesRowModel row : getModel().getRows()) { + if (row.isValid()) { + protocols.add(row.toBean()); + } + } + // import TuttiProtocolImportExportService service = getContext().getService(TuttiProtocolImportExportService.class); service.exportProtocolSpecies(file, - protocol, - getHandler().getAllLengthStepPmfm(), + protocols, + getHandler().getAllCaracteristic(), getHandler().getAllSpecies()); sendMessage("Espèces du Protocole exportés dans le fichier " + file + "."); Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolCaracteristicAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolCaracteristicAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolCaracteristicAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -24,9 +24,7 @@ * #L% */ -import fr.ifremer.tutti.persistence.entities.TuttiEntities; import fr.ifremer.tutti.persistence.entities.protocol.TuttiProtocol; -import fr.ifremer.tutti.persistence.entities.referential.Caracteristic; import fr.ifremer.tutti.service.protocol.TuttiProtocolImportExportService; import fr.ifremer.tutti.ui.swing.AbstractTuttiAction; import fr.ifremer.tutti.ui.swing.util.TuttiUIUtil; @@ -35,8 +33,6 @@ import java.awt.event.ActionEvent; import java.io.File; -import java.util.List; -import java.util.Map; import static org.nuiton.i18n.I18n._; @@ -97,21 +93,27 @@ log.info("Will import protocol caracteristic file: " + file); } + EditProtocolUIModel model = getModel(); + // bind to a protocol - TuttiProtocol protocol = getModel().toBean(); + TuttiProtocol protocol = model.toBean(); - // import protocol caracteristics TuttiProtocolImportExportService service = getContext().getService(TuttiProtocolImportExportService.class); - List<Caracteristic> allCaracteristic = getHandler().getAllCaracteristic(); - Map<String, Caracteristic> caracteristicMap = TuttiEntities.splitById(allCaracteristic); + service.importProtocolCaracteristic(file, + protocol, + getHandler().getAllCaracteristic()); - service.importProtocolCaracteristic(file, protocol, caracteristicMap); + getHandler().addDoubleListListeners(); - // rebind to model - getModel().fromBean(protocol); + try { + // rebind to model + model.fromBean(protocol); + } finally { + getHandler().removeDoubleListListeners(); + } - sendMessage("Caractéristiques importées depuis le fichier "); + sendMessage("Caractéristiques importées depuis le fichier " + file); } } \ No newline at end of file Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolSpeciesAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolSpeciesAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/ImportProtocolSpeciesAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -33,6 +33,7 @@ import java.awt.event.ActionEvent; import java.io.File; +import java.util.List; import static org.nuiton.i18n.I18n._; @@ -58,7 +59,7 @@ "import", _("tutti.action.importProtocolSpecies"), _("tutti.action.importProtocolSpecies.tip"), - true + false ); } @@ -93,8 +94,10 @@ log.info("Will import protocol species file: " + file); } + EditProtocolUIModel model = getModel(); + // bind to a protocol - TuttiProtocol protocol = getModel().toBean(); + TuttiProtocol protocol = model.toBean(); // import TuttiProtocolImportExportService service = @@ -102,11 +105,12 @@ service.importProtocolSpecies(file, protocol, - getHandler().getAllLengthStepPmfm(), + getHandler().getAllCaracteristic(), getHandler().getAllSpecies()); - // rebind to model - getModel().fromBean(protocol); + List<EditProtocolSpeciesRowModel> rows = + getHandler().toRows(null, protocol.getSpecies()); + model.setRows(rows); sendMessage("Espèces importées depuis le fichier " + file + "."); } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/SaveProtocolAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/SaveProtocolAction.java 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/protocol/SaveProtocolAction.java 2013-02-04 00:42:26 UTC (rev 321) @@ -91,8 +91,12 @@ } bean.setSpecies(protocols); + if (log.isDebugEnabled()) { + log.debug("protocol id to save: " + bean.getId()); + } + TuttiProtocol saved; - log.info("bean id : " + bean.getId()); + if (TuttiEntities.isNew(bean)) { saved = persistenceService.createProtocol(bean); Modified: trunk/tutti-ui-swing/src/main/resources/i18n/tutti-ui-swing_fr_FR.properties =================================================================== --- trunk/tutti-ui-swing/src/main/resources/i18n/tutti-ui-swing_fr_FR.properties 2013-02-04 00:40:32 UTC (rev 320) +++ trunk/tutti-ui-swing/src/main/resources/i18n/tutti-ui-swing_fr_FR.properties 2013-02-04 00:42:26 UTC (rev 321) @@ -315,14 +315,25 @@ tutti.table.plankton.batch.header.toConfirm=A Confirmer tutti.table.plankton.batch.header.weight=Poids tutti.table.protocol.species.header.age=Age +tutti.table.protocol.species.header.age.tip=Catégorisation sur l'age ? tutti.table.protocol.species.header.calcifySample=Prélèvement de pièces calcifiées +tutti.table.protocol.species.header.calcifySample.tip=Prélèvement de pièces calcifiées tutti.table.protocol.species.header.countIfNoFrequency=Dénombrement +tutti.table.protocol.species.header.countIfNoFrequency.tip=Dénombrement +tutti.table.protocol.species.header.cruiseCode=Code +tutti.table.protocol.species.header.cruiseCode.tip=Code campagne (non synchronisable) tutti.table.protocol.species.header.lengthStep=Classe de Taille +tutti.table.protocol.species.header.lengthStep.tip=Comment mesurer les classes de taille (si vide alors pas de mesure) tutti.table.protocol.species.header.maturity=Maturité +tutti.table.protocol.species.header.maturity.tip=Catégorisation sur la maturité ? tutti.table.protocol.species.header.sex=Sexe +tutti.table.protocol.species.header.sex.tip=Catégorisation sur le sexe ? tutti.table.protocol.species.header.size=Catégorie Tri +tutti.table.protocol.species.header.size.tip=Catégorisation sur la catégorie de tri ? tutti.table.protocol.species.header.speciesId=Espèce +tutti.table.protocol.species.header.speciesId.tip=Espèce (code permanent - nom scientifique) tutti.table.protocol.species.header.weight=Pesée +tutti.table.protocol.species.header.weight.tip=Pesée tutti.table.species.batch.header.ageCategory=Age tutti.table.species.batch.header.comment=Commentaire tutti.table.species.batch.header.computedNumber=Nombre @@ -344,12 +355,12 @@ tutti.table.species.sampleCategory.header.weight=Poids (kg) tutti.timeeditor.H=H tutti.title.about=À propos de Tutti -tutti.title.choose.protocolCaracteristicExportFile=Choisir le fichier où exporter les caractéristiques -tutti.title.choose.protocolCaracteristicImportFile=Choisir le fichier des caractéristiques à importer -tutti.title.choose.protocolExportFile=Choisir le fichier où exporter le protocole -tutti.title.choose.protocolImportFile=Choisir le fichier du protocole à importer -tutti.title.choose.protocolSpeciesExportFile=Choisir le fichier où expoerter les espèces de protocole -tutti.title.choose.protocolSpeciesImportFile=Choisir le fichier des espèces de protocole à importer +tutti.title.choose.protocolCaracteristicExportFile=Exporter les caractéristiques +tutti.title.choose.protocolCaracteristicImportFile=Importer les caractéristiques +tutti.title.choose.protocolExportFile=Exporter le protocole +tutti.title.choose.protocolImportFile=Importer le protocole +tutti.title.choose.protocolSpeciesExportFile=Exporter les espèces +tutti.title.choose.protocolSpeciesImportFile=Importer les espèces tutti.title.create.cruise=Créer une nouvelle campagne tutti.title.create.program=Créer une nouvelle série de campagne tutti.title.create.protocol=Créer un nouveau protocol de saisie

1 0

r320 - trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:40:32 +0100 (Mon, 04 Feb 2013) New Revision: 320 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/320 Log: use protocol in Species screen (for lengthClass + species) Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java 2013-02-04 00:39:54 UTC (rev 319) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/catches/species/SpeciesBatchUIHandler.java 2013-02-04 00:40:32 UTC (rev 320) @@ -425,7 +425,8 @@ } else { // use all caracteristics - lengthCaracterics = Lists.newArrayList(persistenceService.getAllCaracteristic()); + lengthCaracterics = Lists.newArrayList( + persistenceService.getAllCaracteristic()); } List<Species> speciesList = persistenceService.getAllSpecies(protocol); @@ -450,46 +451,20 @@ List<Species> allSpecies; - TuttiProtocol protocol = null; + Multimap<Species, SampleCategoryType> speciesSampleCategories = + HashMultimap.create(); + if (context.isProtocolFilled()) { // get loaded protocol - protocol = TuttiUIUtil.getProtocol(ui); + TuttiProtocol protocol = TuttiUIUtil.getProtocol(ui); Preconditions.checkNotNull(protocol, "Could not find protocol in ui context"); - } - Multimap<Species, SampleCategoryType> speciesSampleCategories = - HashMultimap.create(); - - if (protocol == null) { - - // no protocol, use default values - - samplingOrder = Lists.newArrayList( - SampleCategoryType.sortedUnsorted, - SampleCategoryType.size, - SampleCategoryType.sex, - SampleCategoryType.maturity, - SampleCategoryType.age); - - allSpecies = Lists.newArrayList(speciesUniverse); - - // each species can use any category - for (Species species : allSpecies) { - speciesSampleCategories.put(species, SampleCategoryType.sortedUnsorted); - speciesSampleCategories.put(species, SampleCategoryType.size); - speciesSampleCategories.put(species, SampleCategoryType.sex); - speciesSampleCategories.put(species, SampleCategoryType.maturity); - speciesSampleCategories.put(species, SampleCategoryType.age); - } - } else { - // fill sampling order from protocol - samplingOrder = Lists.newArrayList( SampleCategoryType.sortedUnsorted, SampleCategoryType.size, @@ -512,6 +487,27 @@ speciesSampleCategories.put(species, SampleCategoryType.age); } } + } else { + + // no protocol, use default values + + samplingOrder = Lists.newArrayList( + SampleCategoryType.sortedUnsorted, + SampleCategoryType.size, + SampleCategoryType.sex, + SampleCategoryType.maturity, + SampleCategoryType.age); + + allSpecies = Lists.newArrayList(speciesUniverse); + + // each species can use any category + for (Species species : allSpecies) { + speciesSampleCategories.put(species, SampleCategoryType.sortedUnsorted); + speciesSampleCategories.put(species, SampleCategoryType.size); + speciesSampleCategories.put(species, SampleCategoryType.sex); + speciesSampleCategories.put(species, SampleCategoryType.maturity); + speciesSampleCategories.put(species, SampleCategoryType.age); + } } if (log.isInfoEnabled()) {

1 0

r319 - trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:39:54 +0100 (Mon, 04 Feb 2013) New Revision: 319 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/319 Log: improve log (do not log sets with a lot of data + prevent their usage by a if (log.isXXX) Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableModel.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableUIModel.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableModel.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableModel.java 2013-02-04 00:39:02 UTC (rev 318) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableModel.java 2013-02-04 00:39:54 UTC (rev 319) @@ -227,7 +227,9 @@ @Override public final void setValueAt(Object aValue, int rowIndex, int columnIndex) { - log.info("setValueAt " + aValue); + if (log.isDebugEnabled()) { + log.debug("setValueAt " + aValue); + } R entry = getEntry(rowIndex); ColumnIdentifier<R> propertyName = getPropertyName(columnIndex); setValueAt(aValue, rowIndex, columnIndex, propertyName, entry); @@ -253,7 +255,9 @@ int columnIndex, ColumnIdentifier<R> propertyName, R entry) { - log.info("setValueAt " + aValue); + if (log.isDebugEnabled()) { + log.debug("setValueAt " + aValue); + } propertyName.setValue(entry, aValue); } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableUIModel.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableUIModel.java 2013-02-04 00:39:02 UTC (rev 318) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/util/table/AbstractTuttiTableUIModel.java 2013-02-04 00:39:54 UTC (rev 319) @@ -28,13 +28,13 @@ import com.google.common.collect.Sets; import fr.ifremer.tutti.ui.swing.AbstractTuttiBeanUIModel; import fr.ifremer.tutti.ui.swing.content.operation.fishing.environment.EnvironmentRowModel; +import org.apache.commons.collections.CollectionUtils; import org.apache.commons.logging.Log; import org.apache.commons.logging.LogFactory; import org.nuiton.util.beans.Binder; import java.beans.PropertyChangeEvent; import java.beans.PropertyChangeListener; -import java.util.HashSet; import java.util.List; import java.util.Set; @@ -68,11 +68,13 @@ @Override public void propertyChange(PropertyChangeEvent evt) { Set<EnvironmentRowModel> rowsInErorr = (Set<EnvironmentRowModel>) evt.getNewValue(); - log.info(PROPERTY_ROWS_IN_ERROR + " changed " + rowsInErorr); - setValid(rowsInErorr == null || rowsInErorr.isEmpty()); + if (log.isDebugEnabled()) { + log.debug(PROPERTY_ROWS_IN_ERROR + " changed " + rowsInErorr.size()); + } + setValid(CollectionUtils.isEmpty(rowsInErorr)); } }); - setRowsInError(new HashSet<R>()); + setRowsInError(Sets.<R>newHashSet()); } public List<R> getRows() { @@ -88,7 +90,7 @@ // always propagates (since empty list will not fire and we want it) firePropertyChange(PROPERTY_ROWS, null, rows); - Set<R> rowsInError = Sets.newHashSet(); + rowsInError.clear(); for (R row : rows) { if (!row.isValid()) { rowsInError.add(row);

1 0

r318 - in trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing: . config
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:39:02 +0100 (Mon, 04 Feb 2013) New Revision: 318 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/318 Log: reload i18n execpt when using full mode launch + improve configuration code Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/RunTutti.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/TuttiUIContext.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/config/TuttiApplicationConfig.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/RunTutti.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/RunTutti.java 2013-02-04 00:37:59 UTC (rev 317) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/RunTutti.java 2013-02-04 00:39:02 UTC (rev 318) @@ -59,10 +59,8 @@ // prepare context (mainly init configs, i18n) context.init(); - String launchMode = config.getTuttiLaunchMode(); + if (config.isFullLaunchMode()) { - if ("full".equals(launchMode)) { - if (log.isInfoEnabled()) { log.info("Full launch mode, try to update jre / application."); } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/TuttiUIContext.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/TuttiUIContext.java 2013-02-04 00:37:59 UTC (rev 317) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/TuttiUIContext.java 2013-02-04 00:39:02 UTC (rev 318) @@ -35,6 +35,7 @@ import fr.ifremer.tutti.service.TuttiServiceContext; import fr.ifremer.tutti.ui.swing.config.TuttiApplicationConfig; import fr.ifremer.tutti.ui.swing.util.UIMessageNotifier; +import org.apache.commons.io.FileUtils; import org.apache.commons.io.IOUtils; import org.apache.commons.lang3.StringUtils; import org.apache.commons.logging.Log; @@ -312,11 +313,20 @@ config.getServiceConfig().getPersistenceConfig().initConfig(getResourceLoader()); } catch (IOException e) { - throw new RuntimeException("Could not init adagio configuration", e); + throw new RuntimeException("Could not init persistence configuration", e); } // Initialize i18n File i18nDirectory = config.getI18nDirectory(); + if (!config.isFullLaunchMode()) { + + // clean i18n cache + try { + FileUtils.cleanDirectory(i18nDirectory); + } catch (IOException e) { + throw new RuntimeException("Could not delete i18n cache at " + i18nDirectory, e); + } + } Locale i18nLocale = config.getI18nLocale(); if (log.isInfoEnabled()) { Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/config/TuttiApplicationConfig.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/config/TuttiApplicationConfig.java 2013-02-04 00:37:59 UTC (rev 317) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/config/TuttiApplicationConfig.java 2013-02-04 00:39:02 UTC (rev 318) @@ -148,6 +148,10 @@ return ReflectionToStringBuilder.toString(this); } + public boolean isFullLaunchMode() { + return "full".equals(getTuttiLaunchMode()); + } + public String getTuttiLaunchMode() { return applicationConfig.getOption(TuttiApplicationConfigOption.TUTTI_LAUNCH_MODE.getKey()); }

1 0

r317 - trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:37:59 +0100 (Mon, 04 Feb 2013) New Revision: 317 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/317 Log: do not show body when saving or cancel editing fishingoperation Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/CancelEditFishingOperationAction.java trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/SaveFishingOperationAction.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/CancelEditFishingOperationAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/CancelEditFishingOperationAction.java 2013-02-04 00:37:29 UTC (rev 316) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/CancelEditFishingOperationAction.java 2013-02-04 00:37:59 UTC (rev 317) @@ -52,7 +52,7 @@ "cancel", _("tutti.action.cancel.editFishingOperation"), _("tutti.action.cancel.editFishingOperation.tip"), - false + true ); } Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/SaveFishingOperationAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/SaveFishingOperationAction.java 2013-02-04 00:37:29 UTC (rev 316) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/content/operation/SaveFishingOperationAction.java 2013-02-04 00:37:59 UTC (rev 317) @@ -61,7 +61,7 @@ "save", _("tutti.action.saveFishingOperation"), _("tutti.action.saveFishingOperation.tip"), - false + true ); }

1 0

r316 - trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing
by tchemit＠users.forge.codelutin.com 04 Feb '13

04 Feb '13

Author: tchemit Date: 2013-02-04 01:37:29 +0100 (Mon, 04 Feb 2013) New Revision: 316 Url: http://forge.codelutin.com/projects/tutti/repository/revisions/316 Log: fix action loading deadlock Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiAction.java Modified: trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiAction.java =================================================================== --- trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiAction.java 2013-02-04 00:36:29 UTC (rev 315) +++ trunk/tutti-ui-swing/src/main/java/fr/ifremer/tutti/ui/swing/AbstractTuttiAction.java 2013-02-04 00:37:29 UTC (rev 316) @@ -134,7 +134,6 @@ if (e instanceof Exception) { ErrorDialogUI.showError((Exception) e); } - timer.cancel(); } finally { if (log.isInfoEnabled()) { log.info("After action: " + this); @@ -166,6 +165,10 @@ protected class ActionTimerTask extends TimerTask { + private final Object lock = new Object(); + + protected boolean canceled; + private final String actionName; private final String actionDescription; @@ -180,48 +183,70 @@ @Override public void run() { - MainUI ui = getContext().getMainUI(); + if (canceled) { + if (log.isInfoEnabled()) { + log.info("Task [" + AbstractTuttiAction.this + "] was already canceled, do nothing"); + } + } else { - updateBusyState(ui, true); + MainUI ui = getContext().getMainUI(); - if (log.isDebugEnabled()) { - log.debug("Task [" + AbstractTuttiAction.this + "] is started, show waiting dialog"); - } - JPanel panel = new JPanel(new BorderLayout()); - panel.setBorder(new TitledBorder((String) null)); - JLabel label = new JLabel(); - EmptyBorder border = new EmptyBorder(5, 5, 5, 5); - label.setBorder(border); - label.setText(_("tutti.message.action.running", actionDescription)); - panel.add(label, BorderLayout.CENTER); - JProgressBar progressBar = new JProgressBar(); - progressBar.setBorder(border); - progressBar.setIndeterminate(true); - panel.add(progressBar, BorderLayout.SOUTH); - d = new JDialog(ui, true); - d.setUndecorated(true); + if (log.isDebugEnabled()) { + log.debug("Task [" + AbstractTuttiAction.this + "] is started, show waiting dialog"); + } + + JPanel panel = new JPanel(new BorderLayout()); + panel.setBorder(new TitledBorder((String) null)); + JLabel label = new JLabel(); + EmptyBorder border = new EmptyBorder(5, 5, 5, 5); + label.setBorder(border); + label.setText(_("tutti.message.action.running", actionDescription)); + panel.add(label, BorderLayout.CENTER); + JProgressBar progressBar = new JProgressBar(); + progressBar.setBorder(border); + progressBar.setIndeterminate(true); + panel.add(progressBar, BorderLayout.SOUTH); + + + d = new JDialog(ui, true); + d.setUndecorated(true); // d.setSize(300, 200); - d.add(panel); - d.pack(); - SwingUtil.center(ui, d); - d.setVisible(true); + d.add(panel); + d.pack(); + SwingUtil.center(ui, d); + + if (log.isInfoEnabled()) { + log.info("Try to open dialog (was canceled ? " + canceled + ")"); + } + if (!canceled) { + + updateBusyState(ui, true); + + d.setVisible(true); + } + } } + @Override public boolean cancel() { - if (log.isDebugEnabled()) { - log.debug("Task [" + AbstractTuttiAction.this + "] canceled."); - } - updateBusyState(getContext().getMainUI(), false); + synchronized (lock) { + canceled = true; + if (log.isInfoEnabled()) { + log.info("Task [" + AbstractTuttiAction.this + "] canceled."); + } + boolean cancel = super.cancel(); - if (d != null) { - d.setVisible(false); + updateBusyState(getContext().getMainUI(), false); + + if (d != null) { + d.setVisible(false); + } + return cancel; } - boolean cancel = super.cancel(); - return cancel; } protected void updateBusyState(MainUI ui, boolean busy) {

1 0