Author: bleny Date: 2013-04-26 10:53:22 +0200 (Fri, 26 Apr 2013) New Revision: 141 Url: http://forge.codelutin.com/projects/franciaflex-magalie/repository/revisions... Log: remove todo, mark requested list as PENDING when necessary Modified: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java Modified: trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java =================================================================== --- trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java 2013-04-26 08:49:46 UTC (rev 140) +++ trunk/magalie-services/src/main/java/com/franciaflex/magalie/services/service/RequestedArticleService.java 2013-04-26 08:53:22 UTC (rev 141) @@ -210,21 +210,12 @@ + " to " + requestedList.getCode()); } - boolean isFinished = false; // TODO brendan 16/04/13 really ? + boolean isFinished = oldAffectation.getStatus().equals(DeliveredRequestedListStatus.COMPLETE); - if (isFinished) { + if ( ! isFinished) { if (log.isInfoEnabled()) { log.info("request list " + oldAffectation.getRequestedList() - + " is complete, save status"); - } - - oldAffectation.setStatus(DeliveredRequestedListStatus.COMPLETE); - - } else { - - if (log.isInfoEnabled()) { - log.info("request list " + oldAffectation.getRequestedList() + " is not complete, putting it back to pending"); }