This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository nuiton-converter. See http://git.nuiton.org/nuiton-converter.git commit 4b221a0067eca53a2c35a9237b2e86287a07a3d3 Author: Tony CHEMIT <chemit@codelutin.com> Date: Wed Jul 23 22:19:21 2014 +0200 fix more code thanks to sonar --- src/main/java/org/nuiton/converter/ConverterUtil.java | 6 +++++- src/main/java/org/nuiton/converter/EnumConverter.java | 6 +++--- src/main/java/org/nuiton/converter/KeyStrokeConverter.java | 2 +- src/main/java/org/nuiton/converter/URIConverter.java | 6 +++--- src/main/java/org/nuiton/converter/URLConverter.java | 6 +++--- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/src/main/java/org/nuiton/converter/ConverterUtil.java b/src/main/java/org/nuiton/converter/ConverterUtil.java index 66dd9a8..bb5a32c 100644 --- a/src/main/java/org/nuiton/converter/ConverterUtil.java +++ b/src/main/java/org/nuiton/converter/ConverterUtil.java @@ -52,7 +52,7 @@ public class ConverterUtil { * <p/> * Method {@link #deregister()} will set back the flag value to {@code false}. */ - static Boolean wasInit = Boolean.FALSE; + private static Boolean wasInit = Boolean.FALSE; /** * Try to find amatching converter for the given {@code type}. @@ -214,4 +214,8 @@ public class ConverterUtil { } wasInit = true; } + + protected ConverterUtil() { + // avoid to instanciate this utility class + } } diff --git a/src/main/java/org/nuiton/converter/EnumConverter.java b/src/main/java/org/nuiton/converter/EnumConverter.java index 2b00455..f9aadd2 100644 --- a/src/main/java/org/nuiton/converter/EnumConverter.java +++ b/src/main/java/org/nuiton/converter/EnumConverter.java @@ -48,7 +48,7 @@ import static org.apache.commons.logging.LogFactory.getLog; public class EnumConverter<E extends Enum> implements NuitonConverter<E> { /** Logger. */ - static Log log = getLog(EnumConverter.class); + private static final Log LOGGER = getLog(EnumConverter.class); /** * Default value to use if try to convert {@code null} value and flag {@link #useDefault} is on. @@ -102,8 +102,8 @@ public class EnumConverter<E extends Enum> implements NuitonConverter<E> { this.enumType = enumType; this.defaultValue = defaultValue; useDefault = defaultValue != null; - if (log.isDebugEnabled()) { - log.debug(toString() + '<' + enumType + '>'); + if (LOGGER.isDebugEnabled()) { + LOGGER.debug(toString() + '<' + enumType + '>'); } } diff --git a/src/main/java/org/nuiton/converter/KeyStrokeConverter.java b/src/main/java/org/nuiton/converter/KeyStrokeConverter.java index 9ba281d..46be257 100644 --- a/src/main/java/org/nuiton/converter/KeyStrokeConverter.java +++ b/src/main/java/org/nuiton/converter/KeyStrokeConverter.java @@ -38,7 +38,7 @@ import static org.apache.commons.logging.LogFactory.getLog; public class KeyStrokeConverter implements NuitonConverter<KeyStroke> { /** Logger. */ - static Log log = getLog(KeyStrokeConverter.class); + private static final Log LOGGER = getLog(KeyStrokeConverter.class); @Override public <T> T convert(Class<T> aClass, Object value) { diff --git a/src/main/java/org/nuiton/converter/URIConverter.java b/src/main/java/org/nuiton/converter/URIConverter.java index f1d4c20..8d35723 100644 --- a/src/main/java/org/nuiton/converter/URIConverter.java +++ b/src/main/java/org/nuiton/converter/URIConverter.java @@ -39,7 +39,7 @@ import static org.apache.commons.logging.LogFactory.getLog; public class URIConverter implements NuitonConverter<URI> { /** Logger. */ - static Log log = getLog(URIConverter.class); + private static final Log LOGGER = getLog(URIConverter.class); @Override public <T> T convert(Class<T> aClass, Object value) { @@ -74,8 +74,8 @@ public class URIConverter implements NuitonConverter<URI> { } public URIConverter() { - if (log.isDebugEnabled()) { - log.debug("init uri converter " + this); + if (LOGGER.isDebugEnabled()) { + LOGGER.debug("init uri converter " + this); } } diff --git a/src/main/java/org/nuiton/converter/URLConverter.java b/src/main/java/org/nuiton/converter/URLConverter.java index 5caecd7..a6f1585 100644 --- a/src/main/java/org/nuiton/converter/URLConverter.java +++ b/src/main/java/org/nuiton/converter/URLConverter.java @@ -39,7 +39,7 @@ import static org.apache.commons.logging.LogFactory.getLog; public class URLConverter implements NuitonConverter<URL> { /** Logger. */ - static Log log = getLog(URLConverter.class); + private static final Log LOGGER = getLog(URLConverter.class); @Override public <T> T convert(Class<T> aClass, Object value) { @@ -74,8 +74,8 @@ public class URLConverter implements NuitonConverter<URL> { } public URLConverter() { - if (log.isDebugEnabled()) { - log.debug("init url converter " + this); + if (LOGGER.isDebugEnabled()) { + LOGGER.debug("init url converter " + this); } } -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.