Tony CHEMIT pushed to branch develop at ultreiaio / ird-observe Commits: 6470e3bb by Tony Chemit at 2021-01-18T17:13:52+01:00 Mark more method final in ContentUI models - - - - - 2 changed files: - client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/data/list/ContentListUIModel.java - client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/data/open/ContentOpenableUIModel.java Changes: ===================================== client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/data/list/ContentListUIModel.java ===================================== @@ -55,15 +55,15 @@ public abstract class ContentListUIModel<R extends DataDtoReference> extends Con return (ContentListUIModelStates<R>) super.getStates(); } - public MoveRequestBuilder.StepSetParentCandidates toMoveRequest() { + public final MoveRequestBuilder.StepSetParentCandidates toMoveRequest() { return MoveRequestBuilder.create(getSource().getScope().getMainReferenceType(), getSource().getScope().getParentReferenceType(), getStates().getSelectedParentId(), getStates().getSelectedIds()); } - public ShowIdRequest getShowIdRequest() { + public final ShowIdRequest getShowIdRequest() { return new ShowIdRequest(getStates()::getSafeSelectedData); } - public ChangeModeRequest toChangeModeRequest() { + public final ChangeModeRequest toChangeModeRequest() { return new ChangeModeRequest(getSource().getScope().getI18nTranslation("type")) { @Override protected SelectNode<?> getSelectNode(ContentUI ui) { ===================================== client/datasource/editor/api/src/main/java/fr/ird/observe/client/datasource/editor/api/content/data/open/ContentOpenableUIModel.java ===================================== @@ -59,12 +59,12 @@ public abstract class ContentOpenableUIModel<D extends DataDto> extends ContentS return (ContentOpenableUIModelStates<D>) super.getStates(); } - public ShowIdRequest getShowIdRequest() { + public final ShowIdRequest getShowIdRequest() { return new ShowIdRequest(getSource()::getReference); } @Override - public Form<D> openForm(ObserveServicesProvider servicesProvider, String selectedId) { + public final Form<D> openForm(ObserveServicesProvider servicesProvider, String selectedId) { open(); Form<D> form; if (selectedId == null) { @@ -80,7 +80,7 @@ public abstract class ContentOpenableUIModel<D extends DataDto> extends ContentS } //FIXME Generate me (better use generation over cryptic code) - public MoveRequestBuilder.StepSetParentCandidates toMoveRequest() { + public final MoveRequestBuilder.StepSetParentCandidates toMoveRequest() { return MoveRequestBuilder.create(getSource().getScope().getMainReferenceType(), getSource().getScope().getParentReferenceType(), getStates().getSelectedParentId(), ImmutableSet.of(getStates().getBean().getId())); } } View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/6470e3bbea34e38532bed532b5... -- View it on GitLab: https://gitlab.com/ultreiaio/ird-observe/-/commit/6470e3bbea34e38532bed532b5... You're receiving this email because of your account on gitlab.com.