This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository topia. See http://git.nuiton.org/topia.git commit 86ec18ff204f05a6040b5000c693851173c5505f Author: Brendan Le Ny <bleny@codelutin.com> Date: Fri Oct 3 15:08:08 2014 +0200 Remove remaining TODO tags in HqlAndParametersBuilder: won't fixes (fixes #2894) --- .../java/org/nuiton/topia/persistence/HqlAndParametersBuilder.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/topia-persistence/src/main/java/org/nuiton/topia/persistence/HqlAndParametersBuilder.java b/topia-persistence/src/main/java/org/nuiton/topia/persistence/HqlAndParametersBuilder.java index e63f42d..766a091 100644 --- a/topia-persistence/src/main/java/org/nuiton/topia/persistence/HqlAndParametersBuilder.java +++ b/topia-persistence/src/main/java/org/nuiton/topia/persistence/HqlAndParametersBuilder.java @@ -122,8 +122,6 @@ public class HqlAndParametersBuilder<E extends TopiaEntity> { public void addEquals(String property, Object value) { Preconditions.checkArgument(StringUtils.isNotEmpty(property)); - // TODO brendan 02/10/13 do not use HQL parameters of Object are primitive types - // TODO brendan 02/10/13 if value is instanceof TopiaEntity, we can check type if (value == null) { addNull(property); } else { @@ -134,8 +132,6 @@ public class HqlAndParametersBuilder<E extends TopiaEntity> { public void addNotEquals(String property, Object value) { Preconditions.checkArgument(StringUtils.isNotEmpty(property)); - // TODO brendan 02/10/13 do not use HQL parameters of Object are primitive types - // TODO brendan 02/10/13 if value is instanceof TopiaEntity, we can check type if (value == null) { addNotNull(property); } else { @@ -158,7 +154,6 @@ public class HqlAndParametersBuilder<E extends TopiaEntity> { protected void addInOrNotIn(String property, Collection<?> values, boolean in) { Preconditions.checkArgument(StringUtils.isNotEmpty(property)); Preconditions.checkNotNull(values); - // TODO brendan 02/10/13 if value is instanceof TopiaEntity, we can check type String aliasedProperty = alias + "." + property; int valuesSize = values.size(); if (valuesSize == 0) { -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.