This is an automated email from the git hooks/post-receive script. New commit to branch develop in repository wikitty. See http://git.nuiton.org/wikitty.git commit 97a7fc9b47d830fe493e3998ad00985647009611 Author: Benjamin POUSSIN <poussin@codelutin.com> Date: Tue Jul 21 12:15:08 2015 +0200 add test for Anomalie #3735: containsOne and containsAll with an empty collection returns all objects but no object should have been returned --- .../java/org/nuiton/wikitty/WikittyClientTest.java | 48 +++++++++++++++++----- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/wikitty-api/src/test/java/org/nuiton/wikitty/WikittyClientTest.java b/wikitty-api/src/test/java/org/nuiton/wikitty/WikittyClientTest.java index ce88f04..da199ce 100644 --- a/wikitty-api/src/test/java/org/nuiton/wikitty/WikittyClientTest.java +++ b/wikitty-api/src/test/java/org/nuiton/wikitty/WikittyClientTest.java @@ -1118,11 +1118,25 @@ public class WikittyClientTest extends WikittyClientAbstractTest { @Test public void testQueryMakerContainsAll() throws IOException { importBooks(); // add 13 livres - WikittyQuery query = new WikittyQueryMaker() - .containsAll(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList("white", "black")).end(); - WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); - Assert.assertEquals(2, results.getTotalResult()); - Assert.assertEquals(2, results.getAll().size()); + { + WikittyQuery query = new WikittyQueryMaker() + .containsAll(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList("white", "black")).end(); + WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); + Assert.assertEquals(2, results.getTotalResult()); + Assert.assertEquals(2, results.getAll().size()); + } + + // with empty list, result must contains nothing + // http://www.nuiton.org/issues/3735 + // Anomalie #3735: containsOne and containsAll with an empty collection returns all objects but no object should have been returned + { + WikittyQuery query = new WikittyQueryMaker() + .containsAll(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList()).end(); + WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); + Assert.assertEquals(0, results.getTotalResult()); + Assert.assertEquals(0, results.getAll().size()); + } + } @Test @@ -1137,11 +1151,25 @@ public class WikittyClientTest extends WikittyClientAbstractTest { @Test public void testQueryMakerContainsOne() throws IOException { importBooks(); // add 13 livres - WikittyQuery query = new WikittyQueryMaker() - .containsOne(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList("white", "black")).end(); - WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); - Assert.assertEquals(9, results.getTotalResult()); - Assert.assertEquals(9, results.getAll().size()); + { + WikittyQuery query = new WikittyQueryMaker() + .containsOne(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList("white", "black")).end(); + WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); + Assert.assertEquals(9, results.getTotalResult()); + Assert.assertEquals(9, results.getAll().size()); + } + + // with empty list, result must contains nothing + // http://www.nuiton.org/issues/3735 + // Anomalie #3735: containsOne and containsAll with an empty collection returns all objects but no object should have been returned + { + WikittyQuery query = new WikittyQueryMaker() + .containsOne(Product.ELEMENT_FIELD_PRODUCT_COLORS, Arrays.asList()).end(); + WikittyQueryResult<Product> results = wikittyClient.findAllByQuery(Product.class, query); + Assert.assertEquals(0, results.getTotalResult()); + Assert.assertEquals(0, results.getAll().size()); + } + } @Test -- To stop receiving notification emails like this one, please contact nuiton.org SCM administrator <admin+scm@nuiton.org>.